On Sat, 12 Oct 2024 00:45:40 GMT, Johny Jose wrote:
>> Timezone data 2024b changes
>
> Johny Jose has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review changes
Besides small comment, looks correct to me, thanks for the changes.
test/jdk/
On Fri, 11 Oct 2024 23:01:20 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect review
>
> src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 767:
>
>> 765: NaN.equa
> Please review this PR which improves the safety of equality checking for
> DecimalFormatSymbols. As certain setters did not throw NPE, this allowed for
> NPE in the equality method. This PR now updates the setters to throw NPE.
>
> In addition to the NPEs, there is also a behavioral change tha
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Minor change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21323/
On Fri, 11 Oct 2024 05:39:20 GMT, Chen Liang wrote:
> Patch a tableswitch instruction's low value to be greater than a high value,
> previously, javap will not print any previous instruction and report
> problematic address/bci to be 0. This is because the iteration of bound
> models require f
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Update BigDecimal.java
-
Changes:
- all: https://git.openjdk.org/jdk/p
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Refining comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Refining comments describing the algorithm
-
Changes:
- all: https://g
On Sat, 12 Oct 2024 08:24:37 GMT, Jaikiran Pai wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'inc should be faster than add on most CPUs'
>
> test/jdk/java/io/Reader/Of.java line 92:
>
>> 90:
>> 91: @
On Sat, 12 Oct 2024 07:47:56 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Sat, 12 Oct 2024 07:47:56 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Typo correction and code style simplification
-
Changes:
- all: https:
On Sat, 12 Oct 2024 06:57:40 GMT, Jaikiran Pai wrote:
>> I would say this current version is fine: that's how we handle encode/decode
>> loop in classes like `String`.
>
> I agree with Roger - the previous version you had:
>
>
> for (int i = 0; i < n; i++)
> cbuf[off + i] = cs.charAt(next
> This Pull Requests proposes an implementation for
> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
> method `public static Reader Reader.of(CharSequence)` will return an
> anonymous, non-synchronized implementation of a `Reader` for each kind of
> `CharSequence` im
On Fri, 11 Oct 2024 22:45:55 GMT, Chen Liang wrote:
>> Uhm... actually that is a quite common pattern we even teach people
>> everyday, and in the past 30 years none of them had a problem understanding
>> it... 🤔 Anyways, really I don't see any benefit in this whole discussion,
>> as I said,
15 matches
Mail list logo
