On Fri, 11 Oct 2024 23:01:20 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reflect review > > src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 767: > >> 765: NaN.equals(other.NaN) && >> 766: // Currency fields are lazy. Init via get call to ensure >> non-null >> 767: getCurrencySymbol().equals(other.getCurrencySymbol()) && > > Probably the same comment refinement can be applied to the location in > `hashCode()`. This and the other comments addressed via https://github.com/openjdk/jdk/pull/21315/commits/d31cb2ebc5eb92978bed4c6f38f1ddfd7ff5452c. Thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21315#discussion_r1797998932
