On Wed, 3 Apr 2024 15:15:24 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall performance
On Fri, 5 Apr 2024 05:17:44 GMT, Alan Bateman wrote:
>> test/jdk/java/lang/Thread/virtual/libSynchronizedNative.c line 29:
>>
>>> 27: Java_SynchronizedNative_runWithSynchronizedNative(JNIEnv *env, jobject
>>> obj, jobject task) {
>>> 28: jclass clazz = (*env)->GetObjectClass(env, obj);
>>>
On Fri, 5 Apr 2024 01:11:49 GMT, David Holmes wrote:
> Does this generate a warning with `-Xcheck:jni` due to exceptions not being
> checked for?
I run with`TEST_OPTS_JAVA_OPTIONS=-Xcheck:jni` and don't see any warnings. Are
you asking about the usage of GetObjectClass (which is not documented
On Wed, 3 Apr 2024 20:17:39 GMT, Joe Darcy wrote:
> When new language features are added, the javax.lang.model may need to be
> updated. For certain classes of features, the API update includes introducing
> a new set of concrete visitors to handle the language feature.
>
> The API scaffolding
On Tue, 2 Apr 2024 02:16:07 GMT, David Holmes wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use non-sse fill (old left in)
>
> This looks like it is still a Draft/work-in-progress. There is only code for
> x64
On Mon, 18 Mar 2024 16:27:58 GMT, Viktor Klang wrote:
> Just a note to self, consider if this should get backported to 22 or not.
Have you decided whether this will be backported to 22?
-
PR Comment: https://git.openjdk.org/jdk/pull/18351#issuecomment-2030716799
On Wed, 3 Apr 2024 15:15:24 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall performance
On Wed, 3 Apr 2024 10:52:10 GMT, Alan Bateman wrote:
> This is a test-only addition to add a test for virtual threads invoking a
> synchronized native method and invoking a native method that enter/exits a
> monitor with JNI MonitorEnter/MonitorExit. The test has been in the loom repo
> for so
On Thu, 4 Apr 2024 22:17:33 GMT, Joshua Cao wrote:
>> Add notes for `HashMap::putAll()` conservative resizing.
>>
>> Note: everything below this line is from the original change. After
>> discussion, we decided to keep the conservative resizing, but we should add
>> an `@implNote` for the deci
> Add notes for `HashMap::putAll()` conservative resizing.
>
> Note: everything below this line is from the original change. After
> discussion, we decided to keep the conservative resizing, but we should add
> an `@implNote` for the decision.
>
> ---
>
> This change mirrors what we did for Co
On Thu, 4 Apr 2024 15:38:36 GMT, Erik Joelsson wrote:
>> FYI: This was trying to address a comment from @magicus
>> https://github.com/openjdk/jdk/pull/14787#discussion_r1514894494 Happy to
>> not follow that convention and/or rename the tool.
>
> I was not aware of such a convention and I can'
On Thu, 4 Apr 2024 16:46:32 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
On Thu, 4 Apr 2024 00:37:45 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests.
>
> src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java
> line 133:
>
>> 131:
I want to kindly check if there are some news regarding the cost/benefit
ratio and prioritization. Any updates that I missed?
Best
Julian
Am Di., 13. Nov. 2018 um 15:26 Uhr schrieb Brian Goetz <
brian.go...@oracle.com>:
> The story here is: we’ve completed our analysis on the feature, and
> conc
On Thu, 4 Apr 2024 17:16:22 GMT, Mahendra Chhipa wrote:
>> Updated following tests to use ProcessTools methods:
>> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
>> test/jdk/java/lang/annotation/LoaderLeakTest.java
>> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
>> test/
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A couple key things we want to be able to say are:
> - `Refer
On Tue, 19 Mar 2024 12:16:29 GMT, Viktor Klang wrote:
> This is a draft PR with a potential solution to 8328366 without regressing
> 8327501.
>
> @DougLea To avoid regressions in the future, where would regression tests for
> this ideally be located?
This pull request has now been integrated.
On Tue, 2 Apr 2024 08:09:44 GMT, Doug Simon wrote:
> Wouldn't it be better to do this intrinsification directly in the JIT without
> calling out to a stub?
I believe the code size is too large for a direct JIT intrinsic. A lot of
registers are also used, which may be an issue.
-
On Tue, 2 Apr 2024 02:16:07 GMT, David Holmes wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use non-sse fill (old left in)
>
> This looks like it is still a Draft/work-in-progress. There is only code for
> x64
On Tue, 19 Mar 2024 12:16:29 GMT, Viktor Klang wrote:
> This is a draft PR with a potential solution to 8328366 without regressing
> 8327501.
>
> @DougLea To avoid regressions in the future, where would regression tests for
> this ideally be located?
Follow-up issue regarding the clearing of
On Tue, 19 Mar 2024 12:16:29 GMT, Viktor Klang wrote:
> This is a draft PR with a potential solution to 8328366 without regressing
> 8327501.
>
> @DougLea To avoid regressions in the future, where would regression tests for
> this ideally be located?
The change looks okay. It's unfortunate we
On Thu, 4 Apr 2024 17:35:43 GMT, Mandy Chung wrote:
>> Suchismith Roy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add jtreg test case
>
> test/jdk/java/lang/RuntimeTests/loadLibrary/LoadLibraryTestAIX.java line 38:
>
>> 36:
On Thu, 4 Apr 2024 11:13:43 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Tue, 19 Mar 2024 12:16:29 GMT, Viktor Klang wrote:
> This is a draft PR with a potential solution to 8328366 without regressing
> 8327501.
>
> @DougLea To avoid regressions in the future, where would regression tests for
> this ideally be located?
FWIW, I've tested this with the quarkus re
On Wed, 3 Apr 2024 20:08:43 GMT, Naoto Sato wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented review comments.
>> Updated EscapePath test.
>
> test/jdk/java/time/nontestng/java/time/chrono/HijrahConf
On Wed, 3 Apr 2024 20:08:04 GMT, Naoto Sato wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented review comments.
>> Updated EscapePath test.
>
> test/jdk/java/time/nontestng/java/time/chrono/HijrahConf
> Updated following tests to use ProcessTools methods:
> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
> test/jdk/java/lang/annotation/LoaderLeakTest.java
> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
> test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java
On Thu, 28 Mar 2024 14:08:44 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Thu, 4 Apr 2024 09:42:48 GMT, Jaikiran Pai wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add some more comments
>
> test/jdk/java/util/zip/Zip64Offsets.java line 1:
>
>> 1: /*
>
> Hello Liam, given tha
> This change fixes a zip64 bug in the launcher that is prevent it from reading
> the manifest of jars where the 'relative offset of local header' field in the
> central directory entry is >4GB. As described in APPNOTE.TXT 4.5.3, the
> offset is too large to be stored in the central directory it
On Thu, 4 Apr 2024 11:13:43 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jm
> When new language features are added, the javax.lang.model may need to be
> updated. For certain classes of features, the API update includes introducing
> a new set of concrete visitors to handle the language feature.
>
> The API scaffolding to support the new feature tends to be considerably
On Tue, 19 Mar 2024 12:16:29 GMT, Viktor Klang wrote:
> This is a draft PR with a potential solution to 8328366 without regressing
> 8327501.
>
> @DougLea To avoid regressions in the future, where would regression tests for
> this ideally be located?
Marked as reviewed by mchung (Reviewer).
On Thu, 4 Apr 2024 14:46:11 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1143:
>>
>>> 1141: @SuppressWarnings("removal")
>>> 1142: SecurityManager sm = System.getSecurityManager();
>>> 1143: if (sm != null
On Thu, 4 Apr 2024 11:13:43 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Thu, 4 Apr 2024 15:24:53 GMT, Severin Gehwolf wrote:
>> make/CompileToolsJdk.gmk line 50:
>>
>>> 48: EXCLUDES := \
>>> 49: build/tools/classlist \
>>> 50: build/tools/runtimeimagelinkdeltaproducer \
>>
>> This directory name is comically long. I guess that's not really a
On Thu, 4 Apr 2024 12:56:41 GMT, Erik Joelsson wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 100 commits:
>>
>> - Fix coment
>> - Fix comment
>> - Fix typo
>> - Revert some now unneded build changes
On Thu, 4 Apr 2024 13:00:33 GMT, Erik Joelsson wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 100 commits:
>>
>> - Fix coment
>> - Fix comment
>> - Fix typo
>> - Revert some now unneded build changes
On Wed, 3 Apr 2024 01:37:37 GMT, Joshua Cao wrote:
>> Add notes for `HashMap::putAll()` conservative resizing.
>>
>> Note: everything below this line is from the original change. After
>> discussion, we decided to keep the conservative resizing, but we should add
>> an `@implNote` for the deci
On Wed, 20 Mar 2024 17:15:49 GMT, Mandy Chung wrote:
>> This is a draft PR with a potential solution to 8328366 without regressing
>> 8327501.
>>
>> @DougLea To avoid regressions in the future, where would regression tests
>> for this ideally be located?
>
> src/java.base/share/classes/java/ut
On Tue, 2 Apr 2024 10:37:02 GMT, Per Minborg wrote:
> This PR proposes to make empty immutable lists always throw UOE on
> `removeFirst` and `removeLast`.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18581#pullrequestreview-198014251
> This is an implementation of JEP JDK-8315129: Module Import Declarations
> (Preview). Please see the JEP for details:
> https://bugs.openjdk.org/browse/JDK-8315129
>
> It is mostly straightforward - the module imports are parsed, and then
> expanded to import-on-demand in `TypeEnter`.
> There
On Tue, 19 Mar 2024 12:16:29 GMT, Viktor Klang wrote:
> This is a draft PR with a potential solution to 8328366 without regressing
> 8327501.
>
> @DougLea To avoid regressions in the future, where would regression tests for
> this ideally be located?
Is there any update on this PR?
-
On Thu, 4 Apr 2024 11:12:43 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
On Thu, 21 Mar 2024 15:35:06 GMT, Severin Gehwolf wrote:
>> Ok, fine. Will the new solution still include a build-time only tool?
>
> Yes, but I'll likely go with the interim solution and that would only require
> the a single "driver" class in the build tree with a `main` method.
Now it's no l
On Thu, 21 Mar 2024 15:30:01 GMT, Magnus Ihse Bursie wrote:
>> Thanks! This will also likely change. I'm thinking of just generating the
>> diff file and putting it into `lib/` of the JDK image. That avoids needing
>> to call this build-time only jlink plugin and this `FixPath` magic.
>
> I see
On Thu, 21 Mar 2024 15:29:45 GMT, Severin Gehwolf wrote:
>> make/Images.gmk line 145:
>>
>>> 143: $(eval $(call SetupJavaCompilation, BUILD_JDK_RUNLINK_CLASSES, \
>>> 144: COMPILER := buildjdk, \
>>> 145: DISABLED_WARNINGS := try, \
>>
>> Why do we get warnings in the java code?
>
On Thu, 14 Mar 2024 17:46:19 GMT, Erik Joelsson wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment in autoconf file
>
> make/Images.gmk line 126:
>
>> 124: RL_BUILD_MODULE_NAME := jdk.unsupported_jli
On Thu, 4 Apr 2024 11:43:07 GMT, Thiago Henrique Hüpner
wrote:
> Should the pull request incorporate a modification to the JAVASE script file
> for JShell, specifically substituting it with `import module java.se`? (right
> now the imports are computed, not read from a file)
Given we need to
On Thu, 4 Apr 2024 07:30:34 GMT, Jan Lahoda wrote:
> This is an implementation of JEP JDK-8315129: Module Import Declarations
> (Preview). Please see the JEP for details:
> https://bugs.openjdk.org/browse/JDK-8315129
>
> It is mostly straightforward - the module imports are parsed, and then
>
On Thu, 4 Apr 2024 10:43:35 GMT, Suchismith Roy wrote:
>> Hotspot loads it like this:
>> https://github.com/openjdk/jdk/blob/b9da14012da5f1f72d4f6e690c18a43e87523173/src/hotspot/os/aix/libperfstat_aix.cpp#L76
>> Are you sure it is supposed to be loaded without member specification?
>
>> Hotspot
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with one additional
commit since the last revision:
Ad
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jm
On Thu, 4 Apr 2024 10:30:08 GMT, Martin Doerr wrote:
> Hotspot loads it like this:
>
> https://github.com/openjdk/jdk/blob/b9da14012da5f1f72d4f6e690c18a43e87523173/src/hotspot/os/aix/libperfstat_aix.cpp#L76
>
>
> Are you sure it is supposed to be loaded without member specification?
Yes i was
On Wed, 3 Apr 2024 12:32:21 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
This change drops the adjustments to the virtual thread scheduler's target
parallelism when virtual threads do file operations on files that are opened
for buffered I/O. These operations are usually just too short to have any
benefit and may have a negative benefit when reading/writing a small n
This is a test-only addition to add a test for virtual threads invoking a
synchronized native method and invoking a native method that enter/exits a
monitor with JNI MonitorEnter/MonitorExit. The test has been in the loom repo
for some time, it can move to the main line in advance of changes to
On Thu, 4 Apr 2024 09:41:50 GMT, Suchismith Roy wrote:
> > Hello @suchismith1993,
> > > Usually there is not such pure .a files that comes packaged with the OS.
> > > They are provided by some applications. So i am not sure how i can make
> > > the tests consistent for such cases.
> > > Do you
On Mon, 1 Apr 2024 22:22:19 GMT, Liam Miller-Cushon wrote:
>> This change fixes a zip64 bug in the launcher that is prevent it from
>> reading the manifest of jars where the 'relative offset of local header'
>> field in the central directory entry is >4GB. As described in APPNOTE.TXT
>> 4.5.3,
On Wed, 3 Apr 2024 07:35:46 GMT, Suchismith Roy wrote:
>> Hello @suchismith1993,
>>
>>> > I adjust the comments which also answer your question. Please add an
>>> > AIX-only test to verify this behavior.
>>>
>>> By test you mean provide the use case for pure .a files ?
>>
>> In the JDK repo,
On Wed, 3 Apr 2024 12:32:21 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
> Tha
On Wed, 3 Apr 2024 22:31:39 GMT, Mandy Chung wrote:
> Thanks for the investigation w.r.t. extending jimage. It does not seem worth
> the effort in pursuing the support of adding resources to an existing jimage
> file. To me, putting the diff data under `lib` directory as a private file is
> a
On Wed, 3 Apr 2024 15:09:15 GMT, Roger Riggs wrote:
>> This PR proposes to make empty immutable lists always throw UOE on
>> `removeFirst` and `removeLast`.
>
> test/jdk/java/util/Collection/MOAT.java line 573:
>
>> 571: c::removeLast);
>> 572: }
>> 573:
>
> Would this tes
This is an implementation of JEP JDK-8315129: Module Import Declarations
(Preview). Please see the JEP for details:
https://bugs.openjdk.org/browse/JDK-8315129
It is mostly straightforward - the module imports are parsed, and then expanded
to import-on-demand in `TypeEnter`.
There is a few notab
66 matches
Mail list logo
