On Wed, 20 Mar 2024 17:15:49 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> This is a draft PR with a potential solution to 8328366 without regressing
>> 8327501.
>>
>> @DougLea To avoid regressions in the future, where would regression tests
>> for this ideally be located?
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1143:
>
>> 1141: @SuppressWarnings("removal")
>> 1142: SecurityManager sm = System.getSecurityManager();
>> 1143: if (sm != null && isCommon)
>
> For common thread pool, if SM is not enabled, it will create
> `ForkJoinWorkerThread` that does not clear thread locals which is different
> than JDK 18 behavior. Is this intentional?
@mlchung I think we should proceed with merging this as-is and look to address
the ThreadLocal situation (or not at all, based on @DougLea's input). Are you
OK with reviewing this as-is?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18374#discussion_r1551827957
