On Fri, 19 May 2023 12:42:22 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Mon, 11 Dec 2023 11:16:05 GMT, Stefan Karlsson wrote:
> There is some logging printed when tests spawns processes. This logging is
> triggered from calls to `OutputAnalyzer`, when it delegates calls to
> `LazyOutputBuffer`.
>
> If we write code like this:
>
> ProcessBuilder pb = ProcessToo
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors o
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors o
On Tue, 12 Dec 2023 03:56:43 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>> [JDK-8292275](https://bugs.openjdk.org/browse
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors o
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors o
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors o
On Mon, 11 Dec 2023 02:36:30 GMT, Guoxiong Li wrote:
> Hi all,
>
> This patch fixes the building failure introduced by
> [JDK-8319577](https://bugs.openjdk.org/browse/JDK-8319577) in old GCC version
> (linux & GCC 7.5.0 locally).
>
> Thanks for the review.
>
> Best Regards,
> -- Guoxiong
P
On Wed, 13 Sep 2023 01:24:05 GMT, Shaojin Wen wrote:
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
This pull request has been closed without b
On Thu, 7 Dec 2023 22:15:51 GMT, Justin Lu wrote:
>> Please review this PR which updates an incorrect code example in
>> _java/text/ChoiceFormat_.
>>
>> ChoiceFormat (and MessageFormat) provide an example of how to produce a
>> pattern that supports singular and plural forms. The ChoiceFormat
On Mon, 11 Dec 2023 23:59:24 GMT, Naoto Sato wrote:
>> Well, at first I had intended for the `notSimpleCurrency` to encapsulate all
>> 3 cases. But upon further investigation, I think the current code is
>> redundant.
>>
>> The third conditional, `(tableEntry & SIMPLE_CASE_COUNTRY_FINAL_CHAR_M
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors o
On Mon, 11 Dec 2023 22:04:23 GMT, Justin Lu wrote:
>> make/jdk/src/classes/build/tools/generatecurrencydata/GenerateCurrencyData.java
>> line 347:
>>
>>> 345: // otherwise it will leak out into
>>> Currency:getAvailableCurrencies
>>> 346: boolean notFutureCurrency =
>>
On Mon, 11 Dec 2023 22:06:58 GMT, Justin Lu wrote:
>> IIUC, this should have happened before, as a currency update like "XXA" ->
>> "XXB" on a future date is pretty usual. I think this issue was simply not
>> discovered by any users till now.
>
> I think this wasn't discovered/hasn't failed the
Reflection is not retrieving generic type information for mandated parameters.
This is a known issue which has been explicitly stated in the API of some
reflection methods. Fix for
[JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the parameters
of compact constructors of record c
> This is a doc change to clarify what the `Default Locale` is, and how it is
> established during the system startup using the system properties. Those
> locale-related system properties have existed since the early days of Java,
> but have never been publicly documented before. It is also the
On Mon, 11 Dec 2023 22:42:56 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> src/java.base/share/classes/java/util/Locale.java line 270:
>
>> 268: *
>> 269: * The locale-related
> This is a doc change to clarify what the `Default Locale` is, and how it is
> established during the system startup using the system properties. Those
> locale-related system properties have existed since the early days of Java,
> but have never been publicly documented before. It is also the
On Mon, 11 Dec 2023 18:54:25 GMT, Naoto Sato wrote:
> This is a doc change to clarify what the `Default Locale` is, and how it is
> established during the system startup using the system properties. Those
> locale-related system properties have existed since the early days of Java,
> but have
On Mon, 11 Dec 2023 19:42:30 GMT, Naoto Sato wrote:
>> Updated the Currency build process to disallow any Currencies that are
>> future Currencies. This prevents the future currency, "XCG" from leaking out
>> into `Currency.getAvailableCurrencies()`. (This was only exposed now, since
>> the pr
On Mon, 11 Dec 2023 19:38:38 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> sinc
> Please review this PR which incorporates the ISO 4217 Amendment 176 Update.
> As the replacement of `ANG` to `XCG` won't occur until 2025, this change does
> not need to go into JDK22. `HR` was also updated to remove the past cutover
> dates.
>
> An existing test in _ValidateISO4217.java_ che
On Mon, 11 Dec 2023 03:42:51 GMT, Srinivas Vamsi Parasa
wrote:
>> Hello Vamsi (@vamsi-parasa),
>>
>> I made the process simpler: added all variants to be compared into
>> ArraysSort class
>> (set the same package org.openjdk.bench.java.util). It will run all sorts
>> incl. sort from jdk
>> in
> It looks like we can skip copying of `byte[]` in
> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
> `java.io`.
>
> See comment by @vlsi in
> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78697ecca66947c395adda0d9c49a85bf696e677ecbd977af1R612
Serge
On Mon, 11 Dec 2023 14:58:57 GMT, Markus KARG wrote:
>> Sergey Tsypanov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits
> It looks like we can skip copying of `byte[]` in
> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
> `java.io`.
>
> See comment by @vlsi in
> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78697ecca66947c395adda0d9c49a85bf696e677ecbd977af1R612
Serge
On Mon, 11 Dec 2023 14:54:37 GMT, Markus KARG wrote:
>> Sergey Tsypanov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits
On Mon, 11 Dec 2023 03:03:44 GMT, Justin Lu wrote:
>> Please review this PR which incorporates the ISO 4217 Amendment 176 Update.
>> As the replacement of `ANG` to `XCG` won't occur until 2025, this change
>> does not need to go into JDK22. `HR` was also updated to remove the past
>> cutover d
On Mon, 11 Dec 2023 02:59:02 GMT, Justin Lu wrote:
>> test/jdk/java/util/Currency/ValidateISO4217.java line 181:
>>
>>> 179: // without updating ISO4217Codes
>>> 180: String futureCurr = tokens.nextToken();
>>> 181:
>>> testCurrencies.
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
Aggelos Biboudis has updated the pull request incrementally with one additional
commit since the last revision:
Cleanup
On Mon, 11 Dec 2023 13:48:18 GMT, Aleksei Voitylov
wrote:
> Since JDK-8311906, if CompactStrings is not enabled, index is not considered
> when calling extractCodepoints from StringUTF16.toBytes(). Because of that
> the last elements of the source codepoints array are stripped from the
> resu
This is a doc change to clarify what the `Default Locale` is, and how it is
established during the system startup using the system properties. Those
locale-related system properties have existed since the early days of Java, but
have never been publicly documented before. It is also the intentio
On Mon, 4 Dec 2023 11:58:55 GMT, Magnus Ihse Bursie wrote:
> I can't say anything for sure, but I picked up some positive vibes from our
> internal chat. I think the idea was that libsleef could potentially cover up
> vector math for all platforms that the current Intel lib solution is missing
On Wed, 6 Dec 2023 20:55:48 GMT, Naoto Sato wrote:
>> Currently, Locale-related system properties, such as `user.language` or
>> `user.country`, are initialized when the `Locale` class is loaded. Making
>> them static properties is safer than relying on the `Locale` class loading
>> timing, wh
On Mon, 11 Dec 2023 17:40:24 GMT, Lance Andersen wrote:
> I don't have a preference whether we deal with input.jar separately, but
> these tests are not that complex so I do not see a risk if they are all
> converted at once, or done piece meal
Thanks, I'll extend the goal of this PR to remove
On Mon, 11 Dec 2023 17:22:14 GMT, Eirik Bjorsnos wrote:
> > One quick comment, if we are updating this test, we should look to get rid
> > of input.zip
>
> I started going down that road, but felt uneasy about the amount of unrelated
> changes in a single PR. I'd like to make efficient use of
On Mon, 11 Dec 2023 16:51:28 GMT, Lance Andersen wrote:
> One quick comment, if we are updating this test, we should look to get rid of
> input.zip
I started going down that road, but felt uneasy about the amount of unrelated
changes in a single PR. I'd like to make efficient use of reviewer
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
Aggelos Biboudis has updated the pull request with a new target base due to a
merge or a rebase. The pull request now cont
On Mon, 11 Dec 2023 15:01:06 GMT, Severin Gehwolf wrote:
> NVM. Reproduced it.
... and fixed with
[b21585b](https://github.com/openjdk/jdk/pull/14787/commits/b21585bac17cdfe46ac3f2f6587b8a6b43a1cd56)
-
PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-1850473199
On Fri, 8 Dec 2023 20:28:20 GMT, Eirik Bjorsnos wrote:
> Please review this PR which suggests we rewrite the
> `../zip/ZipFile/ReadZip.java` test to JUnit.
>
> The current test is a single main method with a sequence of fairly unrelated
> scenarios. It would benefit from a rewrite to multiple
On Mon, 11 Dec 2023 16:26:52 GMT, Per Minborg wrote:
> This PR is a backport of https://github.com/openjdk/jdk/pull/16993
Looks good (already approved in master)
-
Marked as reviewed by mcimadamore (Reviewer).
PR Review: https://git.openjdk.org/jdk22/pull/7#pullrequestreview-17756
On Mon, 11 Dec 2023 16:26:52 GMT, Per Minborg wrote:
> This PR is a backport of https://github.com/openjdk/jdk/pull/16993
This pull request has now been integrated.
Changeset: e88a0220
Author:Per Minborg
URL:
https://git.openjdk.org/jdk22/commit/e88a02207240b848de5aaa6aae2c64b732fde
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jm
This PR is a backport of https://github.com/openjdk/jdk/pull/16993
-
Commit messages:
- Backport d13302f8b06f65319426a25a9368abaf72f3c247
Changes: https://git.openjdk.org/jdk22/pull/7/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=7&range=00
Issue: https://bugs.openjdk.
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
Aggelos Biboudis has updated the pull request incrementally with one additional
commit since the last revision:
Remove
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
Aggelos Biboudis has updated the pull request incrementally with 11 additional
commits since the last revision:
- Merge
ClassFile API models and parses signatures, however parsing of the signatures
mostly throws IIOBE when it fails.
This patch improves SignaturesImpl parsing methods implementation and errors
handling and adds relevant negative tests.
The parser is not an ultimate signatures validator yet, however
Please review this PR which suggests we rewrite the
`../zip/ZipFile/ReadZip.java` test to JUnit.
The current test is a single main method with a sequence of fairly unrelated
scenarios. It would benefit from a rewrite to multiple JUnit test methods and
some general modernization and simplificat
Since JDK-8311906, if CompactStrings is not enabled, index is not considered
when calling extractCodepoints from StringUTF16.toBytes(). Because of that the
last elements of the source codepoints array are stripped from the resulting
UTF16 string, which fires in other places (e.g. during RegEx pr
On Mon, 11 Dec 2023 13:56:50 GMT, Sergey Tsypanov wrote:
>> It looks like we can skip copying of `byte[]` in
>> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
>> `java.io`.
>>
>> See comment by @vlsi in
>> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1b
On Mon, 11 Dec 2023 09:56:49 GMT, Severin Gehwolf wrote:
> > Blowing away the generated image and retrying with --verbose tripped this
> > assert
> > ```
> > java.lang.AssertionError: handling of scratch options failed
> > at
> > jdk.jlink/jdk.tools.jlink.internal.JlinkTask.logPackagedModul
On Mon, 11 Dec 2023 14:06:43 GMT, Stefan Karlsson wrote:
>> [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename
>> createJavaProcessBuilder' changed the name of the ProcessTools helper
>> functions used to create `ProcessBuilder`s used to spawn new java test
>> processes.
>>
>
On Mon, 11 Dec 2023 02:36:30 GMT, Guoxiong Li wrote:
> Hi all,
>
> This patch fixes the building failure introduced by
> [JDK-8319577](https://bugs.openjdk.org/browse/JDK-8319577) in old GCC version
> (linux & GCC 7.5.0 locally).
>
> Thanks for the review.
>
> Best Regards,
> -- Guoxiong
J
> [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename
> createJavaProcessBuilder' changed the name of the ProcessTools helper
> functions used to create `ProcessBuilder`s used to spawn new java test
> processes.
>
> We now have `createTestJavaProcessBuilder` and
> `createLimite
> [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename
> createJavaProcessBuilder' changed the name of the ProcessTools helper
> functions used to create `ProcessBuilder`s used to spawn new java test
> processes.
>
> We now have `createTestJavaProcessBuilder` and
> `createLimite
On Mon, 11 Dec 2023 13:01:25 GMT, Jorn Vernee wrote:
> Improve the test by being more lenient to related code cache exhaustion
> errors. The important thing is that we don't terminate with a fatal error,
> which the new code now checks for explicitly. The check for that is based on
> what is d
> It looks like we can skip copying of `byte[]` in
> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
> `java.io`.
>
> See comment by @vlsi in
> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78697ecca66947c395adda0d9c49a85bf696e677ecbd977af1R612
Serge
Improve the test by being more lenient to related code cache exhaustion errors.
The important thing is that we don't terminate with a fatal error, which the
new code now checks for explicitly. The check for that is based on what is done
by `./test/hotspot/jtreg/runtime/ErrorHandling/HsErrFileUti
There is some logging printed when tests spawns processes. This logging is
triggered from calls to `OutputAnalyzer`, when it delegates calls to
`LazyOutputBuffer`.
If we write code like this:
ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(...);
OutputAnalyzer output = new OutputA
8321641: ClassFile ModuleAttribute.ModuleAttributeBuilder::moduleVersion spec
contains a copy-paste error
-
Commit messages:
- Backport 3c6459e1de9e75898a1b32a95acf684050fbe1af
Changes: https://git.openjdk.org/jdk22/pull/5/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=5
On Mon, 11 Dec 2023 10:00:45 GMT, Adam Sotona wrote:
> This is a fix of ClassFile
> ModuleAttribute.ModuleAttributeBuilder::moduleVersion javadoc copy-paste
> error.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: 3c6459e1
Author:Adam Sotona
On Mon, 11 Dec 2023 10:00:45 GMT, Adam Sotona wrote:
> This is a fix of ClassFile
> ModuleAttribute.ModuleAttributeBuilder::moduleVersion javadoc copy-paste
> error.
>
> Please review.
>
> Thanks,
> Adam
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.o
This is a fix of ClassFile
ModuleAttribute.ModuleAttributeBuilder::moduleVersion javadoc copy-paste error.
Please review.
Thanks,
Adam
-
Commit messages:
- 8321641: ClassFile ModuleAttribute.ModuleAttributeBuilder::moduleVersion
spec contains a copy-paste error
Changes: https://
On Tue, 5 Dec 2023 19:15:53 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
[JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename
createJavaProcessBuilder' changed the name of the ProcessTools helper functions
used to create `ProcessBuilder`s used to spawn new java test processes.
We now have `createTestJavaProcessBuilder` and `createLimitedTestJavaProcess
66 matches
Mail list logo
