On Mon, 11 Dec 2023 16:51:28 GMT, Lance Andersen <lan...@openjdk.org> wrote:
> One quick comment, if we are updating this test, we should look to get rid of > input.zip I started going down that road, but felt uneasy about the amount of unrelated changes in a single PR. I'd like to make efficient use of reviewer time, so my preference was to focus on the JUnit conversion, without too many other changes. If you prefer that we get rid of input.zip and also convert the affected tests to JUnit in the same PR, then I'm happy to switch strategy. Note that `StreamZipEntriesTest` also uses `input.jar`, this is also read by `Available`, `CopyJar`, `GetDirEntry`, `ReleaseInflater`. Should we get rid of `input.jar` as well, or perhaps defer that to a follow-up? ------------- PR Comment: https://git.openjdk.org/jdk/pull/17038#issuecomment-1850524996
