On Mon, 11 Dec 2023 02:59:02 GMT, Justin Lu <j...@openjdk.org> wrote:
>> test/jdk/java/util/Currency/ValidateISO4217.java line 181: >> >>> 179: // without updating ISO4217Codes >>> 180: String futureCurr = tokens.nextToken(); >>> 181: >>> testCurrencies.add(Currency.getInstance(futureCurr)); >> >> I'd not add the future currency, and fix it in the code not to add future >> currency in available currencies. > > Updated the Currency build process to disallow any Currencies that are future > Currencies. This prevents the future currency, "XCG" from leaking out into > `Currency.getAvailableCurrencies()`. (This was only exposed now, since the > previous future Currencies were already ones expected to be found in > `Currency.getAvailableCurrencies()`. For example, Amendment 174 where HRK was > replaced by EUR. > > (Tiers 1-5 clean with this change) IIUC, this should have happened before, as a currency update like "XXA" -> "XXB" on a future date is pretty usual. I think this issue was simply not discovered by any users till now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17023#discussion_r1423040892