On Fri, 11 Aug 2023 02:33:05 GMT, chenggwang wrote:
> Sorry, my description in Issue JDK-8314194(which I submitted) is ambiguous
> and makes you think of Phaser. My intention is that each generation of
> CyclicBarrier barrierCommand can change. Let me give you a scenario
> For example, the U.S.
On Tue, 12 Sep 2023 16:11:56 GMT, Martin Buchholz wrote:
> We should try to retain designed immutability in concurrency classes. Having
> had the experience of having fixed many bugs with knobs tunable at runtime.
> If you make a field mutable, you need to think not just about "set", but also
On Fri, 15 Sep 2023 22:17:42 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Fri, 15 Sep 2023 13:32:39 GMT, Alexey Semenyuk wrote:
>> On Windows, restart app launcher in a way that when the parent app launcher
>> process terminates, the child app launcher process is automatically
>> terminated.
>
> Alexey Semenyuk has updated the pull request incrementally with two
On Fri, 15 Sep 2023 20:24:35 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition, `lo
On Wed, 13 Sep 2023 23:00:23 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX512 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> This PR shows upto ~7x improvement for 32-bit datatypes (int, floa
> Add a `finally` block to delete the created files.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8315960: Remove vestigial unused import
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15757/files
- new: h
On 15/09/2023 5:00 pm, Simone Bordet wrote:
David,
On Thu, Sep 14, 2023 at 4:33 AM David Holmes wrote:
I've created a draft PR here:
https://github.com/openjdk/jdk/pull/15732
can you apply that patch, build and re-test? Hopefully that will show
which thread is doing the missing initializatio
On Fri, 15 Sep 2023 15:40:25 GMT, Alexey Semenyuk wrote:
> Run jpackage jtreg tests on Windows sequentially. Asynch execution of
> `msiexec.exe` that unpacks msi files doesn't work well.
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/j
> Please review this PR which is a continuation of
> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
> code from the _sun.util.Calendar_ classes.
>
> `forceStandardTime` is always false.
>
> In addition, `locale` is never by used by _CalendarDate_ or any inheritors
On Fri, 1 Sep 2023 06:12:57 GMT, Alan Bateman wrote:
> > Alan, you mentioned that DualPivotQuicksort will need detailed review. Can
> > we go ahead and start reviewing? Laurent checked performance, JMH results
> > look fine.
>
> As before, I think the main question with this change is whether
On Fri, 15 Sep 2023 18:54:19 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition, `lo
On Fri, 15 Sep 2023 19:05:12 GMT, Justin Lu wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clarify implementation after removal of if else block
>
> src/java.base/share/classes/sun/util/calendar/AbstractCalendar.java
> Add a `finally` block to delete the created files.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8315960: Remove @BeforeAll method
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15757/files
- new: https:/
On Thu, 14 Sep 2023 23:58:33 GMT, Brian Burkhalter wrote:
> [...] perhaps it would be worthwhile to convert to Junit
Please see dad75c580e65c4cc76f8f59e25295d904eb61410.
-
PR Comment: https://git.openjdk.org/jdk/pull/15757#issuecomment-1721729369
> Add a `finally` block to delete the created files.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8315960: Convert test to JUnit 5
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15757/files
- new: https://
On Fri, 15 Sep 2023 18:54:19 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition, `lo
> Please review this PR which is a continuation of
> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
> code from the _sun.util.Calendar_ classes.
>
> `forceStandardTime` is always false.
>
> In addition, `locale` is never by used by _CalendarDate_ or any inheritors
On Fri, 15 Sep 2023 18:06:10 GMT, Pavel Rappo wrote:
>> This modernizes an example to use the extended for-statement introduced in
>> JDK 1.5.
>>
>> I understand that StringTokenizer is a legacy class. But legacy or not, a
>> class shouldn't promote older constructs when newer fit better. Espe
On Fri, 15 Sep 2023 16:20:15 GMT, Naoto Sato wrote:
> No need to create another PR for such changes IMO.
> Although it may be a bit odd to re-use the same variable names for different
> types, I might keep the original `myDate`/`myNumber` that aligns with other
> locations in the class descript
> This modernizes an example to use the extended for-statement introduced in
> JDK 1.5.
>
> I understand that StringTokenizer is a legacy class. But legacy or not, a
> class shouldn't promote older constructs when newer fit better. Especially
> when advising on preferred alternatives to itself.
On Wed, 13 Sep 2023 15:43:45 GMT, Pavel Rappo wrote:
> This is a simple PR to fix a few typos in the doc comments of
> java.io.StreamTokenizer. When reviewing it, please double-check my proposal
> for L481. For this, you should ideally read the complete comment to the
> `lowerCaseMode` method.
> This PR is to incorporate the latest Unicode 15.1, which was released
> yesterday. Besides the usual character data update, an upgraded
> implementation of RegEx which reflects the Indic Consonant Break specified in
> the latest Unicode Annex #29 ("Unicode Text Segmentation") is included. A
>
> javap uses proprietary com.sun.tools.classfile library to parse class files.
>
> This patch converts javap to use Classfile API.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
adding servicea
On Wed, 13 Sep 2023 12:39:00 GMT, Pavel Rappo wrote:
> This modernizes an example to use the extended for-statement introduced in
> JDK 1.5.
>
> I understand that StringTokenizer is a legacy class. But legacy or not, a
> class shouldn't promote older constructs when newer fit better. Especiall
Run jpackage jtreg tests on Windows sequentially. Asynch execution of
`msiexec.exe` that unpacks msi files doesn't work well.
-
Commit messages:
- 8314909: tools/jpackage/windows/Win8282351Test.java fails with
java.lang.AssertionError: Expected [0]. Actual [1618]:
Changes: https:/
I’ve been tinkering with just such an implementation. Here are a few issues
that I’m sussing out:
- compound templates (partial templates)
- identifier vs string
- lists of identifiers, strings and values
- list separators (comma, or, and)
- lack of meta data for some platforms
- odd ball d
On Sat, 22 Jul 2023 04:44:21 GMT, Stuart Marks wrote:
>> See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734 and
>> https://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8311905
>
> Hi, thanks for the background and the discussion of the alternatives. I'm not
> sure that drafting the
On Fri, 15 Sep 2023 09:42:24 GMT, Adam Sotona wrote:
>> javap uses proprietary com.sun.tools.classfile library to parse class files.
>>
>> This patch converts javap to use Classfile API.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with
On Tue, 29 Aug 2023 20:00:49 GMT, Nikita Sakharin wrote:
>> `Collections.rotate` method contains a bug. This method throws
>> IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way
>> to reproduce:
>>
>> final int size = (1 << 30) + 1;
>> final List list = new ArrayList<>(s
On Thu, 14 Sep 2023 18:03:48 GMT, Brian Burkhalter wrote:
> If this code does not interact with ACL-based security, then it's not clear
> to me that there's anything to be done here.
Right, these methods were created with POSIX file permissions in mind. On the
surface, the only result it can r
One of the examples in the String Template JEPs, and a stated motivating
factor behind its design, is SQL. Template processors are objects so that
use cases like constructing SQL statements aren't injection prone.
The questions I want to pose are:
* Should java.sql provide an implementation of Te
This change fixes two errors in inline HTML styles in the `java.lang` package:
- wrong CSS property name in `java.lang.String`
- CSS declaration terminated by colon instead of semicolon in
`java.lang.Thread`
Both errors caused the style declarations to be ignored and an error message to
be
On Thu, 14 Sep 2023 13:45:30 GMT, Per Minborg wrote:
> This PR proposes to use hexadecimal formatting for raw addresses in
> `VarHandleSegmentViewBase`.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/15742
On Fri, 15 Sep 2023 06:06:18 GMT, Per Minborg wrote:
>> This PR proposes to use hexadecimal formatting for raw addresses in
>> `VarHandleSegmentViewBase`.
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrela
> On Windows, restart app launcher in a way that when the parent app launcher
> process terminates, the child app launcher process is automatically
> terminated.
Alexey Semenyuk has updated the pull request incrementally with two additional
commits since the last revision:
- Misplaced canRunL
On Tue, 12 Sep 2023 19:47:19 GMT, Alexey Semenyuk wrote:
> On Windows, restart app launcher in a way that when the parent app launcher
> process terminates, the child app launcher process is automatically
> terminated.
Will add a test
-
PR Comment: https://git.openjdk.org/jdk/pul
On Fri, 15 Sep 2023 06:06:18 GMT, Per Minborg wrote:
>> This PR proposes to use hexadecimal formatting for raw addresses in
>> `VarHandleSegmentViewBase`.
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrela
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and ForkJ
On Mon, 14 Aug 2023 20:23:13 GMT, Aleksey Shipilev wrote:
>> `Collections.rotate` method contains a bug. This method throws
>> IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way
>> to reproduce:
>>
>> final int size = (1 << 30) + 1;
>> final List list = new ArrayList<>(
On Thu, 17 Aug 2023 09:23:30 GMT, Pavel Rappo wrote:
>>> These benchmarks are all small arrays. We need to check for possible
>>> regressions here.
>>
>> Sorry, all large arrays. I suspect that the average-length sort is not
>> represented.
>>
>>> Also, I'm rather concerned that we might los
> javap uses proprietary com.sun.tools.classfile library to parse class files.
>
> This patch converts javap to use Classfile API.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
fixed TestClass
On Wed, 30 Aug 2023 10:55:48 GMT, Laurent Bourgès wrote:
>> * improved mixed insertion sort (makes whole sorting faster)
>> * introduced Radix which sort shows several times boost of performance and
>> has linear complexity instead of n*ln(n)
>> * improved merging sort for almost sorted data
>>
On Wed, 13 Sep 2023 20:15:09 GMT, Naoto Sato wrote:
> This PR is to incorporate the latest Unicode 15.1, which was released
> yesterday. Besides the usual character data update, an upgraded
> implementation of RegEx which reflects the Indic Consonant Break specified in
> the latest Unicode Ann
On Wed, 13 Sep 2023 09:50:35 GMT, Alan Bateman wrote:
> Unsafe.{shouldBeInitialized,ensureClassInitialized} are deprecated for
> removal since JDK 15. It's time to remove them.
> Lookup.ensureInitialized(Class) was added in Java 15 as a standard API to
> ensure that an accessible class is init
On Wed, 13 Sep 2023 22:55:00 GMT, Naoto Sato wrote:
>> This modernizes an example to use the extended for-statement introduced in
>> JDK 1.5.
>>
>> I understand that StringTokenizer is a legacy class. But legacy or not, a
>> class shouldn't promote older constructs when newer fit better. Espec
On 15/09/2023 09:09, Andrew Leonard wrote:
Hi,
jrt-fs.jar is the only jar that is not built (or re-built) with the
"Build JDK", and I was wondering why?
The JAR file contains the "jrt" file system provider for the runtime.
IDE or other tools running on JDK 8/11/etc. need to be able to cre
Hi,
jrt-fs.jar is the only jar that is not built (or re-built) with the "Build
JDK", and I was wondering why?
To fully benefit from reproducible builds, would it not be more beneficial
to re-build it after "Build JDK" generation? Thereby ensuring all java code
is built based on the latest compiler
On Thu, 14 Sep 2023 23:03:22 GMT, Paul Sandoz wrote:
> That neatly covers multiple element types and Java-based insertion sort
> algorithms (although I don't know why we need two since mixed insertion
> effectively embeds the other).
@PaulSandoz There are two insertion sorts in DPQ: mixedInser
David,
On Thu, Sep 14, 2023 at 4:33 AM David Holmes wrote:
> I've created a draft PR here:
>
> https://github.com/openjdk/jdk/pull/15732
>
> can you apply that patch, build and re-test? Hopefully that will show
> which thread is doing the missing initialization.
We have attached the logs to the
51 matches
Mail list logo
