On Fri, 15 Sep 2023 06:06:18 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> This PR proposes to use hexadecimal formatting for raw addresses in >> `VarHandleSegmentViewBase`. > > Per Minborg has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into vh-hex > - VarHandleSegmentViewBase::newIllegalArg... to use hexadecimal form There are many other places where we print addresses, for instance a in `LayoutPath`, when slicing a segment, or when reading an address with a layout from a segment to name a few. We should fix all of them so that we don't create an inconsistent way of printing addresses. There are also cases which are not present in mainline, like the UOE throw from VarHandleSegmentViewBase: https://github.com/openjdk/panama-foreign/blob/cbaf7084417a2f87ddf7a8721893931d02416271/src/java.base/share/classes/java/lang/invoke/VarHandleSegmentViewBase.java#L61 I think it might be better to fix this in the panama-foreign repo, and then move over to this repo after the JEP for 22 is integrated (which contains some of the new code). ------------- PR Comment: https://git.openjdk.org/jdk/pull/15742#issuecomment-1721227791
