On Wed, 13 Sep 2023 20:15:09 GMT, Naoto Sato <na...@openjdk.org> wrote:
> This PR is to incorporate the latest Unicode 15.1, which was released
> yesterday. Besides the usual character data update, an upgraded
> implementation of RegEx which reflects the Indic Consonant Break specified in
> the latest Unicode Annex #29 ("Unicode Text Segmentation") is included. A
> corresponding CSR has also been drafted.
make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java
line 65:
> 63: * args[3...]: Names of the property to generate the conditions
> 64: */
> 65: public class GenerateExtraProperties {
Suggestion:
public class GenerateExtraProperties {
make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java
line 118:
> 116: if (r.start == r.last) {
> 117: return (" ".repeat(12) + "cp == 0x" + toHexString(r.start));
> 118: } else if (r.start == r.last - 1) {
Suggestion:
} else if (r.start == r.last - 1) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15728#discussion_r1327033148
PR Review Comment: https://git.openjdk.org/jdk/pull/15728#discussion_r1327033517
