On Mon, 4 Sep 2023 08:24:19 GMT, Alan Bateman wrote:
>> In the virtual thread implementation, thread identity switches to the
>> carrier before freezing and switches back to the virtual thread after
>> thawing. This was a forced move due to issues getting JVMTI to work with
>> virtual threads.
On Wed, 6 Sep 2023 03:34:04 GMT, 温绍锦 wrote:
>> BigDecimal is a commonly used class in business development, It is often
>> necessary to perform toString or toPlainString operations on BigDecimal.
>>
>> The current version uses StringBuilder resulting in multiple memory
>> allocations, I made a
On Thu, 31 Aug 2023 17:09:40 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
> BigDecimal is a commonly used class in business development, It is often
> necessary to perform toString or toPlainString operations on BigDecimal.
>
> The current version uses StringBuilder resulting in multiple memory
> allocations, I made a modification to improve performance.
>
> Because
On Tue, 5 Sep 2023 15:46:17 GMT, 温绍锦 wrote:
>> BigDecimal is a commonly used class in business development, It is often
>> necessary to perform toString or toPlainString operations on BigDecimal.
>>
>> The current version uses StringBuilder resulting in multiple memory
>> allocations, I made a
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
On Tue, 5 Sep 2023 16:05:14 GMT, Qing Xiao wrote:
>> `/test/jdk/tools/lib/tests/JImageValidator.java`, tests in
>> `/test/jdk/tools/jlink`, and `/test/jdk/tools/jimage`,
>> `/test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java` use
>> on com.sun.tools.classfile and should be co
On Tue, 5 Sep 2023 19:09:23 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315558)
>> which is a conformance change to document some exceptions in the
>> specification of java.text.StringCharacterIterator.
>
> Justin Lu has updated the pull request
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
There are a number of files in the `test` directory that have an incorrect
copyright header, which includes the "classpath" exception text. This patch
removes that text from all test files that I could find it in. I did this using
a combination of `sed` and `grep`. Reviewing this patch is probab
> Introducing a new formatting class for locale-dependent list patterns. The
> class is to provide the functionality from the Unicode Consortium's LDML
> specification for [list
> patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns).
> For example, given a list of Stri
> Introducing a new formatting class for locale-dependent list patterns. The
> class is to provide the functionality from the Unicode Consortium's LDML
> specification for [list
> patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns).
> For example, given a list of Stri
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote:
>> Rename createJavaProcessBuilder so that it is not used by mistake instead of
>> createTestJvm.
>>
>> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
>> -i -e
>> "s/createJavaProcessBuilder(/createJavaProcessBu
On Tue, 5 Sep 2023 21:14:00 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removing unnecessary commas
>
> src/java.base/share/classes/java/text/ListFormat.java line 90:
>
>> 88: * method specifie
On Mon, 4 Sep 2023 07:28:03 GMT, Aleksey Shipilev wrote:
> Similar to other issues in the same area. I have no SPARC machine to test the
> build on, but this matches other fixes for other architectures
> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
> after t
On Mon, 4 Sep 2023 15:54:41 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign). T
On Tue, 29 Aug 2023 16:51:49 GMT, Naoto Sato wrote:
>> Introducing a new formatting class for locale-dependent list patterns. The
>> class is to provide the functionality from the Unicode Consortium's LDML
>> specification for [list
>> patterns](https://www.unicode.org/reports/tr35/tr35-genera
On Tue, 5 Sep 2023 19:50:26 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/text/ListFormat.java line 560:
>>
>>> 558: * The {@code UNIT} ListFormat style. This style concatenates
>>> 559: * elements, useful for enumerating units.
>>> 560: */
>>
>> The word
On Fri, 1 Sep 2023 07:22:12 GMT, Matthias Baesken wrote:
> on some RHEL Linux 8.X machines , we run into errors in test
> tools/jpackage/share/RuntimePackageTest.java#id0 , error can be seen below.
> It looks like these errors occur when running the jtreg tests with higher
> concurrency, I did
On Tue, 5 Sep 2023 20:25:52 GMT, Roger Riggs wrote:
>> Good point. Will add some kind of limitation.
>
> I can't see what arbitrary limit would make sense.
> But perhaps an APINote that formatting the string from an excessively long
> list may exceed memory or string sizes. (Without being speci
On Tue, 5 Sep 2023 20:29:53 GMT, Joe Wang wrote:
>> Type and Style select a pattern defined for the locale. (for the zero arg
>> and three arg getInstance methods).
>> I think I would avoid the term "concatenation", the type defines a pattern
>> that contains punctuation and connecting words. T
On Tue, 5 Sep 2023 20:15:26 GMT, Roger Riggs wrote:
>> I think that Type/Style/Locale forming a specific pattern is an
>> implementation detail, so I would not describe it in the spec (although as
>> you say they form a specific pattern in the impl). It could be that an impl
>> of 3-arg getIns
On Tue, 5 Sep 2023 19:50:29 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/text/ListFormat.java line 521:
>>
>>> 519: var sb = new StringBuilder(256).append(patterns[START]);
>>> 520: IntStream.range(2, count - 1).forEach(i ->
>>> sb.append(middleBetween).append("{")
On Tue, 5 Sep 2023 20:17:14 GMT, Naoto Sato wrote:
>> I'd stick to the general first sentence structure used by DateFormat,
>> Format, and MessageFormat.
>> ("tools" in OpenJDK are standalone programs.)
>>
>> For example,
>> "ListFormat formats and parses lists of strings."
>
> I agree, Roger.
On Tue, 5 Sep 2023 19:50:23 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/text/ListFormat.java line 48:
>>
>>> 46: * List Patterns.
>>> 47: *
>>> 48: * Three types of concatenation are provided: {@link Type#STANDARD
>>> STANDARD},
>>
>> A "Type" and "Style" together make up a
On Tue, 5 Sep 2023 20:04:57 GMT, Roger Riggs wrote:
>> Thanks. Will modify the wording in the next revision. I think we should
>> stick to the wording `format`/`parse` here.
>
> I'd stick to the general first sentence structure used by DateFormat, Format,
> and MessageFormat.
> ("tools" in Open
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and ForkJ
On Tue, 5 Sep 2023 19:50:20 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/text/ListFormat.java line 46:
>>
>>> 44: * defined in Unicode Consortium's LDML specification for
>>> 45: * >> href="https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns";>
>>> 46: * List Pat
On Sun, 3 Sep 2023 05:05:49 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removing unnecessary commas
>
> src/java.base/share/classes/java/text/ListFormat.java line 46:
>
>> 44: * defined in Unicode
On Mon, 4 Sep 2023 21:17:06 GMT, Martin Doerr wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
>> 8. Thi
On Fri, 28 Jul 2023 18:41:48 GMT, Joe Wang wrote:
> Add a JDK Impl specific property 'jdk.xml.dtd.support' for applications to
> specify how DTDs are handled. This property is uniformly supported across the
> JDK XML libraries. It complements, rather than replaces, the existing
> properties th
On Fri, 1 Sep 2023 22:26:00 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720)
>> which refines the spec of `equals()` and `hashCode()` in `java.text.Format`
>> related classes.
>>
>> The current spec for most of these methods is either "_Ove
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315558)
> which is a conformance change to document some exceptions in the
> specification of java.text.StringCharacterIterator.
Justin Lu has updated the pull request incrementally with one additional commit
since the last
On Sat, 2 Sep 2023 09:20:22 GMT, Alan Bateman wrote:
> I think you've got this to a good place and brings uniformity to configuring
> how all the processors deal with DTDs. The proposal in the CSR is approved
> now so hopefully you'll get Reviewer cycles to help move forward on this.
Thanks Al
On Tue, 5 Sep 2023 15:46:17 GMT, 温绍锦 wrote:
>> BigDecimal is a commonly used class in business development, It is often
>> necessary to perform toString or toPlainString operations on BigDecimal.
>>
>> The current version uses StringBuilder resulting in multiple memory
>> allocations, I made a
On Mon, 4 Sep 2023 21:17:06 GMT, Martin Doerr wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
>> 8. Thi
On Fri, 1 Sep 2023 23:12:28 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315558)
> which is a conformance change to document some exceptions in the
> specification of java.text.StringCharacterIterator.
src/java.base/share/classes/java/text/String
On Mon, 4 Sep 2023 11:01:23 GMT, Leo Korinth wrote:
> What do you prefer? Do you have a better alternative? Do someone still think
> the current code is good? I think what we have today is inferior to all these
> improvements, and I would like to make it harder to develop bad test ca
The curre
On Mon, 4 Sep 2023 14:30:06 GMT, Maurizio Cimadamore
wrote:
>> @TheRealMDoerr We've been discussing the shifts in order to wrap our heads
>> around it, and we've ended up with this diagram in order to try and
>> visualize what happens:
>>
>> Let's say we have a struct with 3 ints:
>>
>>
>>
On Tue, 5 Sep 2023 16:44:24 GMT, Brent Christian wrote:
>> Mandy Chung has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 29 commits:
>>
>> - Merge
>> - Remove the new getInstance method taking varargs
>> - update mode to be int r
On Thu, 31 Aug 2023 17:09:40 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
On Mon, 4 Sep 2023 07:28:03 GMT, Aleksey Shipilev wrote:
> Similar to other issues in the same area. I have no SPARC machine to test the
> build on, but this matches other fixes for other architectures
> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
> after t
On Tue, 29 Aug 2023 20:51:56 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
On Wed, 30 Aug 2023 20:34:01 GMT, Vladimir Petko wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java
>
> Vladimir Petko has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the me
On Mon, 4 Sep 2023 08:24:19 GMT, Alan Bateman wrote:
>> In the virtual thread implementation, thread identity switches to the
>> carrier before freezing and switches back to the virtual thread after
>> thawing. This was a forced move due to issues getting JVMTI to work with
>> virtual threads.
The changes to this test were developed on a native Windows 11 machine. I have
never seen this problem.
A web search suggests that this is a Windows error message possibly due to
drive error.
On Sep 4, 2023, at 5:16 AM, Andrey Turbanov
mailto:aturba...@openjdk.org>> wrote:
It seems after refa
> /test/jdk/tools/lib/tests/JImageValidator.java, tests in
> /test/jdk/tools/jlink and /test/jdk/tools/jimage use on
> com.sun.tools.classfile and should be converted to Classfile API.
Qing Xiao has updated the pull request incrementally with one additional commit
since the last revision:
mi
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
> discussions, continue to make improvements.
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.util.UUIDBench.toString"
>
>
> ##
> BigDecimal is a commonly used class in business development, It is often
> necessary to perform toString or toPlainString operations on BigDecimal.
>
> The current version uses StringBuilder resulting in multiple memory
> allocations, I made a modification to improve performance.
>
> Because
On Thu, 31 Aug 2023 14:18:00 GMT, Chen Liang wrote:
>> Classfile API suppose to throw IllegalArgumentException in situations where
>> bytecode offset is out of allowed range. Such situation includes invalid
>> offset parsed from a TypeAnnotation as well as from other CodeAttribute
>> attribute
On Thu, 10 Aug 2023 15:30:19 GMT, Swati Sharma wrote:
> In addition to the issue
> [JDK-8311178](https://bugs.openjdk.org/browse/JDK-8311178), logically fixing
> the scope from benchmark to thread for below benchmark files having shared
> state, also which fixes few of the benchmarks scalabili
> Classfile API `ConstantPool::entryCount` and `ConstantPool::entryByIndex`
> methods are confusing and unsafe to use without knowledge of constant pool
> specification.
> This patch renames `ConstantPool::entryCount` to `ConstantPool::size` and
> adds checks to `ConstantPool::entryByIndex` for
On Tue, 5 Sep 2023 11:56:19 GMT, Per Minborg wrote:
>> This PR proposes to read the system environment variable "SystemRoot" using
>> a privileged operation so it will work in the event a default
>> SecurityManager is in place.
>>
>> As the `SecurityManager` is deprecated for removal, no suppo
Classfile API `ConstantPool::entryCount` and `ConstantPool::entryByIndex`
methods are confusing and unsafe to use without knowledge of constant pool
specification.
This patch renames `ConstantPool::entryCount` to `ConstantPool::size` and adds
checks to `ConstantPool::entryByIndex` for invalid or
On Tue, 5 Sep 2023 13:52:09 GMT, Roger Riggs wrote:
> A bit late due to a US holiday. Looks good.
Thanks 🙇
-
PR Comment: https://git.openjdk.org/jdk/pull/15222#issuecomment-1706695064
On Fri, 1 Sep 2023 08:32:20 GMT, Christoph Langer wrote:
>> On Windows, the test java/lang/ProcessHandle/InfoTest.java can fail when run
>> as user that is member of the Administrators group. In that case new files
>> are not owned by the user but instead by BUILTIN\ADMINISTRATORS. This breaks
On Tue, 5 Sep 2023 09:36:59 GMT, ExE Boss wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add a SecurityManager for TestLinker
>
> test/jdk/java/foreign/TestLinker.java line 30:
>
>> 28: * @modules java.base/jdk.i
> This PR proposes to read the system environment variable "SystemRoot" using a
> privileged operation so it will work in the event a default SecurityManager
> is in place.
>
> As the `SecurityManager` is deprecated for removal, no support methods were
> added for reading environmental variable
This patch performs null checks in to refuse null labels in
TypeAnnotation.TargetInfo implementations.
Please review.
Thanks,
Adam
-
Commit messages:
- 8315541: Classfile API TypeAnnotation.TargetInfo factory methods accept null
labels
Changes: https://git.openjdk.org/jdk/pull/
> BigDecimal is a commonly used class in business development, It is often
> necessary to perform toString or toPlainString operations on BigDecimal.
>
> The current version uses StringBuilder resulting in multiple memory
> allocations, I made a modification to improve performance.
>
> Because
On Tue, 5 Sep 2023 09:38:17 GMT, Per Minborg wrote:
>> This PR proposes to read the system environment variable "SystemRoot" using
>> a privileged operation so it will work in the event a default
>> SecurityManager is in place.
>>
>> As the `SecurityManager` is deprecated for removal, no suppo
> This PR proposes to read the system environment variable "SystemRoot" using a
> privileged operation so it will work in the event a default SecurityManager
> is in place.
>
> As the `SecurityManager` is deprecated for removal, no support methods were
> added for reading environmental variable
On Mon, 4 Sep 2023 14:30:06 GMT, Maurizio Cimadamore
wrote:
>> @TheRealMDoerr We've been discussing the shifts in order to wrap our heads
>> around it, and we've ended up with this diagram in order to try and
>> visualize what happens:
>>
>> Let's say we have a struct with 3 ints:
>>
>>
>>
This PR proposes to read the system environment variable "SystemRoot" using a
privileged operation so it will work in the event a default SecurityManager is
in place.
As the `SecurityManager` is deprecated for removal, no support methods were
added for reading environmental variables.
This PR improved Classfile API attributes handling safety by introduction of
attribute stability indicator
and by extension of UnknownAttributesOption to more general
AttributesProcessingOption.
-
Commit messages:
- fixed remaining listFromTrustedArrayNullsAllowed calls to
listFro
On Fri, 21 Jul 2023 09:37:10 GMT, Adam Sotona wrote:
> This pull request updates Classfile API snippets and examples and adds
> missing javadoc.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: 744b3970
Author:Adam Sotona
URL:
https://gi
On Fri, 1 Sep 2023 07:22:12 GMT, Matthias Baesken wrote:
> on some RHEL Linux 8.X machines , we run into errors in test
> tools/jpackage/share/RuntimePackageTest.java#id0 , error can be seen below.
> It looks like these errors occur when running the jtreg tests with higher
> concurrency, I did
On Mon, 4 Sep 2023 21:17:06 GMT, Martin Doerr wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
>> 8. Thi
On Thu, 10 Aug 2023 09:54:43 GMT, Christoph Langer wrote:
> On Windows, the test java/lang/ProcessHandle/InfoTest.java can fail when run
> as user that is member of the Administrators group. In that case new files
> are not owned by the user but instead by BUILTIN\ADMINISTRATORS. This breaks
>
On Fri, 1 Sep 2023 07:22:12 GMT, Matthias Baesken wrote:
> on some RHEL Linux 8.X machines , we run into errors in test
> tools/jpackage/share/RuntimePackageTest.java#id0 , error can be seen below.
> It looks like these errors occur when running the jtreg tests with higher
> concurrency, I did
On Fri, 1 Sep 2023 12:13:05 GMT, Adam Sotona wrote:
>> This pull request updates Classfile API snippets and examples and adds
>> missing javadoc.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional
> commit since the last r
72 matches
Mail list logo
