On Fri, 14 Jul 2023 03:45:47 GMT, Anthony Scarpino
wrote:
>> Hi,
>>
>> I need a code review for moving the contents of the jdk.crypto.ec module
>> into java.base. This moves the SunEC JCE Provider (Elliptic Curve) into
>> java.base. EC has always been separate from the base module/pkg becau
On Thu, 13 Jul 2023 15:58:24 GMT, Alan Bateman wrote:
> Clean backport of https://git.openjdk.org/jdk/pull/14833
This pull request has now been integrated.
Changeset: 281aee96
Author:Alan Bateman
URL:
https://git.openjdk.org/jdk21/commit/281aee968aae70005f64dd97fa288c7ba0490e49
Stat
> Hi,
>
> I need a code review for moving the contents of the jdk.crypto.ec module into
> java.base. This moves the SunEC JCE Provider (Elliptic Curve) into
> java.base. EC has always been separate from the base module/pkg because of
> its dependence on a native library. That library was rem
On Mon, 15 May 2023 15:51:02 GMT, Chris Hennick wrote:
>> This PR improves both the worst-case performance of `nextExponential` and
>> `nextGaussian` and the distribution of output at the tails. It fixes the
>> following imperfections:
>>
>> * Repeatedly adding DoubleZigguratTables.exponential
> Going over some old issues and found this RFE, posting without any tests or a
> CSR first to get some feedback on the overall API.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the
On Thu, 13 Jul 2023 15:58:24 GMT, Alan Bateman wrote:
> Clean backport of https://git.openjdk.org/jdk/pull/14833
P3 bug fix, approved for backport.
-
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk21/pull/123#pullrequestreview-1529421300
On Mon, 10 Jul 2023 20:24:30 GMT, Joe Darcy wrote:
>> Going over some old issues and found this RFE, posting without any tests or
>> a CSR first to get some feedback on the overall API.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The increment
Please review this PR which refactors more java.util.Locale tests to JUnit with
some minor cleanup as well.
Although some of the files could benefit from being renamed bugNNN to
something more descriptive, this makes reviewing harder, and will be handled
separately.
-
Commit m
> `ByteArray` and `ByteArrayLittleEndian` are very useful tool classes that can
> be used in many places to performance tuning.
>
> Currently they are implemented by `VarHandle`, so using them may have some
> impact on startup time.
>
> This PR reimplements them using `Unsafe`, which reduces th
On Fri, 30 Jun 2023 19:38:19 GMT, Doug Lea wrote:
>> This now uses Thread.isVirtual to distinguish spin vs immediate block cases,
>> enabling re-introduction of spin control from the previous version, removing
>> anomalies like this one.
>
> Doug Lea has updated the pull request incrementally w
On Thu, 13 Jul 2023 19:21:01 GMT, Doug Lea wrote:
>> This now uses Thread.isVirtual to distinguish spin vs immediate block cases,
>> enabling re-introduction of spin control from the previous version, removing
>> anomalies like this one.
>
> Doug Lea has updated the pull request with a new targ
On Thu, 13 Jul 2023 18:28:38 GMT, Justin Lu wrote:
> Please review this PR which backports
> https://github.com/openjdk/jdk/commit/6cb9ec32a68634f0b6f7461c9dc7ef0c0e59861d
>
> Thank you
This pull request has now been integrated.
Changeset: d370b96f
Author:Justin Lu
URL:
https://gi
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list
> of deprecated three-letter IDs in java.util.TimeZone
>
> Although it is made apparent in TimeZone that certain 3-letter IDs are
> deprecated, it does not actually list them in
On Thu, 13 Jul 2023 20:21:57 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/util/TimeZone.java line 135:
>>
>>> 133: * recognize one of them. The full list of the deprecated IDs and
>>> their mappings
>>> 134: * can be viewed at {@link java.time.ZoneId#SHORT_IDS}. It should be
>>>
On Thu, 13 Jul 2023 18:28:38 GMT, Justin Lu wrote:
> Please review this PR which backports
> https://github.com/openjdk/jdk/commit/6cb9ec32a68634f0b6f7461c9dc7ef0c0e59861d
>
> Thank you
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/125#pul
On Thu, 13 Jul 2023 19:38:35 GMT, Lance Andersen wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review: update wording to include mappings
>
> src/java.base/share/classes/java/util/TimeZone.java line 135:
>
>> 133:
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list
> of deprecated three-letter IDs in java.util.TimeZone
>
> Although it is made apparent in TimeZone that certain 3-letter IDs are
> deprecated, it does not actually list them in
On Thu, 13 Jul 2023 18:41:47 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list
>> of deprecated three-letter IDs in java.util.TimeZone
>>
>> Although it is made apparent in TimeZone that certain 3-lette
On Thu, 13 Jul 2023 18:28:38 GMT, Justin Lu wrote:
> Please review this PR which backports
> https://github.com/openjdk/jdk/commit/6cb9ec32a68634f0b6f7461c9dc7ef0c0e59861d
>
> Thank you
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/125#p
On Tue, 11 Jul 2023 15:47:35 GMT, Volker Simonis wrote:
>> As the included jtreg test demonstrates, `StackWalker.getCallerClass()` can
>> throw an `UnsupportedOperationException` if called reflectively. Currently
>> this only happens if we invoke `StackWalker.getCallerClass()` recursively
>> r
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases,
> enabling re-introduction of spin control from the previous version, removing
> anomalies like this one.
Doug Lea has updated the pull request with a new target base due to a merge or
a rebase. The incremental webre
On Thu, 13 Jul 2023 18:28:38 GMT, Justin Lu wrote:
> Please review this PR which backports
> https://github.com/openjdk/jdk/commit/6cb9ec32a68634f0b6f7461c9dc7ef0c0e59861d
>
> Thank you
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/125#pu
On Thu, 13 Jul 2023 18:41:47 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list
>> of deprecated three-letter IDs in java.util.TimeZone
>>
>> Although it is made apparent in TimeZone that certain 3-lette
On Fri, 4 Nov 2022 14:35:00 GMT, Thomas Stuefe wrote:
> This patch adds NMT tracking to the zlib.
>
> *Please note: we currently discuss whether NMT can be expanded across the JDK
> in this ML discussion [1]. This PR depends on the outcome of that discussion
> and won't proceed unless greenlig
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list
> of deprecated three-letter IDs in java.util.TimeZone
>
> Although it is made apparent in TimeZone that certain 3-letter IDs are
> deprecated, it does not actually list them in
On Thu, 13 Jul 2023 18:29:05 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review: update wording to include mappings
>
> src/java.base/share/classes/java/util/TimeZone.java line 133:
>
>> 131: * f
Please review this PR which backports
https://github.com/openjdk/jdk/commit/6cb9ec32a68634f0b6f7461c9dc7ef0c0e59861d
Thank you
-
Commit messages:
- 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented
functionality
Changes: https://git.openjdk.org/jdk21/pull/125/fil
On Thu, 13 Jul 2023 06:34:09 GMT, Justin Lu wrote:
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list
> of deprecated three-letter IDs in java.util.TimeZone
>
> Although it is made apparent in TimeZone that certain 3-letter IDs
On Tue, 11 Jul 2023 16:35:51 GMT, Pavel Rappo wrote:
> This PR adds an internal method to calculate hash code from the provided
> integer array, offset and length into that array, and the initial hash code
> value.
>
> Current options for calculating a hash code for int[] are inflexible. It's
Clean backport of https://git.openjdk.org/jdk/pull/14833
-
Commit messages:
- Backport 92a04e201e68aa4d682053cef4b36180ec5620f5
Changes: https://git.openjdk.org/jdk21/pull/123/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=123&range=00
Issue: https://bugs.openjdk.org/br
On Thu, 13 Jul 2023 05:45:37 GMT, Stuart Marks wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [743e8b8e](https://github.com/openjdk/jdk/commit/743e8b8e0a9fe032a0dd652a4fef1f761af66595)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bei
On Thu, 13 Jul 2023 11:46:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
> caching scheme for Carrier objects. The technique used is generally useful
> for a variety of caching schemes and is being moved to be shared in other
> parts of the jdk. The MethodType interning case is one example.
On Thu, 13 Jul 2023 10:50:30 GMT, Pavel Rappo wrote:
> Please review this PR to use modern APIs and language features to simplify
> equals for BitSet.
>
> I couldn't see how to refactor hashCode using Arrays utility methods in a way
> that preserves its specification. So, aside from refactori
On Thu, 13 Jul 2023 09:27:03 GMT, Pavel Rappo wrote:
> > @pavelrappo Actually I look at the implementation of
> > `ArraySupport.vectorizedHashCode` and it does branching and only uses
> > vector instructions if the length is sufficiently large. Please do
> > benchmarking if you are uncertain w
On Thu, 13 Jul 2023 11:46:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Fri, 9 Jun 2023 09:13:08 GMT, Viktor Klang wrote:
> The test used a too-small heap for generic testing, and coupled with looking
> at `freeMemory()` it led to a less-than-ideal determinism of execution of the
> test.
This pull request has now been integrated.
Changeset: 8c9d091f
Author:
On Thu, 13 Jul 2023 05:45:37 GMT, Stuart Marks wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [743e8b8e](https://github.com/openjdk/jdk/commit/743e8b8e0a9fe032a0dd652a4fef1f761af66595)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bei
On Thu, 13 Jul 2023 08:31:37 GMT, Aleksey Shipilev wrote:
> Clean backport. Fixes the regression introduced in JDK 21.
Test failures in GHA are unrelated.
-
PR Comment: https://git.openjdk.org/jdk21/pull/120#issuecomment-1634114884
On Thu, 13 Jul 2023 08:31:37 GMT, Aleksey Shipilev wrote:
> Clean backport. Fixes the regression introduced in JDK 21.
This pull request has now been integrated.
Changeset: 99d87e90
Author:Aleksey Shipilev
URL:
https://git.openjdk.org/jdk21/commit/99d87e90972d3ab587e49d493de6a8b9e0b
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>
> The `jlink` command allows a `--endian` option to specify the byte order in
> the generated image. Before this change, when such a image was being
> launche
On Wed, 12 Jul 2023 19:24:22 GMT, Mandy Chung wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 45 commits:
>>
>> - move copyright before imports in the new test
>> - add a new test for jlink --endian usages
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>
> The `jlink` command allows a `--endian` option to specify the byte order in
> the generated image. Before this change, when such a image was being
> launche
On Wed, 12 Jul 2023 14:38:37 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 45 commits:
>>
>> - move copyright before imports in the new test
>> - add a new test for jlink --endian usages
On Wed, 12 Jul 2023 10:58:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
Please review this PR to use modern APIs and language features to simplify
equals for BitSet.
I couldn't see how to refactor hashCode using Arrays utility methods in a way
that preserves its specification. So, aside from refactoring its doc comment
and annotating it with `@Overrides`, I left i
On Thu, 13 Jul 2023 08:44:02 GMT, Pavel Rappo wrote:
>>> For an arbitrary int[], unconditional vectorization might be unwarranted or
>>> puzzling.
>>
>> Could you clarify this statement? Thanks a lot.
>
>> > For an arbitrary int[], unconditional vectorization might be unwarranted
>> > or puzzl
On Thu, 13 Jul 2023 08:44:02 GMT, Pavel Rappo wrote:
>>> For an arbitrary int[], unconditional vectorization might be unwarranted or
>>> puzzling.
>>
>> Could you clarify this statement? Thanks a lot.
>
>> > For an arbitrary int[], unconditional vectorization might be unwarranted
>> > or puzzl
On Thu, 13 Jul 2023 08:31:37 GMT, Aleksey Shipilev wrote:
> Clean backport. Fixes the regression introduced in JDK 21.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/120#pullrequestreview-1527931960
On Thu, 13 Jul 2023 07:15:57 GMT, Quan Anh Mai wrote:
> > For an arbitrary int[], unconditional vectorization might be unwarranted or
> > puzzling.
>
> Could you clarify this statement? Thanks a lot.
My mental model is that Arrays.hashCode is to ArraysSupport.vectorizedHashCode
as Arrays.mism
Clean backport. Fixes the regression introduced in JDK 21.
-
Commit messages:
- Backport 401c3dea5d8823bc9c0f40506ddad46e983ebf68
Changes: https://git.openjdk.org/jdk21/pull/120/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=120&range=00
Issue: https://bugs.openjdk.org/
On Tue, 11 Jul 2023 17:03:26 GMT, Alan Bateman wrote:
> StructuredTaskScope.shutdown can sometimes not interrupt the thread for a
> newly forked subtask, leading to join blocking until subtask completes. The
> "hang" can be duplicated with a stress test that shuts down the scope while a
> long
> The prerequisite is to install the rpmbuild command, when multiple users
> switch to write /var/tmp/*.files will have the permission forbidden.
yaqsun has updated the pull request incrementally with one additional commit
since the last revision:
8311631: When multiple users run tools/jpacka
On Tue, 11 Jul 2023 16:35:51 GMT, Pavel Rappo wrote:
> For an arbitrary int[], unconditional vectorization might be unwarranted or
> puzzling.
Could you clarify this statement? Thanks a lot.
-
PR Comment: https://git.openjdk.org/jdk/pull/14831#issuecomment-1633696435
54 matches
Mail list logo
