On Wed, 12 Jul 2023 14:38:37 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 45 commits: >> >> - move copyright before imports in the new test >> - add a new test for jlink --endian usages >> - merge latest from master branch >> - use newly introduced Architecture.byteOrder() API >> - merge latest from master branch >> - update jdk.tools.jlink.internal.Platform class to be aware of non-current >> platform's endianness >> - remove no longer needed constructor >> - merge latest from master branch >> - foo >> - merge latest from master branch >> - ... and 35 more: https://git.openjdk.org/jdk/compare/753bd563...962d542d > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 846: > >> 844: String targetPlatformVal = >> readJavaBaseTargetPlatform(cf); >> 845: try { >> 846: return Platform.parsePlatform(targetPlatformVal); > > You may want to modify `Platform.parsePlatform(s)` to use > `Architecture.lookupByName(s)` instead of doing the alias mapping itself. > Platform.java:53-56. That's a good point. I've updated the PR with your suggested implementation. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/11943#discussion_r1262424756
