On Thu, 13 Jul 2023 18:41:47 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR and associated >> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list >> of deprecated three-letter IDs in java.util.TimeZone >> >> Although it is made apparent in TimeZone that certain 3-letter IDs are >> deprecated, it does not actually list them in the specification. In addition >> to linking the full list, it is clarified that not _all_ 3-letter IDs are >> deprecated, as there are quite a few that come from the tzdb. >> >> This change links to the full list found in ZoneId. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Review: update wording to include mappings src/java.base/share/classes/java/util/TimeZone.java line 135: > 133: * recognize one of them. The full list of the deprecated IDs and their > mappings > 134: * can be viewed at {@link java.time.ZoneId#SHORT_IDS}. It should be > noted that > 135: * not all three-letter time zone IDs are deprecated, as some come from > the IANA This is a bit confusing at least to me as I did not see which SHORT_IDS were not deprecated via the link above, but perhaps I missed it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14861#discussion_r1262983679