Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v3]

2023-07-08 Thread Jorn Vernee
On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with one additional commit > since the last revision: > > Address suggestions from Jorn Vernee The changes look

Re: RFR: 8066869: Add Closeable::closeUnchecked that is the equivalent of close but throws UncheckedIOException [v2]

2023-07-08 Thread Glavo
On Fri, 7 Jul 2023 15:56:13 GMT, Brian Burkhalter wrote: >> Add a default method `java.io.Closeable::closeUnchecked` which is equivalent >> to `Closeable::close` except that it instead throws >> `java.io.UncheckedIOException`. > > Brian Burkhalter has updated the pull request incrementally with

Re: RFR: 8311178: JMH tests don't scale well when sharing output buffers

2023-07-08 Thread Swati Sharma
On Sat, 1 Jul 2023 07:53:17 GMT, Swati Sharma wrote: > The below benchmark files have scaling issues due to cache contention and > leads to poor scaling when run on multiple threads. The patch sets the scope > from benchmark level to thread level to fix the issue: > - org/openjdk/bench/java/io/

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v2]

2023-07-08 Thread sid8606
On Fri, 7 Jul 2023 12:02:33 GMT, Jorn Vernee wrote: >> sid8606 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address Amit's review comments > > src/hotspot/cpu/s390/downcallLinker_s390.cpp line 207: > >> 205: __ z_lg(callerSP, _z_ab

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v2]

2023-07-08 Thread sid8606
On Fri, 7 Jul 2023 12:06:39 GMT, Jorn Vernee wrote: >> sid8606 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address Amit's review comments > > src/hotspot/cpu/s390/foreignGlobals_s390.cpp line 186: > >> 184: case StorageType::FRA

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v2]

2023-07-08 Thread sid8606
On Fri, 7 Jul 2023 11:56:28 GMT, Jorn Vernee wrote: >> sid8606 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address Amit's review comments > > src/hotspot/cpu/s390/downcallLinker_s390.cpp line 162: > >> 160: allocated_frame_size +=

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v2]

2023-07-08 Thread sid8606
On Fri, 7 Jul 2023 10:33:10 GMT, Jorn Vernee wrote: >> sid8606 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address Amit's review comments > > test/jdk/java/foreign/TestIllegalLink.java line 57: > >> 55: >> 56: private static fi

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v3]

2023-07-08 Thread sid8606
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). sid8606 has updated the pull request incrementally with one additional commit since the last revision: Address suggestions from Jorn Vernee - Changes: - all: https://git.openjdk.org/jdk/pull/14801/files

RFR: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files

2023-07-08 Thread yaqsun
Low risk, only test changes. The prerequisite is to install the rpmbuild command, when multiple users switch to write /var/tmp/*.files will have the permission forbidden. - Commit messages: - 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied

Re: RFR: 8066869: Add Closeable::closeUnchecked that is the equivalent of close but throws UncheckedIOException

2023-07-08 Thread Remi Forax
oops, sorry, my bad, sending an email when you are deprived of sleep does not lead to a good outcome. Remi On July 7, 2023 4:40:53 PM UTC, Brian Burkhalter wrote: >On Fri, 7 Jul 2023 16:23:37 GMT, Remi Forax wrote: > >> I'm not a big fan of hiding exceptions, why not wrapping the IOException

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v6]

2023-07-08 Thread 温绍锦
On Fri, 7 Jul 2023 15:13:02 GMT, Roger Riggs wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> code style > > src/java.base/share/classes/java/util/HexDigits.java line 44: > >> 42: * 0 -> '00' -> ('0' << 8) | '0'