On Fri, 7 Jul 2023 15:13:02 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> code style
>
> src/java.base/share/classes/java/util/HexDigits.java line 44:
>
>> 42: * 0 -> '00' -> ('0' << 8) | '0' -> 0x3030
>> 43: * 1 -> '01' -> ('0' << 8) | '1' -> 0x3130
>> 44: * 2 -> '02' -> ('0' << 8) | '2' -> 0x3230
>
> The description of the array content does not need to be exhaustive; just
> sufficient to understand how it is indexed and the meaning of the values.
The comment is already there, I think the value on the right is easier to
understand in hexadecimal
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14745#discussion_r1257114731
