On Mon, 16 Jan 2023 16:50:06 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an
>> attempt to remove all trailing whitespace from properties files, and enable
>> a jcheck verification that they did not come back, similar to other sourc
On Sat, 24 Jun 2023 05:24:46 GMT, Jaikiran Pai wrote:
> Hello Glavo, I was going to recommend adding a test method to existing jtreg
> tests to test these new methods. But it looks like there's no jtreg test for
> this `ByteArrayLittleEndian` class. Would you mind creating a new test class
> t
On Sat, 24 Jun 2023 05:24:24 GMT, Alan Bateman wrote:
>> Using `ByteArrayLittleEndian` is simpler and faster.
>>
>> `make test TEST="micro:java.util.zip.ZipFileOpen"`:
>>
>>
>> Benchmark (size) Mode Cnt Score Error
>> Units
>> - ZipFileOpen.openCloseZipFile
On Fri, 23 Jun 2023 20:00:12 GMT, Glavo wrote:
> Using `ByteArrayLittleEndian` is simpler and faster.
>
> `make test TEST="micro:java.util.zip.ZipFileOpen"`:
>
>
> Benchmark (size) Mode Cnt Score Error Units
> - ZipFileOpen.openCloseZipFile 512 avgt 15
On Fri, 23 Jun 2023 16:30:15 GMT, Brian Burkhalter wrote:
> Add `package-info.java` for package `jdk.nio.mapmode`.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14628#pullrequestreview-1496355363
On Fri, 23 Jun 2023 20:00:12 GMT, Glavo wrote:
> Using `ByteArrayLittleEndian` is simpler and faster.
>
> `make test TEST="micro:java.util.zip.ZipFileOpen"`:
>
>
> Benchmark (size) Mode Cnt Score Error Units
> - ZipFileOpen.openCloseZipFile 512 avgt 15
On Fri, 23 Jun 2023 20:00:12 GMT, Glavo wrote:
> Using `ByteArrayLittleEndian` is simpler and faster.
>
> `make test TEST="micro:java.util.zip.ZipFileOpen"`:
>
>
> Benchmark (size) Mode Cnt Score Error Units
> - ZipFileOpen.openCloseZipFile 512 avgt 15
On Fri, 23 Jun 2023 23:23:07 GMT, Brian Burkhalter wrote:
>> Clarify the behavior of `java.lang.Readable` when the specified
>> `java.nio.CharBuffer` parameter is empty but read-only, and when it is full.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional comm
On Fri, 23 Jun 2023 20:00:12 GMT, Glavo wrote:
> Using `ByteArrayLittleEndian` is simpler and faster.
>
> `make test TEST="micro:java.util.zip.ZipFileOpen"`:
>
>
> Benchmark (size) Mode Cnt Score Error Units
> - ZipFileOpen.openCloseZipFile 512 avgt 15
Using `ByteArrayLittleEndian` is simpler and faster.
`make test TEST="micro:java.util.zip.ZipFileOpen"`:
Benchmark (size) Mode Cnt Score Error Units
- ZipFileOpen.openCloseZipFile 512 avgt 15 39052.832 ± 107.496 ns/op
+ ZipFileOpen.openCloseZipFile
On Fri, 23 Jun 2023 17:09:12 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
> On Windows, the basic Java Integer types are defined as long and __int64
> respectively. In particular, the former is rather problematic since it breaks
> compilation as the Visual C++ becomes stricter and more compliant with every
> release, which means the way Windows code treats long as a t
On Fri, 23 Jun 2023 23:58:05 GMT, Jorn Vernee wrote:
>> Improve the specification of `Linker.Option.firstVariadicArg`, by specifying
>> more clearly which index values are valid.
>
> Jorn Vernee has updated the pull request incrementally with three additional
> commits since the last revision:
https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/lang/constant/MethodTypeDesc.html
These 3 typos are discovered while browsing the online documentation. It
probably doesn't need a CSR for it doesn't change the specification at all.
-
Commit messages:
- 8310838: Cor
On Fri, 23 Jun 2023 23:23:07 GMT, Brian Burkhalter wrote:
>> Clarify the behavior of `java.lang.Readable` when the specified
>> `java.nio.CharBuffer` parameter is empty but read-only, and when it is full.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional comm
> Improve the specification of `Linker.Option.firstVariadicArg`, by specifying
> more clearly which index values are valid.
Jorn Vernee has updated the pull request incrementally with three additional
commits since the last revision:
- review comments
- Update src/java.base/share/classes/java
On Fri, 23 Jun 2023 19:30:31 GMT, ExE Boss wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> format code
>
> src/java.base/share/classes/java/lang/Long.java line 493:
>
>> 491: | H256[((int) lsb) & 0x
> Clarify the behavior of `java.lang.Readable` when the specified
> `java.nio.CharBuffer` parameter is empty but read-only, and when it is full.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8222329: Disambiguate length/remaini
On Thu, 22 Jun 2023 00:19:03 GMT, Joe Darcy wrote:
> Small cleanup, minor differences in the wording of portions of
> toString(Object, String), nonNull(Object), requireNonNullElse, and
> requireNonNullElseGet.
This pull request has now been integrated.
Changeset: 0db63ec7
Author:Joe Darcy
> Small cleanup, minor differences in the wording of portions of
> toString(Object, String), nonNull(Object), requireNonNullElse, and
> requireNonNullElseGet.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Make sure there is not an un
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last r
On Fri, 23 Jun 2023 21:59:21 GMT, Pavel Rappo wrote:
> NPE was seemingly caught to cover for other being null.
Unlike that of other file in this PR.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/12328#discussion_r1240446275
> Small cleanup, minor differences in the wording of portions of
> toString(Object, String), nonNull(Object), requireNonNullElse, and
> requireNonNullElseGet.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated
On Thu, 22 Jun 2023 01:08:30 GMT, Justin Lu wrote:
> Please review this PR as apart of
> [JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors
> some tests in Locale to use JUnit. Other cleanup and small changes are
> included as well. More refactoring in Locale tests will
On Fri, 23 Jun 2023 20:56:14 GMT, Brian Burkhalter wrote:
>> Clarify the behavior of `java.lang.Readable` when the specified
>> `java.nio.CharBuffer` parameter is empty but read-only, and when it is full.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional comm
On Fri, 23 Jun 2023 20:46:29 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/Reader.java line 194:
>>
>>> 192: * rewinding of the buffer is performed. If the specified
>>> character
>>> 193: * buffer has no space {@linkplain java.nio.Buffer#hasRemaining
>>> 194:
> Clarify the behavior of `java.lang.Readable` when the specified
> `java.nio.CharBuffer` parameter is empty but read-only, and when it is full.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8222329: "or or" -> "or"
--
On Fri, 23 Jun 2023 20:36:59 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8222329: Remove redundancy of length vs. remaining in CharBuffer::read doc
>
> src/java.base/share/classes/java/io/R
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last r
On Wed, 21 Jun 2023 15:03:12 GMT, Sergey Tsypanov wrote:
>> Just a tiny clean-up to remove racy read within synchronized method
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update src/java.base/share/classes/java/io/P
On Fri, 23 Jun 2023 17:19:10 GMT, Brian Burkhalter wrote:
>> Clarify the behavior of `java.lang.Readable` when the specified
>> `java.nio.CharBuffer` parameter is empty but read-only, and when it is full.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional comm
On Thu, 22 Jun 2023 22:07:19 GMT, Stuart Marks wrote:
>> Can I get a preliminary review of the wording for Deque.reversed()? If the
>> text is good, I'll make corresponding changes to the implSpecs of the other
>> reversed() default methods, namely those in List, SortedMap, and SortedSet
>> an
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last r
On Fri, 23 Jun 2023 17:05:19 GMT, Naoto Sato wrote:
>> I'll run our CI, and if all good, I'll approve this PR. If nothing else,
>> this change seems reasonable and correct.
>
> Thanks Pavel for jumping in. I too think this change looks good.
Yep; all good.
-
PR Review Comment: htt
On Fri, 23 Jun 2023 19:30:56 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java
> on generic-x64.
This pull request has now been integrated.
Changeset: af3a56e5
Author:Daniel D. Daugherty
URL:
https://git.openjdk.org/jdk21
On Fri, 23 Jun 2023 19:44:50 GMT, Iris Clark wrote:
>> A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java
>> on generic-x64.
>
> Marked as reviewed by iris (Reviewer).
@irisclark and @lmesnik - Thanks for the fast reviews!
-
PR Comment: https://git.openjdk
On Fri, 23 Jun 2023 19:45:19 GMT, Leonid Mesnik wrote:
>> A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java
>> on generic-x64.
>
> test/jdk/ProblemList-Xcomp.txt line 31:
>
>> 29:
>> 30: java/lang/invoke/MethodHandles/CatchExceptionTest.java 8146623
>> generic-all
>>
On Fri, 23 Jun 2023 19:30:56 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java
> on generic-x64.
Marked as reviewed by lmesnik (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/60#pullrequestreview-1495844009
On Fri, 23 Jun 2023 19:30:56 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java
> on generic-x64.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/60#pullrequestreview-1495822256
On Fri, 23 Jun 2023 19:30:56 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java
> on generic-x64.
Changes requested by lmesnik (Reviewer).
test/jdk/ProblemList-Xcomp.txt line 31:
> 29:
> 30: java/lang/invoke/MethodHandles/CatchExcep
On Wed, 21 Jun 2023 00:00:54 GMT, Joe Darcy wrote:
> Correct misstatement that the Class object for a primitive type can only be
> be access via fields like java.lang.Integer.TYPE.
This pull request has now been integrated.
Changeset: 0314292c
Author:Joe Darcy
URL:
https://git.open
> Correct misstatement that the Class object for a primitive type can only be
> be access via fields like java.lang.Integer.TYPE.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix another typo and reflow paragraphs.
-
Ch
A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java on
generic-x64.
-
Commit messages:
- 8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java
on generic-x64
Changes: https://git.openjdk.org/jdk21/pull/60/files
Webrev: https://webrevs.
On Fri, 23 Jun 2023 11:24:23 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Fri, 23 Jun 2023 17:57:22 GMT, Joe Darcy wrote:
>> Correct misstatement that the Class object for a primitive type can only be
>> be access via fields like java.lang.Integer.TYPE.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Fri, 23 Jun 2023 17:09:12 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Fri, 23 Jun 2023 17:57:22 GMT, Joe Darcy wrote:
>> Correct misstatement that the Class object for a primitive type can only be
>> be access via fields like java.lang.Integer.TYPE.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Correct misstatement that the Class object for a primitive type can only be
> be access via fields like java.lang.Integer.TYPE.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix typo.
-
Changes:
- all: https://git.op
On Fri, 23 Jun 2023 17:25:00 GMT, Joe Darcy wrote:
>> Correct misstatement that the Class object for a primitive type can only be
>> be access via fields like java.lang.Integer.TYPE.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental
On Fri, 23 Jun 2023 11:58:00 GMT, Pavel Rappo wrote:
>> Thanks for the links, @pavelrappo.
>>
>> I understand the point you're making; however, there is still ambiguous
>> wording in the documentation for this method.
>>
>> The method is called `isPrimitive`, and it returns `true` for
>> `isP
On Fri, 23 Jun 2023 17:24:30 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> polish doc, review comments
>
> src/java.base/share/classes/java/lang/foreign/Linker.java line 659:
>
>> 657:
On Wed, 21 Jun 2023 23:33:37 GMT, Jorn Vernee wrote:
>> Improve the specification of `Linker.Option.firstVariadicArg`, by specifying
>> more clearly which index values are valid.
>
> Jorn Vernee has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Correct misstatement that the Class object for a primitive type can only be
> be access via fields like java.lang.Integer.TYPE.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the mer
> Clarify the behavior of `java.lang.Readable` when the specified
> `java.nio.CharBuffer` parameter is empty but read-only, and when it is full.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8222329: Remove redundancy of length
On Fri, 23 Jun 2023 17:07:34 GMT, Brian Burkhalter wrote:
>> I checked the update but it now has "no source remaining or its length is
>> zero". In CB, length == remaining so I think you just want one in the
>> description.
>
> Ah, good catch!
Fixed by 7281b482c24a3c74da15dbf637f7627c5dc5407b.
On Fri, 23 Jun 2023 16:50:28 GMT, Alan Bateman wrote:
>> Addressed in 94505a45ce099faf3e31a07b8500ac456345a3b1; CSR not yet updated.
>
> I checked the update but it now has "no source remaining or its length is
> zero". In CB, length == remaining so I think you just want one in the
> descriptio
On Tue, 20 Jun 2023 18:42:30 GMT, Mandy Chung wrote:
> Compact profiles are defined in Java SE 8 and are legacy in Java SE 9. jdeps
> -profile option was deprecated for removal in JDK 21. This option can be
> removed in JDK 22. Customers can use jdeps to find the set of modules
> required by t
On Fri, 23 Jun 2023 02:38:13 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
> On Windows, the basic Java Integer types are defined as long and __int64
> respectively. In particular, the former is rather problematic since it breaks
> compilation as the Visual C++ becomes stricter and more compliant with every
> release, which means the way Windows code treats long as a t
On Fri, 23 Jun 2023 15:11:47 GMT, Pavel Rappo wrote:
>> Yes:
>>
>> CacheKey(String baseName, Locale locale, Module module, Module caller) {
>> Objects.requireNonNull(module);
>> Objects.requireNonNull(caller);
>>
>> this.name = baseName;
>> this.locale = locale;
>> this.modu
On Fri, 23 Jun 2023 16:53:01 GMT, Alexey Ivanov wrote:
>> Hmm, I lean towards jint as I feel it conveys the fact that it is a Java
>> parameter clearer, intuitively to me it makes sense that a Java integer type
>> would still work in a C++ for loop in native code
>
> You're right… it gives a hi
On Fri, 23 Jun 2023 14:30:49 GMT, Julian Waters wrote:
>> To minimise the number of changes, we can go for using `jint` in
>> `AwtMenu::GetItem`.
>>
>> What do you thing, @djelinski and @TheShermanTanker?
>
> Hmm, I lean towards jint as I feel it conveys the fact that it is a Java
> parameter
On Fri, 23 Jun 2023 15:38:52 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/nio/X-Buffer.java.template line 484:
>>
>>> 482: * @throws ReadOnlyBufferException if target is a read only buffer,
>>> 483: * even if it is empty
>>> 484: * @since 1.5
>>
>> It
Backing out shuffle related overhaul done with
[JDK-8304450](https://bugs.openjdk.org/browse/JDK-8304450), we saw significant
performance degradation with VectorAPI JMH and our internal benchmarks.
Following two issues were filed on this recently.
1/ [JDK-8310459](https://bugs.openjdk.org/brows
Add `package-info.java` for package `jdk.nio.mapmode`.
-
Commit messages:
- 8310682: No package-info (and @since) for package jdk.nio.mapmode
Changes: https://git.openjdk.org/jdk/pull/14628/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14628&range=00
Issue: https://bugs.
On Thu, 22 Jun 2023 22:15:11 GMT, Brian Burkhalter wrote:
>> I have a slight preference for "no space remaining"; remaining can still be
>> a linkplain to the method if that helps it be specific.
>
> I concur. Thanks.
Addressed in 055107bddcc38a331ee93e178402473ab9f91740.
-
PR Rev
On Fri, 23 Jun 2023 06:49:31 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8222329: Correct return verbiage of Reader and CharBuffer
>
> src/java.base/share/classes/java/nio/X-Buffer.java.te
> Clarify the behavior of `java.lang.Readable` when the specified
> `java.nio.CharBuffer` parameter is empty but read-only, and when it is full.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8222329: Tweak verbiage some more
-
On Fri, 23 Jun 2023 13:46:04 GMT, Sergey Tsypanov wrote:
>> src/java.base/share/classes/java/util/ResourceBundle.java line 743:
>>
>>> 741: return ((module != null) &&
>>> (module.equals(otherEntry.getModule())) &&
>>> 742: (caller != null) &&
>>> (calle
On Fri, 23 Jun 2023 14:28:51 GMT, Alexey Ivanov wrote:
>> The declaration and implementation have to match.
>
> To minimise the number of changes, we can go for using `jint` in
> `AwtMenu::GetItem`.
>
> What do you thing, @djelinski and @TheShermanTanker?
Hmm, I lean towards jint as I feel it
On Fri, 23 Jun 2023 14:24:44 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Menu.h line 76:
>>
>>> 74: /*for multifont menu */
>>> 75: BOOL IsTopMenu();
>>> 76: virtual AwtMenuItem* GetItem(jobject target, int index);
>>
>> Hi @aivanov-jdk are you OK
On Fri, 23 Jun 2023 00:16:45 GMT, Julian Waters wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_MenuBar.cpp line 148:
>>
>>> 146: }
>>> 147:
>>> 148: AwtMenuItem* AwtMenuBar::GetItem(jobject target, jint index)
>>
>> What is the reason for using `jint` instead of `int`?
>>
>> The
On Fri, 23 Jun 2023 06:10:05 GMT, Daniel Jeliński wrote:
>> Julian Waters has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Revert wrong Copyright
>> - Copyright
>
> src/java.desktop/windows/native/libawt/windows/awt_Menu.h line 76:
>
On Fri, 23 Jun 2023 10:41:49 GMT, Pavel Rappo wrote:
>> Sergey Tsypanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restore logic
>
> src/java.base/share/classes/java/util/ResourceBundle.java line 743:
>
>> 741: retu
On Fri, 23 Jun 2023 07:44:31 GMT, Daohan Qu wrote:
> Similar to #11745 , this patch adds more information for
> `NoSuchFieldException` thrown by `getField()` or `getDeclaredField()` of
> `java.lang.Class`. The error message changes like the example below:
> 1. For `getField()`
>
> Before this
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Fri, 23 Jun 2023 11:52:12 GMT, Sam Brannen wrote:
> Along that line of thinking, it might be best to change the first sentence to
> "Determines if the specified Class object represents a primitive type or
> void."
I was just about to suggest exactly that, but from the superinterface method'
On Fri, 23 Jun 2023 11:34:43 GMT, Pavel Rappo wrote:
>> Hmm. I'll consider that. The javadoc in java.lang.Class is inconsistent in
>> the formatting of "void" as a type name, some instances are in code markup
>> while others are not.
>
>> @jddarcy and @pavelrappo, as I understood it, @liach is
Hi all,
This pull request contains a backport of commit
[4bf78162](https://github.com/openjdk/jdk/commit/4bf78162c52564645af79b8324b69d89102dc024)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Christian Stein on 23 Jun 2023 and
was
On Wed, 21 Jun 2023 00:35:09 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/Class.java line 818:
>>
>>> 816: * they represent, namely {@code boolean}, {@code byte},
>>> 817: * {@code char}, {@code short}, {@code int},
>>> 818: * {@code long}, {@code float}, and {@c
> By optimizing the implementation of java.lang.Long#fastUUID, the performance
> of the java.util.UUID#toString method can be significantly improved.
>
> The following are the test results of JMH:
>
> Benchmark Mode Cnt Score Error Units
> UUIDUtilsBenchmark.new
On Wed, 21 Jun 2023 00:35:09 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/Class.java line 818:
>>
>>> 816: * they represent, namely {@code boolean}, {@code byte},
>>> 817: * {@code char}, {@code short}, {@code int},
>>> 818: * {@code long}, {@code float}, and {@c
On Tue, 20 Jun 2023 13:54:15 GMT, Christian Stein wrote:
> Please review this update to `java`'s help output for `--module-path`/`-p`.
>
> This PR also updates the output for the closely related
> `--upgrade-module-path` option.
>
> Thanks in advance!
This pull request has now been integrated
> By optimizing the implementation of java.lang.Long#fastUUID, the performance
> of the java.util.UUID#toString method can be significantly improved.
>
> The following are the test results of JMH:
>
> Benchmark Mode Cnt Score Error Units
> UUIDUtilsBenchmark.new
On Fri, 23 Jun 2023 09:30:43 GMT, Chen Liang wrote:
> I think a message like 'Class.field' is better, more consistent with
> methodToString's behavior.
Hi, @liach, thanks for your suggestions, this `Class.field` format is indeed
more succinct. But I'm following this format (`NoSuchFieldError`
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last r
On Fri, 23 Jun 2023 09:37:47 GMT, Christian Stein wrote:
>> Please review this update to `java`'s help output for `--module-path`/`-p`.
>>
>> This PR also updates the output for the closely related
>> `--upgrade-module-path` option.
>>
>> Thanks in advance!
>
> Christian Stein has updated the
> Please review this update to `java`'s help output for `--module-path`/`-p`.
>
> This PR also updates the output for the closely related
> `--upgrade-module-path` option.
>
> Thanks in advance!
Christian Stein has updated the pull request incrementally with one additional
commit since the las
On Fri, 23 Jun 2023 07:44:31 GMT, Daohan Qu wrote:
> Similar to #11745 , this patch adds more information for
> `NoSuchFieldException` thrown by `getField()` or `getDeclaredField()` of
> `java.lang.Class`. The error message changes like the example below:
> 1. For `getField()`
>
> Before this
On Wed, 8 Mar 2023 08:50:24 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 22 Jun 2023 21:00:18 GMT, Roger Riggs wrote:
>> Sergey Tsypanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/java.base/share/classes/java/io/PipedOutputStream.java
>>
>> Co-authored-by: liach <7806504+li...@use
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last r
On Thu, 22 Jun 2023 11:51:15 GMT, Matthias Baesken wrote:
>> Currently, a number of tests fail on macOS because they miss the core file
>> (e.g. serviceability/sa/TestJmapCore.java).
>> The reason is that configure detects on some setups that codesign does not
>> work ("checking if debug mode c
On Fri, 23 Jun 2023 08:03:45 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit sin
On Fri, 23 Jun 2023 06:19:31 GMT, Daniel Jeliński wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 241:
>>
>>> 239: DISABLED_WARNINGS_gcc_OGLPaints.c :=
>>> format-nonliteral, \
>>> 240: DISABLED_WARNINGS_gcc_sun_awt_X11_GtkFileDialogPeer.c
>>> :=
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
Artem Semenov has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all:
Similar to #11745 , this patch adds more information for `NoSuchFieldException`
thrown by `getField()` or `getDeclaredField()` of `java.lang.Class`. The error
message changes like the example below:
1. For `getField()`
Before this change:
Exception in thread "main" java.lang.NoSuchFieldExceptio
97 matches
Mail list logo
