> As the API has improved over the recent releases, not all `{@snippet ..}`
> sections have been kept in sync.
>
> This PR suggests all snippets used should be verified against real code that
> is placed in a new `snippet-files` folder and erroneous snippets are updated.
>
> In this PR, it is s
On Wed, 17 May 2023 12:40:58 GMT, Volker Simonis wrote:
> Sorry, but I don't understand this argument. If we do a short read we will
> work with corrupted ChildStuff and SpawnInfo
> structures. This can in the extreme case execute arbitrary code (e.g. if
> ChildStuff.argv is not fully read fro
On Wed, 17 May 2023 13:53:55 GMT, Darragh Clarke wrote:
>> Updated instances of `toLowerCase` and `toUpperCase` in several net and io
>> files to specify `Locale.ROOT` to ensure that case conversion issues don't
>> occur,
>>
>> I didn't add any new tests but ran tier 1-3 with no issues
>
> Dar
On Thu, 18 May 2023 22:22:25 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>
> - the pattern matching for switch and record patterns features are made
> final, together with updates to tests.
> - parenthesized patterns are removed.
> - qualified enum constants are supported for case label
On Thu, 18 May 2023 21:25:26 GMT, Alexander Matveev
wrote:
> did we test jpackage on AIX system?
I don't think so. What is the native packaging on this platform?
-
PR Comment: https://git.openjdk.org/jdk/pull/13586#issuecomment-1553675715
On Mon, 15 May 2023 22:51:52 GMT, Roger Riggs wrote:
>> Refactor the Platform class in jdk.jpackage to use the internal
>> OperatingSystem, Architecture, and Version classes.
>> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
>> comparisons in the Platform class.
>> The che
On Mon, 15 May 2023 20:10:38 GMT, Roger Riggs wrote:
>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java line 51:
>>
>>> 49: Log.info(I18N.getString("MSG_Help_no_args"));
>>> 50: } else {
>>> 51: OperatingSystem platform = OperatingSystem.current(
On Wed, 17 May 2023 18:18:03 GMT, Maurizio Cimadamore
wrote:
>> This patch adds an instance method on `Linker`, namely
>> `Linker::canonicalLayouts` which returns all the layouts known by the linker
>> as implementing some ABI type. For instance, if I call this on my machine
>> (Linux/x64) I
On Thu, 18 May 2023 19:44:01 GMT, Naoto Sato wrote:
>> This change intends to interpret the BCP47 U extension wrt collation
>> settings in the given `Locale`, then applies them to the created instances
>> in the 1-arg factory method in `Collator`. A corresponding CSR has also been
>> drafted.
> This change intends to interpret the BCP47 U extension wrt collation settings
> in the given `Locale`, then applies them to the created instances in the
> 1-arg factory method in `Collator`. A corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with o
On Wed, 17 May 2023 18:18:03 GMT, Maurizio Cimadamore
wrote:
>> This patch adds an instance method on `Linker`, namely
>> `Linker::canonicalLayouts` which returns all the layouts known by the linker
>> as implementing some ABI type. For instance, if I call this on my machine
>> (Linux/x64) I
On Thu, 18 May 2023 18:23:53 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> com
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8308016: Address reviewer comments since previous commit
-
Changes:
- all: https:/
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Give subclass priority
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13689/files
- new:
On Wed, 17 May 2023 20:51:29 GMT, Brian Burkhalter wrote:
>> Replace `{@code ...}` patterns and the like with `{@snippet
>> lang=java : ...}`.
>
> Brian Burkhalter has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated cha
On Thu, 18 May 2023 16:42:23 GMT, Naoto Sato wrote:
>> This change intends to interpret the BCP47 U extension wrt collation
>> settings in the given `Locale`, then applies them to the created instances
>> in the 1-arg factory method in `Collator`. A corresponding CSR has also been
>> drafted.
Amending the description about the default decomposition mode in
`Collator.NO_DECOMPOSITION` javadoc.
-
Commit messages:
- 8308369: Default decomposition mode in Collator
Changes: https://git.openjdk.org/jdk/pull/14049/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14049&r
On Thu, 18 May 2023 16:52:15 GMT, Paul Sandoz wrote:
> Here's the crux of what i am wondering about. Can we specify native linker
> support for a subset of the System V Application Binary Interface (e.g., LP64
> and ILP32 programming models for all non-optional scalar types, sequences of,
> an
On Wed, 17 May 2023 15:50:13 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/io/RandomAccessFile.java line 904:
>>
>>> 902: * {@code b7}, and {@code b8,} where:
>>> 903: * {@snippet lang=java :
>>> 904: * 0 <= b1, b2, b3, b4, b5, b6, b7, b8 <= 255,
>>
>> Same:
On Thu, 18 May 2023 16:42:23 GMT, Naoto Sato wrote:
>> This change intends to interpret the BCP47 U extension wrt collation
>> settings in the given `Locale`, then applies them to the created instances
>> in the 1-arg factory method in `Collator`. A corresponding CSR has also been
>> drafted.
On Wed, 17 May 2023 18:18:03 GMT, Maurizio Cimadamore
wrote:
>> This patch adds an instance method on `Linker`, namely
>> `Linker::canonicalLayouts` which returns all the layouts known by the linker
>> as implementing some ABI type. For instance, if I call this on my machine
>> (Linux/x64) I
> This change intends to interpret the BCP47 U extension wrt collation settings
> in the given `Locale`, then applies them to the created instances in the
> 1-arg factory method in `Collator`. A corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with o
On Thu, 4 May 2023 09:17:05 GMT, Adam Sotona wrote:
>> libjli/java.c's SelectVersion method receives argc and argv but ignores argc
>> in some circumstances an instead checks if *argv == 0 in its while loop,
>> which results in a segmentation fault if the provided array is not NULL
>> terminat
On Wed, 29 Mar 2023 01:40:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Wed, 17 May 2023 15:05:53 GMT, Raffaello Giulietti
wrote:
>> When appropriate and useful, copies only the relevant portion of the
>> `CharSequence` to the match result.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Thu, 18 May 2023 06:06:05 GMT, Alan Bateman wrote:
>> Hmm, most java bytecode (classfiles) aren't going to care about the
>> endian-ness; in int is an int, etc.
>> Runtime calls to extract int from byte[] is going to check a runtime flag;
>> possibly static and optimization by HotSpot, etc.
On Wed, 29 Mar 2023 01:40:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Thu, 18 May 2023 07:08:57 GMT, Thomas Stuefe wrote:
> Trivial fix for a small problem.
>
> jspawnhelper gets handed several file descriptors as arguments. The buffer
> size for this string is too small (7 chars per fd) to print out every
> conceivable int. This will overun the buffer if we
On Thu, 18 May 2023 13:46:54 GMT, Roger Riggs wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits
On Mon, 15 May 2023 22:51:52 GMT, Roger Riggs wrote:
>> Refactor the Platform class in jdk.jpackage to use the internal
>> OperatingSystem, Architecture, and Version classes.
>> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
>> comparisons in the Platform class.
>> The che
On Thu, 18 May 2023 06:12:19 GMT, Amit Kumar wrote:
> s390x needs to be recognised as `S390`. After
> [JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913) during build I was
> getting this PluginException:
>
> jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No enum
>
On Thu, 18 May 2023 06:12:19 GMT, Amit Kumar wrote:
> s390x needs to be recognised as `S390`. After
> [JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913) during build I was
> getting this PluginException:
>
> jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No enum
>
On Thu, 18 May 2023 09:22:19 GMT, Thomas Stuefe wrote:
>> Trivial fix for a small problem.
>>
>> jspawnhelper gets handed several file descriptors as arguments. The buffer
>> size for this string is too small (7 chars per fd) to print out every
>> conceivable int. This will overun the buffer i
On Thu, 18 May 2023 09:33:00 GMT, Maurizio Cimadamore
wrote:
>> The FFM API exposes layout constants for Java primitives. Among those there
>> are constants for `JAVA_LONG` and `JAVA_DOUBLE`. Currently, the alignment of
>> these layouts is set the same as their size (e.g. 8 bytes).
>>
>> This
On Wed, 17 May 2023 13:53:55 GMT, Darragh Clarke wrote:
>> Updated instances of `toLowerCase` and `toUpperCase` in several net and io
>> files to specify `Locale.ROOT` to ensure that case conversion issues don't
>> occur,
>>
>> I didn't add any new tests but ran tier 1-3 with no issues
>
> Dar
On Mon, 15 May 2023 10:59:11 GMT, Andrew Haley wrote:
> > > This looks like it might be removed by loop opts. I think you might need
> > > a blackhole somewhere.
> >
> >
> > `m` will be updated in every iteration of this loop, so `m` is not a
> > loop-invariants actually. I can see the assemb
> In Vector API Java level, vector mask is represented as a boolean array with
> 0x00/0x01 (8 bits of each element) as values, aka in-memory format. When it
> is loaded into vector register, e.g. Neon, the in-memory format will be
> converted to in-register format with 0/-1 value for each lane (
On Wed, 17 May 2023 13:53:55 GMT, Darragh Clarke wrote:
>> Updated instances of `toLowerCase` and `toUpperCase` in several net and io
>> files to specify `Locale.ROOT` to ensure that case conversion issues don't
>> occur,
>>
>> I didn't add any new tests but ran tier 1-3 with no issues
>
> Dar
On Wed, 17 May 2023 19:40:04 GMT, Naoto Sato wrote:
> This change intends to interpret the BCP47 U extension wrt collation settings
> in the given `Locale`, then applies them to the created instances in the
> 1-arg factory method in `Collator`. A corresponding CSR has also been drafted.
test/j
On Thu, 18 May 2023 09:28:14 GMT, Maurizio Cimadamore
wrote:
>> The FFM API exposes layout constants for Java primitives. Among those there
>> are constants for `JAVA_LONG` and `JAVA_DOUBLE`. Currently, the alignment of
>> these layouts is set the same as their size (e.g. 8 bytes).
>>
>> This
> The FFM API exposes layout constants for Java primitives. Among those there
> are constants for `JAVA_LONG` and `JAVA_DOUBLE`. Currently, the alignment of
> these layouts is set the same as their size (e.g. 8 bytes).
>
> This is obviously correct on 64-bit platforms, but on 32-bit platform it
> In Vector API Java level, vector mask is represented as a boolean array with
> 0x00/0x01 (8 bits of each element) as values, aka in-memory format. When it
> is loaded into vector register, e.g. Neon, the in-memory format will be
> converted to in-register format with 0/-1 value for each lane (
> Trivial fix for a small problem.
>
> jspawnhelper gets handed several file descriptors as arguments. The buffer
> size for this string is too small (7 chars per fd) to print out every
> conceivable int. This will overun the buffer if we happen to have fds larger
> than (printed size) 7 charac
> As explained in [1], memory layouts and memory segments describe sizes using
> different units. Memory layouts use bits, whereas memory segments use bytes.
> This is historical: memory layouts were designed after the Minimal LDL [2],
> which allowed layout strings to be used to describe both m
> As explained in [1], memory layouts and memory segments describe sizes using
> different units. Memory layouts use bits, whereas memory segments use bytes.
> This is historical: memory layouts were designed after the Minimal LDL [2],
> which allowed layout strings to be used to describe both m
On Thu, 18 May 2023 07:08:57 GMT, Thomas Stuefe wrote:
> Trivial fix for a small problem.
>
> jspawnhelper gets handed several file descriptors as arguments. The buffer
> size for this string is too small (7 chars per fd) to print out every
> conceivable int. This will overun the buffer if we
On Wed, 17 May 2023 16:12:15 GMT, Volker Simonis wrote:
>> src/java.base/unix/native/libjava/ProcessImpl_md.c line 490:
>>
>>> 488: pid_t resultPid;
>>> 489: int i, offset, rval, bufsize, magic;
>>> 490: char *buf, buf1[24];
>>
>> Since you are here could you please increase buffer
On Wed, 17 May 2023 16:00:23 GMT, Volker Simonis wrote:
>> Since JDK13, executing commands in a sub-process defaults to the so called
>> `POSIX_SPAWN` launching mechanism (i.e.
>> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
>> using `posix_spawn(3)` to firstly sta
Trivial fix for a small problem.
jspawnhelper gets handed several file descriptors as arguments. The buffer size
for this string is too small (7 chars per fd) to print out every conceivable
int. This will overun the buffer if we happen to have fds larger than (printed
size) 7 characters. This c
50 matches
Mail list logo
