On Thu, 18 May 2023 09:22:19 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Trivial fix for a small problem. >> >> jspawnhelper gets handed several file descriptors as arguments. The buffer >> size for this string is too small (7 chars per fd) to print out every >> conceivable int. This will overun the buffer if we happen to have fds larger >> than (printed size) 7 characters. This could lead to crashes or malfunctions >> if the parent VM has opened a large amount of file descriptors. >> >> Note that on Linux, this can normally not happen since the kernel limits the >> number of open file descriptors per process to 1M, and these fds are still >> printable within the limits of this buffer. It is possible to get more fds >> per process, but only via kernel patch. But we still should not rely on >> that. And there is also still MacOS using the same mechanism. > > Thomas Stuefe has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'openjdk:master' into > JDK-8308350-Increase-buffer-size-for-jspawnhelper-arguments > - JDK-8308350-Increase-buffer-size-for-jspawnhelper-arguments Trivial ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14045#pullrequestreview-1432744394
