On Wed, 29 Mar 2023 01:40:36 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8206890? >> >> The `jlink` command allows a `--endian` option to specify the byte order in >> the generated image. Before this change, when such a image was being >> launched, the code would assume the byte order in the image to be the native >> order of the host where the image is being launched. That would result in >> failure to launch java, as noted in the linked issue. >> >> The commit in this PR, changes relevant places to not assume native order >> and instead determine the byte order by reading the magic bytes in the image >> file's header content. >> >> A new jtreg test has been added which reproduces the issue and verifies the >> fix. > > Jaikiran Pai has updated the pull request incrementally with two additional > commits since the last revision: > > - cleanup test - rename method and update code comment as suggested by Alan > - Rename KNOWN_ENDIANNESS to PLATFORM_PROPERTIES We will probably have to remove the mapping here if we treat ppc64le as a new architecture: https://github.com/openjdk/jdk/blob/cc5c9b5da2de4229c0244169bcbd6496f68db5ab/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java#L55 ------------- PR Comment: https://git.openjdk.org/jdk/pull/11943#issuecomment-1553249225
