On Sat, 15 Apr 2023 00:36:35 GMT, Lance Andersen wrote:
>> Please review this trivial change when ZipFS returns the wrong
>> java.nio.file.FileSystemException message due the the parameters being
>> reversed.
>>
>> I also included a simple junit test as part of the fix.
>>
>> Mach5 tiers1-3 a
On Thu, 30 Mar 2023 09:20:16 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> src/java.base/share/classes/java/util/SequencedC
On Thu, 30 Mar 2023 09:39:14 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> src/java.base/share/classes/java/util/LinkedHash
On Sat, 25 Mar 2023 07:09:43 GMT, Rémi Forax wrote:
>> Stuart Marks has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - More specification tweaks.
>> - Add simple overrides to ArrayList.
>
> src/java.base/share/classes/java/util/ArrayList
On Thu, 3 Nov 2022 20:33:40 GMT, Chen Liang wrote:
>> Stuart Marks has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 80 commits:
>>
>> - Merge branch 'master' into JDK-8266571-SequencedCollections
>> - Simplify handling of cached
On Fri, 2 Dec 2022 16:40:51 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly) ac
On Sun, 22 Jan 2023 09:18:37 GMT, Ichiroh Takiguchi
wrote:
> On jdk17, following testcase works fine on Linux platform.
>
> Testcase
>
> $ cat cstest1.java
> import java.nio.charset.*;
>
> public class cstest1 {
> public static void main(String[] args) throws Exception {
> Charset cs =
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance Andersen has updated the pull r
On Fri, 14 Apr 2023 22:27:26 GMT, Brent Christian wrote:
>> With the removal of the AltFinalizer mechanism from `FileInputStream` and
>> `FileOutputStream` in
>> [JDK-8192939](https://bugs.openjdk.org/browse/JDK-8192939), this portion of
>> the Implementation Requirement in the class JavaDoc i
On Fri, 14 Apr 2023 07:57:20 GMT, Alan Bateman wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updates, per review comments
>
> src/java.base/share/classes/java/io/FileInputStream.java line 45:
>
>> 43: * @api
> With the removal of the AltFinalizer mechanism from `FileInputStream` and
> `FileOutputStream` in
> [JDK-8192939](https://bugs.openjdk.org/browse/JDK-8192939), this portion of
> the Implementation Requirement in the class JavaDoc is no longer true:
>
>> If this FileOutputStream has been subcl
On Fri, 14 Apr 2023 21:59:33 GMT, Lance Andersen wrote:
>> Please review this trivial change when ZipFS returns the wrong
>> java.nio.file.FileSystemException message due the the parameters being
>> reversed.
>>
>> I also included a simple junit test as part of the fix.
>>
>> Mach5 tiers1-3 a
On Fri, 14 Apr 2023 21:30:40 GMT, Eirik Bjorsnos wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address additional feedback
>
> test/jdk/jdk/nio/zipfs/ZipFSDirectoryExceptionMessageTest.java line 40:
>
>> 38:
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance Andersen has updated the pull r
On Fri, 14 Apr 2023 21:40:17 GMT, Lance Andersen wrote:
>> Please review this trivial change when ZipFS returns the wrong
>> java.nio.file.FileSystemException message due the the parameters being
>> reversed.
>>
>> I also included a simple junit test as part of the fix.
>>
>> Mach5 tiers1-3 a
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance Andersen has updated the pull r
On Fri, 14 Apr 2023 17:08:10 GMT, Erik Joelsson wrote:
>> make/modules/java.base/gensrc/GensrcMisc.gmk line 72:
>>
>>> 70: endif
>>> 71:
>>> 72: $(eval $(call SetupTextFileProcessing, BUILD_PLATFORMPROPERTIES_JAVA, \
>>
>> @erikj79 Is there a better/good way to do these mappings, or select "lo
On Fri, 14 Apr 2023 21:07:37 GMT, Naoto Sato wrote:
> Looks good, Lance. Nit: copyright year -> 2023
Geez, working in too many workspaces. Thank you, just pushed the update
-
PR Comment: https://git.openjdk.org/jdk/pull/13482#issuecomment-1509300245
On Fri, 14 Apr 2023 21:08:28 GMT, Christian Stein wrote:
> Looks good to me.
Thank you Christian
-
PR Comment: https://git.openjdk.org/jdk/pull/13482#issuecomment-1509301103
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance Andersen has updated the pull r
> Many Calendar methods that take in a field parameter should document that
> they throw an ArrayIndexOutOfBoundsException if field is not between 0 and
> `Calendar.FIELD_COUNT`.
>
> This PR adds a clause to the class description to make the above apparent.
>
> `Calendar.Roll(int, int)`, `Calen
On Fri, 14 Apr 2023 20:24:00 GMT, Lance Andersen wrote:
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clea
On Wed, 29 Mar 2023 22:04:08 GMT, Justin Lu wrote:
> Many Calendar methods that take in a field parameter should document that
> they throw an ArrayIndexOutOfBoundsException if field is not between 0 and
> `Calendar.FIELD_COUNT`.
>
> This PR adds a clause to the class description to make the a
On Fri, 14 Apr 2023 20:24:00 GMT, Lance Andersen wrote:
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clea
Many Calendar methods that take in a field parameter should document that they
throw an ArrayIndexOutOfBoundsException if field is not between 0 and
`Calendar.FIELD_COUNT`.
This PR adds a clause to the class description to make the above apparent.
`Calendar.Roll(int, int)`, `Calendar.roll(int,
Please review this trivial change when ZipFS returns the wrong
java.nio.file.FileSystemException message due the the parameters being reversed.
I also included a simple junit test as part of the fix.
Mach5 tiers1-3 are clean
Best
Lance
-
Commit messages:
- (zipfs) Opening a direc
On Fri, 17 Mar 2023 12:15:58 GMT, Jan Lahoda wrote:
> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>
> - the pattern matching for switch and record patterns features are made
> final, together with updates to tests.
> - parenthesized patterns are removed.
> -
On Fri, 14 Apr 2023 14:34:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes the `java.compiler`
>> system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676.
>>
>> A CSR has been filed for this change and is available at
>> https://bugs.ope
On Sat, 11 Mar 2023 08:27:06 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
> Please review this PR which brings the DataDescriptorSignatureMissing test
> back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a
> Data Descriptor without the recommended but optional signature. The Python
> dependency has turned out to be very brittl
On Fri, 14 Apr 2023 14:31:31 GMT, Roger Riggs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed isPPC64().
>> Consolidated switch cases in ArchTest.
>> Moved mapping of build TARGET_OS and TARGET_CPU to the
On Fri, 14 Apr 2023 16:36:59 GMT, Jan Lahoda wrote:
>> FWIW... an observation from working on
>> [JDK-7176515](https://bugs.openjdk.org/browse/JDK-7176515). This is probably
>> redundant but here goes anyway.
>>
>> In the compiler there are currently three different ways of handling enums
>>
On Fri, 14 Apr 2023 16:10:49 GMT, Archie L. Cobbs wrote:
>> FWIW, a sketch on how avoiding the enum initialization might look like is
>> here:
>> https://github.com/lahodaj/jdk/compare/JDK-8300543...lahodaj:jdk:JDK-8300543-lazy-enum?expand=1
>>
>> more work needed to make that work for `typeSwi
On Thu, 13 Apr 2023 12:07:00 GMT, Jan Lahoda wrote:
>> Note that currently, a `switch` over an enum will already trigger
>> initialisation of the enum class because of the need to compute the relevant
>> mapping array by the synthetic helper class, see [JDK‑7176515] for details.
>> - https://gi
On Thu, 13 Apr 2023 23:45:45 GMT, Naoto Sato wrote:
>> Upgrading the CLDR to [version
>> 43](https://cldr.unicode.org/index/downloads/cldr-43). This semi-annual
>> release is their `limited-submission` release so I would not expect
>> regressions caused by formatting changes as we had in JDK20
On Fri, 14 Apr 2023 15:07:37 GMT, Andy-Tatman wrote:
> So while changing the specifications is possible, it can potentially break
> existing clients. The change suggested in this pull request avoids this and
> instead fixes the internal bug of the get function locally, without affecting
> the
On Wed, 12 Apr 2023 06:46:39 GMT, Alan Bateman wrote:
>> See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734
>
> The BitSet API requires that the logical size fit in an int so I think you'll
> end up changing the set methods to disallow an index of MAX_VALUE.
>
> Can you change the ti
On Fri, 14 Apr 2023 14:34:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes the `java.compiler`
>> system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676.
>>
>> A CSR has been filed for this change and is available at
>> https://bugs.ope
On Wed, 12 Apr 2023 16:35:19 GMT, Mahendra Chhipa wrote:
> Following tests read the unicode data files
> (http://www.unicode.org/Public/UNIDATA/ ) from src directory. For tests,
> these files should be in test directories. No source code is using these
> files. Only tests are using these files
On Wed, 12 Apr 2023 17:31:49 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Fri, 14 Apr 2023 14:26:24 GMT, Roger Riggs wrote:
>> Hello Alan,
>>
>>> This looks okay although the warning for the empty value and "NONE" case
>>> will probably wrap as it's very long.
>>
>> Agreed, it's a bit long. I can't think of a simpler message though. If
>> anyone has a suggestion
> Can I please get a review of this change which removes the `java.compiler`
> system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676.
>
> A CSR has been filed for this change and is available at
> https://bugs.openjdk.org/browse/JDK-8305998. The CSR has more details about
On Fri, 14 Apr 2023 14:21:56 GMT, Jaikiran Pai wrote:
>> src/hotspot/share/runtime/arguments.cpp line 1313:
>>
>>> 1311: " use -Xint if you want to run the application in
>>> interpreted-only mode.");
>>> 1312: } else {
>>> 1313: warning("The java.compiler system pro
On Fri, 14 Apr 2023 13:28:40 GMT, Alan Bateman wrote:
>> Can I please get a review of this change which removes the `java.compiler`
>> system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676.
>>
>> A CSR has been filed for this change and is available at
>> https://bugs.ope
Classfile API didn't handle transformations of class files version 50 and below
correctly.
Proposed fix have two parts:
1. Inflation of branch targets does not depend on StackMapTable attribute
presence for class file version 50 and below. Alternative fallback
implementation is provided.
2.
On Wed, 12 Apr 2023 16:35:19 GMT, Mahendra Chhipa wrote:
> Following tests read the unicode data files
> (http://www.unicode.org/Public/UNIDATA/ ) from src directory. For tests,
> these files should be in test directories. No source code is using these
> files. Only tests are using these files
On Fri, 14 Apr 2023 07:54:39 GMT, Alan Bateman wrote:
>> With the removal of the AltFinalizer mechanism from `FileInputStream` and
>> `FileOutputStream` in
>> [JDK-8192939](https://bugs.openjdk.org/browse/JDK-8192939), this portion of
>> the Implementation Requirement in the class JavaDoc is n
On Fri, 14 Apr 2023 12:19:41 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes the `java.compiler`
> system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676.
>
> A CSR has been filed for this change and is available at
> https://bugs.openjdk.
On Fri, 14 Apr 2023 12:19:41 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes the `java.compiler`
> system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676.
>
> A CSR has been filed for this change and is available at
> https://bugs.openjdk.
On Fri, 14 Apr 2023 12:19:41 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes the `java.compiler`
> system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676.
>
> A CSR has been filed for this change and is available at
> https://bugs.openjdk.
On Thu, 13 Apr 2023 10:59:46 GMT, ExE Boss wrote:
>> Hi Christian,
>>
>> Thanks for the comment.
>>
>> First, the "Dumbest possible strategy" comment should be interpreted as "we
>> would like to do something better", not that using something slow is OK
>> permanently. There's an attempt to d
On Thu, 13 Apr 2023 07:49:05 GMT, Jan Lahoda wrote:
>> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 1:
>>
>>> 1: /*
>>
>> @lahodaj The way that the boostrap method `enumSwitch` and its
>> corresponding implementation method `doEnumSwitch` are implemented right now
On Wed, 12 Apr 2023 19:47:25 GMT, Christian Wimmer wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are re
On Fri, 17 Mar 2023 12:15:58 GMT, Jan Lahoda wrote:
> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>
> - the pattern matching for switch and record patterns features are made
> final, together with updates to tests.
> - parenthesized patterns are removed.
> -
On Fri, 17 Mar 2023 12:15:58 GMT, Jan Lahoda wrote:
> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>
> - the pattern matching for switch and record patterns features are made
> final, together with updates to tests.
> - parenthesized patterns are removed.
> -
This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
- the pattern matching for switch and record patterns features are made final,
together with updates to tests.
- parenthesized patterns are removed.
- qualified enum constants are supported for case labels.
This cha
Can I please get a review of this change which removes the `java.compiler`
system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676.
A CSR has been filed for this change and is available at
https://bugs.openjdk.org/browse/JDK-8305998. The CSR has more details about
this propo
On Wed, 5 Apr 2023 09:19:57 GMT, Viktor Klang wrote:
> Adds overrides for common Map operations to avoid having to allocate the
> entrySet for Collectors$Partition maps.
This pull request has now been integrated.
Changeset: 54bf3700
Author:Viktor Klang
Committer: Tagir F. Valeev
URL:
On Tue, 11 Apr 2023 23:55:50 GMT, Brent Christian wrote:
> With the removal of the AltFinalizer mechanism from `FileInputStream` and
> `FileOutputStream` in
> [JDK-8192939](https://bugs.openjdk.org/browse/JDK-8192939), this portion of
> the Implementation Requirement in the class JavaDoc is no
59 matches
Mail list logo
