On Fri, 14 Apr 2023 14:21:56 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 1313:
>> 
>>> 1311:                 " use -Xint if you want to run the application in 
>>> interpreted-only mode.");
>>> 1312:     } else {
>>> 1313:         warning("The java.compiler system property is obsolete and no 
>>> longer supported.");
>> 
>> This looks okay although the warning for the empty value and "NONE" case 
>> will probably wrap as it's very long. Today, -Djava.compiler=foo is ignored, 
>> no warning, seems good to emit a warning about that too.
>
> Hello Alan,
> 
>> This looks okay although the warning for the empty value and "NONE" case 
>> will probably wrap as it's very long.
> 
> Agreed, it's a bit long. I can't think of a simpler message though. If anyone 
> has a suggestion, I'll update accordingly.

Just drop the detailed explanation, they can check the help for -Xint.

"The java.compiler system property is obsolete and no longer supported, use 
-Xint".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13475#discussion_r1166907316

Reply via email to