On Fri, 14 Apr 2023 14:31:31 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed isPPC64(). >> Consolidated switch cases in ArchTest. >> Moved mapping of build TARGET_OS and TARGET_CPU to the build >> to avoid multiple mappings in more than one place. > > make/modules/java.base/gensrc/GensrcMisc.gmk line 72: > >> 70: endif >> 71: >> 72: $(eval $(call SetupTextFileProcessing, BUILD_PLATFORMPROPERTIES_JAVA, \ > > @erikj79 Is there a better/good way to do these mappings, or select "local" > variable names? Not sure if it's better, but you could consider doing this directly in the switch statements in `make/autoconf/platform.m4` and add the corresponding variables in `spec.gmk.in`. That would make them available globally in the build, which may also be detrimental as parts of the build could start relying on them, and we end up with even more variants sprinkled around. I think what you have here is better for now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1167095379
