On Sat, 8 Apr 2023 05:37:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this doc only change which fixes a trivial typo
> in the documentation of `ObjectOutputStream.replaceObject()` method, as noted
> in https://bugs.openjdk.org/browse/JDK-6441827?
Marked as reviewed by iris (Revi
Can I please get a review of this doc only change which fixes a trivial typo in
the documentation of `ObjectOutputStream.replaceObject()` method, as noted in
https://bugs.openjdk.org/browse/JDK-6441827?
-
Commit messages:
- 6441827: Documentation mentions nonexistent NullReferenceE
On Fri, 7 Apr 2023 12:05:28 GMT, Lutz Schmidt wrote:
>> Okay, Lutz is the expert here. Sorry for the noise.
>
> Just to let my voice be heard directly after being cited several times: s390
> is used to designate the CPU architecture. The arch-specific files are stored
> in src/hotspot/cpu/s390
On Fri, 7 Apr 2023 21:13:03 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Fri, 7 Apr 2023 06:03:11 GMT, Thomas Stuefe wrote:
>>> What did you use as the example that would not compile on the other
>>> architecture?
>>
>> https://github.com/openjdk/jdk/blob/52ca4a70fc3de9e285964f9545ea8cd54e2d9924/src/java.base/share/classes/jdk/internal/util/OperatingSystemProps.
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, IA64, ARM, AARCH64, RISCV64, S390X,
> PPC64LE`
> Note
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
On Mon, 3 Apr 2023 21:56:31 GMT, Justin Lu wrote:
> The GregorianCalendar constructors and Calendar.getInstance() methods that
> take TimeZone or Locale throw a NullPointerException if any values are null.
>
> This PR updates the javadoc to make this apparent.
Marked as reviewed by naoto (Rev
> IO stream classes like `FileOutputStream` can have assocated NIO channels.
>
> When `close()` is invoked on one of these classes, it in turn invokes
> `close()` on the associated channel (if any). But when the associated
> channel's `close()` method is invoked, it in turn invokes `close()` on
On Fri, 7 Apr 2023 11:51:21 GMT, Jatin Bhateja wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> small cosmetics
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractShuffle.java
> line 96:
>
>>
On Thu, 6 Apr 2023 17:50:58 GMT, Chen Liang wrote:
>> It looks like Proxy forcibly adds reads and exports edges from the module of
>> the target interface to the module that defines the proxy:
>> https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/reflect/Proxy.java
On Fri, 7 Apr 2023 14:16:32 GMT, Archie L. Cobbs wrote:
>> IO stream classes like `FileOutputStream` can have assocated NIO channels.
>>
>> When `close()` is invoked on one of these classes, it in turn invokes
>> `close()` on the associated channel (if any). But when the associated
>> channel'
The GregorianCalendar constructors and Calendar.getInstance() methods that take
TimeZone or Locale throw a NullPointerException if any values are null.
This PR updates the javadoc to make this apparent.
-
Commit messages:
- Adjust wording
- Document exceptions
Changes: https://g
On Fri, 7 Apr 2023 13:36:22 GMT, Jatin Bhateja wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractVector.java
>> line 226:
>>
>>> 224:
>>> 225: AbstractSpecies species = vspecies().asIntegral();
>>> 226: Vector iota = species.iota();
>>
>> we can do
> Hi,
>
> This patch reimplements `VectorShuffle` implementations to be a vector of the
> bit type. Currently, VectorShuffle is stored as a byte array, and would be
> expanded upon usage. This poses several drawbacks:
>
> 1. Inefficient conversions between a shuffle and its corresponding vector
On Thu, 9 Mar 2023 19:49:29 GMT, Eamonn McManus wrote:
> Instant.ofEpochMilli says this:
>
>
> @throws DateTimeException if the instant exceeds the maximum or minimum
> instant
>
>
> But that can't happen. Even given `Long.MIN_VALUE` or `Long.MAX_VALUE` it
> does not throw. That's already i
On Fri, 7 Apr 2023 16:29:31 GMT, Alan Bateman wrote:
> I've updated the CSR to align it with the proposed solution. Please review
> again and if you happy, press "Finalize".
Thanks, Alan, this looks good to me. I have pressed "Finalize".
The CSR makes promises about the Release Note. Do you th
On Fri, 7 Apr 2023 07:47:49 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementat
On Fri, 7 Apr 2023 16:09:06 GMT, Alan Bateman wrote:
> Perhaps the issue summary / PR title should be more like this?
I'm not so sure. What you suggest describes this fix for this bug, but it
doesn't really describe the bug itself - instead, the bug argues that the
reentrant behavior is wrong
On Fri, 7 Apr 2023 15:53:10 GMT, Brian Burkhalter wrote:
> Perhaps the issue summary / PR title should be more like this?
>
> ```
> Clarify reentrant behavior of the close method of FileInputStream,
> FileOutputStream, and RandomAccessFile
> ```
or better still, create a new issue in JBS as it
On Fri, 7 Apr 2023 14:16:32 GMT, Archie L. Cobbs wrote:
>> IO stream classes like `FileOutputStream` can have assocated NIO channels.
>>
>> When `close()` is invoked on one of these classes, it in turn invokes
>> `close()` on the associated channel (if any). But when the associated
>> channel'
On Thu, 9 Mar 2023 19:49:29 GMT, Eamonn McManus wrote:
> Instant.ofEpochMilli says this:
>
>
> @throws DateTimeException if the instant exceeds the maximum or minimum
> instant
>
>
> But that can't happen. Even given `Long.MIN_VALUE` or `Long.MAX_VALUE` it
> does not throw. That's already i
On Thu, 9 Mar 2023 19:49:29 GMT, Eamonn McManus wrote:
> Instant.ofEpochMilli says this:
>
>
> @throws DateTimeException if the instant exceeds the maximum or minimum
> instant
>
>
> But that can't happen. Even given `Long.MIN_VALUE` or `Long.MAX_VALUE` it
> does not throw. That's already i
On Thu, 6 Apr 2023 22:44:52 GMT, Phil Race wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unneeded qualified export from java.base to jdk.attach
>
> src/jdk.accessibility/windows/classes/com/sun/java/accessi
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
> implementation of MethodHandleProxies.asInterface has a few issues:
> 1. Exposes too much information via Proxy supertype (and WrapperInstance
> interface)
> 2. Does not allow future expansion to support SAM[^1] abstrac
> With the addition of `jdk.internal.util.OperatingSystem` references to the
> system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
> - java.prefs,
> - java.security.jgss,
> - java.smartcardio,
> - jdk.charsets,
> - jdk.net,
> - jdk.zipfs
Roger Riggs has update
On Fri, 7 Apr 2023 12:36:04 GMT, Jatin Bhateja wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> small cosmetics
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractVector.java
> line 226:
>
>>
On Fri, 31 Mar 2023 12:25:16 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch reimplements `VectorShuffle` implementations to be a vector of
>> the bit type. Currently, VectorShuffle is stored as a byte array, and would
>> be expanded upon usage. This poses several drawbacks:
>>
>> 1. Ineffic
On Thu, 6 Apr 2023 22:36:33 GMT, Archie L. Cobbs wrote:
> IO stream classes like `FileOutputStream` can have assocated NIO channels.
>
> When `close()` is invoked on one of these classes, it in turn invokes
> `close()` on the associated channel (if any). But when the associated
> channel's `cl
> IO stream classes like `FileOutputStream` can have assocated NIO channels.
>
> When `close()` is invoked on one of these classes, it in turn invokes
> `close()` on the associated channel (if any). But when the associated
> channel's `close()` method is invoked, it in turn invokes `close()` on
On Mon, 3 Apr 2023 17:43:55 GMT, Raffaello Giulietti
wrote:
> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
> addition to the substrings returned by current `split()` variants, also
> return the delimiters matching the regular expression.
@RogerRiggs All concerns
> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
> addition to the substrings returned by current `split()` variants, also
> return the delimiters matching the regular expression.
Raffaello Giulietti has updated the pull request incrementally with one
additional comm
On Fri, 7 Apr 2023 12:54:01 GMT, ExE Boss wrote:
> The **JVM** spec doesn’t mention that anywhere though.
I don't think JVMS mentions hidden classes at all. You have to refer to the
specification of Lookup.defineHiddenClass, as hidden classes were originated
from VM anonymous classes added bac
On Fri, 7 Apr 2023 11:41:52 GMT, Johannes Kuhn wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java line
>> 317:
>>
>>> 315: cob.aload(1);
>>> 316: cob.invokevirtual(CD_MethodHandles_Lookup,
>>> "lookupClass", MTD_Class);
>>> 317:
On Fri, 7 Apr 2023 11:54:00 GMT, Alan Bateman wrote:
>> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
>> APIs that were preview APIs in Java 19/20 are changed to permanent and their
>> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
>>
On Fri, 7 Apr 2023 11:21:33 GMT, Thomas Stuefe wrote:
>> Hello Thomas, that change was based on the review comment here
>> https://github.com/openjdk/jdk/pull/13357#discussion_r1159810942
>
> Okay, Lutz is the expert here. Sorry for the noise.
Just to let my voice be heard directly after being
> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
> APIs that were preview APIs in Java 19/20 are changed to permanent and their
> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
> JNI and JVMTI versions are bumped as this is the first chan
On Fri, 7 Apr 2023 11:20:12 GMT, ExE Boss wrote:
> that can’t refer to hidden classes
No, that is exactly the **one and only thing** that can refer to the hidden
class:
> * On any attempt to resolve the entry in the run-time constant pool indicated
> by `this_class`, the symbolic reference is
On Thu, 6 Apr 2023 20:47:10 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
On Fri, 7 Apr 2023 10:52:47 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/jdk/internal/util/Architecture.java line 41:
>>
>>> 39: AARCH64(),
>>> 40: RISCV64(),
>>> 41: S390(),
>>
>> Why getting rid of the X in s390x? There has not been an s390 linux kernel
>> in almost te
On Fri, 7 Apr 2023 10:24:20 GMT, Thomas Stuefe wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unneeded qualified export from java.base to jdk.attach
>
> src/java.base/share/classes/jdk/internal/util/Architec
On Thu, 6 Apr 2023 19:25:19 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Mon, 3 Apr 2023 17:16:26 GMT, Andrey Turbanov wrote:
> `LinkedHashMap` `ZipFileSystem.inodes` contains only
> non-null values. It means instead of separate `containsKey`+`get` calls, we
> can use single `LinkedHashMap.get` call and then compare result with `null`.
> Result code is a bit simp
On Fri, 7 Apr 2023 09:28:18 GMT, Thomas Stuefe wrote:
> > > What I meant was: You define PPCLE. PPCLE specifies ppc, little endian.
> > > We also have PPC big-endian, it is used by AIX (and you can also run
> > > Linux with PPC big-endian). Why omit that?
> > > os.arch for AIX is "ppc64".
> >
On Tue, 1 Nov 2022 00:02:46 GMT, David Schlosnagle wrote:
>> Anyway, i think you are right, this can be public
>
> If this is a public int field, it will be inlined to class file byte code at
> compile time, which may not be what you want if this value needs to change in
> the future. If this n
On Tue, 4 Apr 2023 16:07:54 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalua
On Fri, 7 Apr 2023 07:42:51 GMT, Alan Bateman wrote:
> > What I meant was: You define PPCLE. PPCLE specifies ppc, little endian. We
> > also have PPC big-endian, it is used by AIX (and you can also run Linux
> > with PPC big-endian). Why omit that?
> > os.arch for AIX is "ppc64".
>
> So I thin
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote:
> Please help review this PR which suggests we remove the class
> `java.lang.Compiler`. The class seems non-functional for a decade, and was
> terminally deprecated in Java 9. Time has come to let it go.
Hello Eirik, I'll run this against
On Mon, 3 Apr 2023 17:16:26 GMT, Andrey Turbanov wrote:
> `LinkedHashMap` `ZipFileSystem.inodes` contains only
> non-null values. It means instead of separate `containsKey`+`get` calls, we
> can use single `LinkedHashMap.get` call and then compare result with `null`.
> Result code is a bit simp
On Thu, 6 Apr 2023 19:25:19 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Wed, 15 Mar 2023 11:26:21 GMT, Eirik Bjorsnos wrote:
> By avoiding a bit shift operation for the latin1 fast-path test, we can speed
> up the `java.lang.CharacterData.of` method by ~25% for latin1 code points.
>
> The latin1 test is currently implemented as `ch >>> 8 == 0`. We can replace
On Wed, 15 Mar 2023 14:31:03 GMT, Eirik Bjorsnos wrote:
>> By avoiding a bit shift operation for the latin1 fast-path test, we can
>> speed up the `java.lang.CharacterData.of` method by ~25% for latin1 code
>> points.
>>
>> The latin1 test is currently implemented as `ch >>> 8 == 0`. We can r
On Fri, 7 Apr 2023 07:38:31 GMT, Jaikiran Pai wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits si
On Thu, 9 Mar 2023 19:49:29 GMT, Eamonn McManus wrote:
> Instant.ofEpochMilli says this:
>
>
> @throws DateTimeException if the instant exceeds the maximum or minimum
> instant
>
>
> But that can't happen. Even given `Long.MIN_VALUE` or `Long.MAX_VALUE` it
> does not throw. That's already i
On Fri, 7 Apr 2023 07:43:02 GMT, Jaikiran Pai wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits si
On Fri, 7 Apr 2023 07:44:39 GMT, Jaikiran Pai wrote:
>> test/jdk/java/lang/Thread/java.base/jdk/internal/event/ThreadSleepEvent.java
>> line 29:
>>
>>> 27: * ThreadSleepEvent to optionally throw OOME at create, begin or commit
>>> time.
>>> 28: */
>>> 29: public class ThreadSleepEvent {
>>
On Wed, 5 Apr 2023 15:48:02 GMT, Roger Riggs wrote:
>> With the addition of `jdk.internal.util.OperatingSystem` references to the
>> system property `os.name` can be replaced.
>> This PR exports jdk.internal.util to:
>> - java.prefs,
>> - java.security.jgss,
>> - java.smartcardio,
>> - jdk.c
On Fri, 7 Apr 2023 07:32:02 GMT, ExE Boss wrote:
>> Thanks for this enhancement proposal. I hope you do not mind me asking if
>> you could file a separate issue about this where you describe the above? We
>> can then merge that proposal independent of this PR.
>
> I don’t (yet) have a **JBS** a
On Thu, 6 Apr 2023 15:49:27 GMT, Alan Bateman wrote:
>> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
>> APIs that were preview APIs in Java 19/20 are changed to permanent and their
>> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
>>
On Fri, 7 Apr 2023 07:25:59 GMT, Jaikiran Pai wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits si
On Thu, 6 Apr 2023 07:32:12 GMT, Alan Bateman wrote:
> One additional thing we could do is update the usage output for
> -i/--generate-index to say that the option is deprecated. Looking at `jdeps
> -help` output to see this for the deprecated -P/--profile option.
Implemented as suggested. The
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation class is moved into `jdk.jartool` module.
> - The `Invalid
On Fri, 7 Apr 2023 06:33:08 GMT, Thomas Stuefe wrote:
> What I meant was: You define PPCLE. PPCLE specifies ppc, little endian. We
> also have PPC big-endian, it is used by AIX (and you can also run Linux with
> PPC big-endian). Why omit that?
>
> os.arch for AIX is "ppc64".
So I think you ar
On Thu, 6 Apr 2023 15:49:27 GMT, Alan Bateman wrote:
>> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
>> APIs that were preview APIs in Java 19/20 are changed to permanent and their
>> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
>>
On Tue, 28 Mar 2023 10:00:28 GMT, Per Minborg wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/SharedUtils.java line
>> 297:
>>
>>> 295: MethodType mtype = mh.type();
>>> 296: int[] perms = new int[mtype.parameterCount()];
>>> 297: MethodType swappedType =
On Thu, 6 Apr 2023 22:36:33 GMT, Archie L. Cobbs wrote:
> IO stream classes like `FileOutputStream` can have assocated NIO channels.
>
> When `close()` is invoked on one of these classes, it in turn invokes
> `close()` on the associated channel (if any). But when the associated
> channel's `cl
On Thu, 6 Apr 2023 15:49:27 GMT, Alan Bateman wrote:
>> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
>> APIs that were preview APIs in Java 19/20 are changed to permanent and their
>> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
>>
On Fri, 7 Apr 2023 06:56:51 GMT, Jaikiran Pai wrote:
> In a JDK image that's built out of this PR, does the missing `@JEP`
> annotation on this enum value cause issues in javadoc image generation or
> presentation on that page?
This has been looked at a few times and we didn't find any issues.
On Thu, 6 Apr 2023 15:49:27 GMT, Alan Bateman wrote:
>> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
>> APIs that were preview APIs in Java 19/20 are changed to permanent and their
>> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
>>
On Thu, 6 Apr 2023 15:49:27 GMT, Alan Bateman wrote:
>> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
>> APIs that were preview APIs in Java 19/20 are changed to permanent and their
>> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
>>
70 matches
Mail list logo
