On Fri, 7 Apr 2023 07:44:39 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> test/jdk/java/lang/Thread/java.base/jdk/internal/event/ThreadSleepEvent.java
>> line 29:
>>
>>> 27: * ThreadSleepEvent to optionally throw OOME at create, begin or commit
>>> time.
>>> 28: */
>>> 29: public class ThreadSleepEvent {
>>
>> Should this extend `jdk.internal.event.Event` and then have each of the
>> methods have a `@Override` on them? Or would that cause some issue when this
>> is used in a jtreg test in the `@compile` directive?
>
> Same comment for the newly introduced
> `test/jdk/java/lang/Thread/virtual/java.base/jdk/internal/event/VirtualThreadPinnedEvent.java`
> Should this extend `jdk.internal.event.Event` and then have each of the
> methods have a `@Override` on them? Or would that cause some issue when this
> is used in a jtreg test in the `@compile` directive?
Okay, we can do that do as it might be cleaner for something changing these
tests in the future and help to find issues quickly in the event that the
internal infrastructure for JFR events in java.base changes in the future.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13203#discussion_r1160543904
