On Fri, 7 Apr 2023 07:25:59 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits since the last revision: >> >> - Test/comments updates >> - Merge >> - Expand tests for jdk.ThreadSleep event >> - Review feedback >> - Merge >> - Fix ThreadSleepEvent again >> - Test updates >> - ThreadSleepEvent refactoring >> - Merge >> - Merge >> - ... and 1 more: https://git.openjdk.org/jdk/compare/97c49893...a5bb3fd9 > > test/jdk/java/lang/Thread/java.base/jdk/internal/event/ThreadSleepEvent.java > line 29: > >> 27: * ThreadSleepEvent to optionally throw OOME at create, begin or commit >> time. >> 28: */ >> 29: public class ThreadSleepEvent { > > Should this extend `jdk.internal.event.Event` and then have each of the > methods have a `@Override` on them? Or would that cause some issue when this > is used in a jtreg test in the `@compile` directive? Same comment for the newly introduced `test/jdk/java/lang/Thread/virtual/java.base/jdk/internal/event/VirtualThreadPinnedEvent.java` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13203#discussion_r1160511761
