On Tue, 28 Mar 2023 04:46:52 GMT, Mandy Chung wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - don't iterate over the properties file keys and instead do lookup when
>> needed
>> - update CDSPluginTest to correc
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>
> The `jlink` command allows a `--endian` option to specify the byte order in
> the generated image. Before this change, when such a image was being
> launche
On Tue, 28 Mar 2023 02:23:05 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Mon, 27 Mar 2023 09:40:22 GMT, Severin Gehwolf wrote:
>> Please review this change for symbol visibility of static library artefacts.
>> This fixes an issue when
>> OpenJDK is being used as a base for generating native images preventing the
>> symbols from being
>> exported and looked up fro
> PR for Sequenced Collections implementation.
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Simplify handling of cached keySet, values, and entrySet views.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/7387/fil
On Mon, 27 Mar 2023 11:07:34 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>
> The `jlink` command allows a `--endian` option to specify the byte order in
> the generated image. Before this change, when such a image was being
> launche
On Mon, 27 Mar 2023 16:41:09 GMT, Mandy Chung wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - update the property key names in target.properties to use ".endianness"
>> suffix
>> - remove @since 21 on internal
On Fri, 24 Mar 2023 21:35:22 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 78 commits:
>>
>> - Merge branch 'master' into JDK-8266571-SequencedCollections
>> - Update copyrights.
>>
On Fri, 24 Mar 2023 21:28:18 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 78 commits:
>>
>> - Merge branch 'master' into JDK-8266571-SequencedCollections
>> - Update copyrights.
>>
On Sat, 25 Mar 2023 08:19:18 GMT, Rémi Forax wrote:
>> Stuart Marks has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - More specification tweaks.
>> - Add simple overrides to ArrayList.
>
> This change is absolutely massive, implementing
> PR for Sequenced Collections implementation.
Stuart Marks has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 78 commits:
- Merge branch 'master' into JDK-8266571-SequencedCollections
- Update copyrights.
- More specification tweaks.
As John Rose has pointed out in this issue, the current j.l.r.Proxy based
implementation of MethodHandleProxies.asInterface has a few issues:
1. Exposes too much information via Proxy supertype (and WrapperInstance
interface)
2. Does not allow future expansion to support SAM[^1] abstract classes
On Fri, 24 Mar 2023 18:48:41 GMT, Justin Lu wrote:
>> This PR fixes the bug which occurred when `Calendar.roll(WEEK_OF_YEAR)`
>> rolled into a minimal first week with an invalid `WEEK_OF_YEAR` and
>> `DAY_OF_WEEK` combo.
>>
>> For example, Rolling _Monday, 30 December 2019_ by 1 week produced
On Thu, 23 Mar 2023 09:10:26 GMT, Serguei Spitsyn wrote:
> The fix was suggested/provided by @AlanBateman.
> Continuation should use Unsafe.compareAndSetReference rather than a VH here.
> We had to change CHM and VT back to Unsafe for similar reasons.
>
> Testing: Mach5 runs of tiers 1-6 are in
On Thu, 23 Mar 2023 09:10:26 GMT, Serguei Spitsyn wrote:
> The fix was suggested/provided by @AlanBateman.
> Continuation should use Unsafe.compareAndSetReference rather than a VH here.
> We had to change CHM and VT back to Unsafe for similar reasons.
>
> Testing: Mach5 runs of tiers 1-6 are in
On Fri, 17 Mar 2023 18:22:17 GMT, Justin Lu wrote:
> This PR updates the javadoc of `java.util.Calendar.getDisplayName()` and
> `java.util.Calendar.getDisplayNames()` to better reflect the actual behavior
> when the calendar is non-lenient.
>
> This involves updating the spec of both methods t
On Thu, 23 Mar 2023 19:07:05 GMT, Justin Lu wrote:
> Update IANA LSR to 2023-03-22
> [update](https://mm.icann.org/pipermail/ietf-languages-announcements/2023-March/85.html).
> Add all new preferred languages to `ACCEPT_LANGUAGES` except `gu`.
This pull request has now been integrated.
Ch
> This implements a shared utility to dump generated classes defined as
> normal/hidden classes via `Lookup` API. This replaces the implementation in
> `LambdaMetaFactory` and method handle implementation that dumps the hidden
> class bytes on disk for debugging.
>
> For classes defined vi
Hi Chris,
SapMachine has all the ea builds in its GitHub Repo:
https://github.com/SAP/SapMachine/releases. Should be fine enough for chasing
G1 GC behaviour changes.
Cheers
Christoph
> -Original Message-
> From: core-libs-dev On Behalf Of Chris
> Hegarty
> Sent: Freitag, 24. März 2023
On Fri, 24 Mar 2023 23:00:12 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Use Arrays.fill
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12728
On Tue, 14 Mar 2023 10:14:44 GMT, Claes Redestad wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Expand test for StringBuffer and illegal code points
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.ja
On Fri, 24 Mar 2023 23:00:12 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
Jim Laskey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request co
On Fri, 24 Mar 2023 23:00:12 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote:
> Improvements to support OS specific customization for JDK internal use:
> - To select values and code; allowing elimination of unused code and values
> - Optionally evaluated by build processes, compilation, or archiving (i.e.
> CDS)
> - S
> Improvements to support OS specific customization for JDK internal use:
> - To select values and code; allowing elimination of unused code and values
> - Optionally evaluated by build processes, compilation, or archiving (i.e.
> CDS)
> - Simple API to replace adhoc comparisons with `os.name`
On Sun, 26 Mar 2023 18:41:12 GMT, Brian Goetz wrote:
> Since LMF goes through Lookup::defineHiddenClass, does this mean that they
> will be potentially dumped twice, once through Lookup, and once through LMF?
No, only once. The old dumping code in LMF is removed.
> Now that there is a shared
On Tue, 21 Mar 2023 06:11:57 GMT, Joe Darcy wrote:
> Last but not least, a port of fdlibm IEEEremainder from C to Java. I plan to
> write some more implementation-specific tests around decision points in the
> FDLIBM algorithm, but I wanted to get the bulk of the changes out for review
> first
On Mon, 27 Mar 2023 11:07:34 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Mon, 27 Mar 2023 15:07:42 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
>> line 256:
>>
>>> 254:
>>> 255: private Frame getFrame(int offset) {
>>> 256: for (var f : frames) {
>>
>> How large is the frames list expected
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
> and this patch converts it to use Classfile API.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
StackMapGene
On Fri, 17 Feb 2023 09:50:16 GMT, Sergey Tsypanov wrote:
> 1) When `DateTimeFormatter` is reused we don't need to copy
> `availableZoneIds` and allocate `nonRegionIds` as PrefixTree can be taken
> from cache. In the related benchmark allocation of `HashSet` takes ~93% of
> all time, so avoidin
1) When `DateTimeFormatter` is reused we don't need to copy `availableZoneIds`
and allocate `nonRegionIds` as PrefixTree can be taken from cache. In the
related benchmark allocation of `HashSet` takes ~93% of all time, so avoiding
it should bring some improvement for cases when we reuse `DateTim
On Sat, 25 Mar 2023 05:52:44 GMT, Chen Liang wrote:
> In `AnnotatedTypeBaseImpl`, a `decl` field is declared, referring to the
> declaration that the AnnotatedType is from. However, this field is not used
> anywhere except passing to constructors of other implementations; it's not
> used in de
> By default `BufferedInputStream` is constructed with internal buffer with
> capacity 8192. In some cases this buffer is never used, e.g. when we call
> `IS.readNBytes()` or `IS.readAllBytes()` (relying on `BIS.read1()`) or when
> `BufferedInputStream` is cascaded.
Sergey Tsypanov has updated
On Fri, 24 Mar 2023 19:30:22 GMT, Sergey Tsypanov wrote:
>> By default `BufferedInputStream` is constructed with internal buffer with
>> capacity 8192. In some cases this buffer is never used, e.g. when we call
>> `IS.readNBytes()` or `IS.readAllBytes()` (relying on `BIS.read1()`) or when
>> `
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
On Mon, 27 Mar 2023 16:00:00 GMT, Roger Riggs wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>> CDS)
>
> Improvements to support OS specific customization for JDK internal use:
> - To select values and code; allowing elimination of unused code and values
> - Optionally evaluated by build processes, compilation, or archiving (i.e.
> CDS)
> - Simple API to replace adhoc comparisons with `os.name`
On Thu, 23 Mar 2023 16:47:08 GMT, Jorn Vernee wrote:
> Linkers are strongly tied to a particular byte order, because they are tied
> to a particular platform. So, the linker should reject layouts that have
> another byte order. This patch implements that check.
> > > The code changes look good
On Wed, 22 Mar 2023 18:38:08 GMT, Jan Lahoda wrote:
>> If JShell is run on a system that does not have `/bin/test` (which is,
>> apparently, possible for some systems, which only have `/usr/bin/test`), it
>> won't switch the terminal into the raw mode, and the input will not work
>> properly.
On Mon, 27 Mar 2023 15:09:57 GMT, Jorn Vernee wrote:
> > The code changes look good, but the javadoc should be updated to reflect
> > the new constraints.
>
> We currently have this:
>
> ```
> @throws IllegalArgumentException if the provided function descriptor is not
> supported by this link
On Fri, 24 Mar 2023 10:27:45 GMT, Alan Bateman wrote:
> Can you try the patch below instead? This will ensure that read, skip, reset,
> etc. check buf as before.
I think that the implementation provided by @AlanBateman looks good.
-
PR Comment: https://git.openjdk.org/jdk/pull/131
On Mon, 27 Mar 2023 14:44:10 GMT, Maurizio Cimadamore
wrote:
> The code changes look good, but the javadoc should be updated to reflect the
> new constraints.
We currently have this:
@throws IllegalArgumentException if the provided function descriptor is not
supported by this linker.
Wh
On Mon, 27 Mar 2023 13:17:35 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> SplitConstantPool performance improvement
>
> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.ja
On Thu, 23 Mar 2023 16:47:08 GMT, Jorn Vernee wrote:
> Linkers are strongly tied to a particular byte order, because they are tied
> to a particular platform. So, the linker should reject layouts that have
> another byte order. This patch implements that check.
The code changes look good, but
On Thu, 23 Mar 2023 18:11:18 GMT, Jorn Vernee wrote:
> This patch adds checks in AbstractLinker to reject packed structs and structs
> with excess padding (e.g. unnamed bitfields), since both of those are
> currently not supported, and the ABI/spec seems too vague to base support on.
src/java.
On Thu, 23 Mar 2023 09:10:26 GMT, Serguei Spitsyn wrote:
> The fix was suggested/provided by @AlanBateman.
> Continuation should use Unsafe.compareAndSetReference rather than a VH here.
> We had to change CHM and VT back to Unsafe for similar reasons.
>
> Testing: Mach5 runs of tiers 1-6 are in
On Mon, 27 Mar 2023 14:31:14 GMT, Andrey Turbanov wrote:
>> https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/action/GetPropertyAction.java#L104
>
> But it's not a deprecation of the method/class. It just suppression of the
> warning.
> `GetPropertyAction.privil
On Mon, 27 Mar 2023 14:19:04 GMT, Daniel Fuchs wrote:
>> As I can see it uses deprecated `SecurityManager`, but it's not deprecated
>> itself.
>> Do I miss something? Or javac generates warning even in such cases?
>
> https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/sec
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with
> proper privileges, with tests.
>
> This addition is useful in case classes at runtime are not loaded from the
> system class loader, such as Proxy. This is also useful to APIs that generate
> bytecode with a `Lookup`
On Mon, 27 Mar 2023 14:16:12 GMT, Andrey Turbanov wrote:
>> As I can see it uses deprecated `SecurityManager`, but it's not deprecated
>> itself.
>> Do I miss something? Or javac generates warning even in such cases?
>
> As I can see it uses deprecated `SecurityManager`, but it's not deprecated
On Mon, 27 Mar 2023 13:26:22 GMT, Daniel Fuchs wrote:
>> src/java.base/unix/classes/java/lang/ProcessImpl.java line 97:
>>
>>> 95: * @throw Error if the requested launch mechanism is not found or
>>> valid
>>> 96: */
>>> 97: @SuppressWarnings("removal")
>>
>> What is deprecated f
On Mon, 27 Mar 2023 14:15:59 GMT, Andrey Turbanov wrote:
>> `GetPropertyAction::privilegedGetProperty` has been marked deprecated for
>> removal because it uses the SecurityManager
>
> As I can see it uses deprecated `SecurityManager`, but it's not deprecated
> itself.
> Do I miss something? Or
This patch adds checks in AbstractLinker to reject packed structs and structs
with excess padding (e.g. unnamed bitfields), since both of those are currently
not supported, and the ABI/spec seems too vague to base support on.
-
Depends on: https://git.openjdk.org/jdk/pull/13161
Com
On Mon, 27 Mar 2023 13:04:28 GMT, Erik Joelsson wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Explicitly set the JNI_EXPORT define for static libs
>
> Marked as reviewed by erikj (Reviewer).
Thanks for the re
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with
> proper privileges, with tests.
>
> This addition is useful in case classes at runtime are not loaded from the
> system class loader, such as Proxy. This is also useful to APIs that generate
> bytecode with a `Lookup`
On Thu, 23 Mar 2023 16:47:08 GMT, Jorn Vernee wrote:
> Linkers are strongly tied to a particular byte order, because they are tied
> to a particular platform. So, the linker should reject layouts that have
> another byte order. This patch implements that check.
src/java.base/share/classes/jdk/
On Mon, 27 Mar 2023 09:26:03 GMT, Andrey Turbanov wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clarify Linux
>
> src/java.base/unix/classes/java/lang/ProcessImpl.java line 97:
>
>> 95: * @throw Error if the
On Fri, 24 Mar 2023 08:02:05 GMT, ExE Boss wrote:
>> Linkers are strongly tied to a particular byte order, because they are tied
>> to a particular platform. So, the linker should reject layouts that have
>> another byte order. This patch implements that check.
>
> src/java.base/share/classes/j
Linkers are strongly tied to a particular byte order, because they are tied to
a particular platform. So, the linker should reject layouts that have another
byte order. This patch implements that check.
-
Depends on: https://git.openjdk.org/jdk/pull/13079
Commit messages:
- Check
On Mon, 27 Mar 2023 11:26:15 GMT, Adam Sotona wrote:
>> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy
>> classes and this patch converts it to use Classfile API.
>>
>> Please review.
>>
>> Thank you,
>> Adam
>
> Adam Sotona has updated the pull request incrementally wit
On Mon, 27 Mar 2023 09:40:22 GMT, Severin Gehwolf wrote:
>> Please review this change for symbol visibility of static library artefacts.
>> This fixes an issue when
>> OpenJDK is being used as a base for generating native images preventing the
>> symbols from being
>> exported and looked up fro
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
> and this patch converts it to use Classfile API.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
SplitConstan
On Fri, 24 Mar 2023 16:52:10 GMT, Mandy Chung wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line 49:
>>
>>> 47: throw new ExceptionInInitializerError(e);
>>> 48: }
>>> 49: KNOWN_ENDIANNESS = p;
>>
>> The naming/usage suggests the value
On Fri, 24 Mar 2023 16:40:55 GMT, Mandy Chung wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 28 commits:
>>
>> - merge latest from master branch
>> - Mandy's suggested patch improvements
>> - ARM is 32 b
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>
> The `jlink` command allows a `--endian` option to specify the byte order in
> the generated image. Before this change, when such a image was being
> launche
On Tue, 21 Mar 2023 06:11:57 GMT, Joe Darcy wrote:
> Last but not least, a port of fdlibm IEEEremainder from C to Java. I plan to
> write some more implementation-specific tests around decision points in the
> FDLIBM algorithm, but I wanted to get the bulk of the changes out for review
> first
> Please review this change for symbol visibility of static library artefacts.
> This fixes an issue when
> OpenJDK is being used as a base for generating native images preventing the
> symbols from being
> exported and looked up from the executable. Note that symbol visibity is now
> controlled
On Mon, 27 Mar 2023 08:56:15 GMT, Severin Gehwolf wrote:
>> make/autoconf/flags-cflags.m4 line 639:
>>
>>> 637: STATIC_LIBS_CFLAGS="-DSTATIC_BUILD=1"
>>> 638: if test "x$TOOLCHAIN_TYPE" = xgcc || test "x$TOOLCHAIN_TYPE" =
>>> xclang; then
>>> 639: STATIC_LIBS_CFLAGS="$STATIC_LIBS_CFLAGS
On Fri, 24 Mar 2023 17:06:45 GMT, Roger Riggs wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>> CDS)
>
On Mon, 27 Mar 2023 05:23:26 GMT, David Holmes wrote:
>> Please review this change for symbol visibility of static library artefacts.
>> This fixes an issue when
>> OpenJDK is being used as a base for generating native images preventing the
>> symbols from being
>> exported and looked up from t
On Wed, 22 Mar 2023 17:46:37 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 201 commits:
>>
>> - Merge branch 'master' into JDK-8294961
>>
>># Conflicts:
>># src/java.base/share/
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
> and this patch converts it to use Classfile API.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
cleanup of N
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
> and this patch converts it to use Classfile API.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Apply sugges
77 matches
Mail list logo
