On Fri, 24 Mar 2023 16:40:55 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 28 commits: >> >> - merge latest from master branch >> - Mandy's suggested patch improvements >> - ARM is 32 bit as per platform.m4 in OpenJDK build >> - when --endian is specified, verify it matches the implicitly determined >> target platform's endianness >> - trim down the architecture support to the previous values plus a few new >> that match target.properties >> - improve error messages as suggested by Mandy >> - formatting fix >> - Alan's suggestions - don't parse arch out of osname-arch for determining >> endianness and reduce the number of supported/known target platforms for >> cross linking >> - Mandy's suggestion - pass along target platform to the >> DefaultImageBuilder to prevent reparsing the value from the ModuleTarget >> - Mandy's suggestion to use Platform class for additional arch support. >> Plus, Jim's suggestion to use a runtime resource for endianness mapping >> - ... and 18 more: https://git.openjdk.org/jdk/compare/ac6af6a6...6f4ab9c6 > > src/jdk.jlink/share/classes/jdk/tools/jlink/builder/DefaultImageBuilder.java > line 168: > >> 166: * @throws IOException >> 167: * @throws NullPointerException If any of the params is null >> 168: * @since 21 > > you can drop this as this is not a public API. Removed in latest update of the PR. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/11943#discussion_r1149148648
