On Mon, 27 Mar 2023 11:26:15 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy
>> classes and this patch converts it to use Classfile API.
>>
>> Please review.
>>
>> Thank you,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional
> commit since the last revision:
>
> SplitConstantPool performance improvement
src/java.base/share/classes/java/lang/constant/MethodTypeDescImpl.java line 79:
> 77: paramTypes[i] = ClassDesc.ofDescriptor(types.get(i + 1));
> 78: }
> 79: return new MethodTypeDescImpl(ret, paramTypes);
I have an alternative implementation in #13186 which somewhat speeds up for
no-arg method types too; the code there no longer copies the parameter arrays
on `parameterList()` calls, might help too (as a few places in Classfile API
uses MethodTypeDesc.parameterList())
src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
line 256:
> 254:
> 255: private Frame getFrame(int offset) {
> 256: for (var f : frames) {
How large is the frames list expected to be? We can probably perform binary
searches if the list is too large.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/10991#discussion_r1149225345
PR Review Comment: https://git.openjdk.org/jdk/pull/10991#discussion_r1149225218
