Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]

2022-10-14 Thread Alan Bateman
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote: >> 8290313: Produce warning when user specified java.io.tmpdir directory >> doesn't exist > > Weibing Xiao has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 11 commits: > > - Me

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-14 Thread Jaikiran Pai
On Thu, 13 Oct 2022 19:34:52 GMT, Aleksei Efimov wrote: >> src/java.base/share/conf/security/java.security line 1423: >> >>> 1421: # >>> 1422: # The default pattern value allows any object factory class defined >>> in the java.naming module >>> 1423: # to be specified by the reference instance,

Integrated: 8295370: Update java.io.ObjectStreamField to use Class.descriptorString

2022-10-14 Thread Roger Riggs
On Fri, 14 Oct 2022 18:23:58 GMT, Roger Riggs wrote: > The code in ObjectStreamField for constructing type signatures should be > replaced by Class.descriptorString(). > The corresponding change is made in ObjectStreamClass. > There is no change to the contents of the type strings and the exist

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v3]

2022-10-14 Thread Oliver Kopp
On Fri, 14 Oct 2022 16:07:44 GMT, Alan Bateman wrote: >> Oliver Kopp has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reduce number of included ModuleDescriptors > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModul

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v2]

2022-10-14 Thread Oliver Kopp
On Fri, 14 Oct 2022 12:25:43 GMT, Alan Bateman wrote: > Can you look at the tests in test/jdk/tools/jlink, that is where we will need > to add the test for this. I looked and started to create some Java files at [`7c39bd3` (#10704)](https://github.com/openjdk/jdk/pull/10704/commits/7c39bd3ec82

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v4]

2022-10-14 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods Oli

Re: RFR: 8295370: Update java.io.ObjectStreamField to use Class.descriptorString

2022-10-14 Thread Brian Burkhalter
On Fri, 14 Oct 2022 18:23:58 GMT, Roger Riggs wrote: > The code in ObjectStreamField for constructing type signatures should be > replaced by Class.descriptorString(). > The corresponding change is made in ObjectStreamClass. > There is no change to the contents of the type strings and the exist

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]

2022-10-14 Thread Roger Riggs
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote: >> 8290313: Produce warning when user specified java.io.tmpdir directory >> doesn't exist > > Weibing Xiao has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 11 commits: > > - Me

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]

2022-10-14 Thread Weibing Xiao
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote: >> 8290313: Produce warning when user specified java.io.tmpdir directory >> doesn't exist > > Weibing Xiao has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 11 commits: > > - Me

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]

2022-10-14 Thread Weibing Xiao
> 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist Weibing Xiao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge branch 'master' into improve-directory-not-existing-error-messa

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v3]

2022-10-14 Thread Weibing Xiao
> 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist Weibing Xiao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10

Re: RFR: 8295370: Update java.io.ObjectStreamField to use Class.descriptorString

2022-10-14 Thread Mandy Chung
On Fri, 14 Oct 2022 18:23:58 GMT, Roger Riggs wrote: > The code in ObjectStreamField for constructing type signatures should be > replaced by Class.descriptorString(). > The corresponding change is made in ObjectStreamClass. > There is no change to the contents of the type strings and the exist

Re: RFR: 8293630: Simplify TreeMap.get() with Comparator.naturalOrder() [v3]

2022-10-14 Thread Сергей Цыпанов
> We can use `Comparator.naturalOrder()` for cases when a `TreeMap` instance is > constructed without comparator. This allows to squash two branches in > `TreeMap.get()` into one. > > P.S. I think the comment of `TreeMap.getEntryUsingComparator()` is outdated. > Should we also change it? Серге

Re: RFR: 8295370: Update java.io.ObjectStreamField to use Class.descriptorString

2022-10-14 Thread Brian Burkhalter
On Fri, 14 Oct 2022 18:23:58 GMT, Roger Riggs wrote: > The code in ObjectStreamField for constructing type signatures should be > replaced by Class.descriptorString(). > The corresponding change is made in ObjectStreamClass. > There is no change to the contents of the type strings and the exist

RFR: 8295370: Update java.io.ObjectStreamField to use Class.descriptorString

2022-10-14 Thread Roger Riggs
The code in ObjectStreamField for constructing type signatures should be replaced by Class.descriptorString(). The corresponding change is made in ObjectStreamClass. There is no change to the contents of the type strings and the existing tests will cover it. - Commit messages: - 8

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v5]

2022-10-14 Thread Roger Riggs
On Fri, 14 Oct 2022 17:27:34 GMT, Aleksei Efimov wrote: >> src/java.base/share/conf/security/java.security line 1388: >> >>> 1386: # are unused. >>> 1387: # >>> 1388: # Each class name pattern is matched against the factory class name >>> to allow or disallow its >> >> It appears that for thos

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v5]

2022-10-14 Thread Aleksei Efimov
On Fri, 14 Oct 2022 16:35:28 GMT, Daniel Fuchs wrote: >> Aleksei Efimov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains ten additional >> commit

Re: RFR: 8295302: Do not use ArrayList when LambdaForm has a single ClassData [v2]

2022-10-14 Thread Mandy Chung
On Fri, 14 Oct 2022 16:57:47 GMT, Mandy Chung wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @iwanowww comments > > src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java > line 291: > >> 289:

Re: RFR: 8295302: Do not use ArrayList when LambdaForm has a single ClassData [v2]

2022-10-14 Thread Mandy Chung
On Fri, 14 Oct 2022 04:37:22 GMT, Ioi Lam wrote: >> Please review this small optimization. As shown in the JBS issue, most of >> the generated LambdaForm classes have a single ClassData, so we can get a >> small footprint/speed improvement. > > Ioi Lam has updated the pull request incrementally

Re: RFR: JDK-8295325: tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux ppc64le

2022-10-14 Thread Mandy Chung
On Fri, 14 Oct 2022 11:16:50 GMT, Matthias Baesken wrote: > The test tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux > ppc64le because it assumes that vm.jvmci is > available on all platforms but this is currently not the case on Linux > ppc64le. > Error is : > > Error: Mod

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v5]

2022-10-14 Thread Daniel Fuchs
On Fri, 14 Oct 2022 16:19:41 GMT, Aleksei Efimov wrote: >> ### Summary of the change >> This change introduces new system and security properties for specifying >> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider >> implementations. >> >> These new properties allow more granula

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v5]

2022-10-14 Thread Aleksei Efimov
> ### Summary of the change > This change introduces new system and security properties for specifying > factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider > implementations. > > These new properties allow more granular control over the set of object > factories allowed to reconst

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v3]

2022-10-14 Thread Alan Bateman
On Fri, 14 Oct 2022 16:02:21 GMT, Oliver Kopp wrote: >> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): >> "MethodTooLargeException thrown while creating a jlink image". >> >> Java still has a 64kb limit: A method may not be longer than 64kb. The idea >> of the fix is to sp

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v3]

2022-10-14 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods Oli

Re: RFR: JDK-8295325: tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux ppc64le

2022-10-14 Thread Martin Doerr
On Fri, 14 Oct 2022 11:16:50 GMT, Matthias Baesken wrote: > The test tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux > ppc64le because it assumes that vm.jvmci is > available on all platforms but this is currently not the case on Linux > ppc64le. > Error is : > > Error: Mod

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion

2022-10-14 Thread Bill Huang
On Fri, 14 Oct 2022 11:00:44 GMT, Mahendra Chhipa wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> j

RFR: 8292033: Move jdk.X509Certificate event logic to JCA layer

2022-10-14 Thread Sean Coffey
By moving the JFR event up to the java.security.cert.CertificateFactory class, we can record all generate cert events, including those from 3rd party providers. I've also altered the logic so that an event is genertate for every generate cert call (not just ones missing from the JDK provider imp

Confusing exception message in MethodHandles#tableSwitch

2022-10-14 Thread Hannes Greule
Hi, I hope this is the right mailing list. I recently fiddled around with MethodHandles#tableSwitch and stumbled across a confusing exception message. As a simple example, consider following code: import java.lang.invoke.*; import static java.lang.invoke.MethodType.*; import static java.lang.

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v2]

2022-10-14 Thread Alan Bateman
On Fri, 14 Oct 2022 12:22:16 GMT, Oliver Kopp wrote: >> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): >> "MethodTooLargeException thrown while creating a jlink image". >> >> Java still has a 64kb limit: A method may not be longer than 64kb. The idea >> of the fix is to sp

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v2]

2022-10-14 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods Oli

Re: RFR: 8293630: Simplify TreeMap.get() with Comparator.naturalOrder() [v2]

2022-10-14 Thread ExE Boss
On Fri, 14 Oct 2022 08:53:24 GMT, Сергей Цыпанов wrote: >> We can use `Comparator.naturalOrder()` for cases when a `TreeMap` instance >> is constructed without comparator. This allows to squash two branches in >> `TreeMap.get()` into one. >> >> P.S. I think the comment of `TreeMap.getEntryUsin

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion

2022-10-14 Thread Mahendra Chhipa
On Mon, 10 Oct 2022 21:39:05 GMT, Bill Huang wrote: > This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/securit

Re: RFR: JDK-8295325: tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux ppc64le

2022-10-14 Thread Alan Bateman
On Fri, 14 Oct 2022 11:16:50 GMT, Matthias Baesken wrote: > The test tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux > ppc64le because it assumes that vm.jvmci is > available on all platforms but this is currently not the case on Linux > ppc64le. > Error is : > > Error: Mod

RFR: JDK-8295325: tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux ppc64le

2022-10-14 Thread Matthias Baesken
The test tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux ppc64le because it assumes that vm.jvmci is available on all platforms but this is currently not the case on Linux ppc64le. Error is : Error: Module jdk.internal.vm.ci not found java.lang.module.FindException: Module jdk

Re: RFR: 8293630: Simplify TreeMap.get() with Comparator.naturalOrder() [v2]

2022-10-14 Thread Сергей Цыпанов
On Thu, 13 Oct 2022 21:46:15 GMT, ExE Boss wrote: >> Nope, there'd be a compilation error > > It'll work fine if an unchecked cast is used: > Suggestion: > > @SuppressWarnings("unchecked") > Comparator> entryComparator = treeComparator == > null ? > (

Re: RFR: 8293630: Simplify TreeMap.get() with Comparator.naturalOrder() [v2]

2022-10-14 Thread Сергей Цыпанов
> We can use `Comparator.naturalOrder()` for cases when a `TreeMap` instance is > constructed without comparator. This allows to squash two branches in > `TreeMap.get()` into one. > > P.S. I think the comment of `TreeMap.getEntryUsingComparator()` is outdated. > Should we also change it? Серге

Re: New candidate JEP: 431: Sequenced Collections

2022-10-14 Thread Remi Forax
- Original Message - > From: "mark reinhold" > To: "Stuart Marks" > Cc: "core-libs-dev" , "jdk-dev" > > Sent: Wednesday, October 12, 2022 1:17:20 AM > Subject: New candidate JEP: 431: Sequenced Collections > https://openjdk.org/jeps/431 > > Summary: Introduce new interfaces to repres