On Tue, 20 Sep 2022 10:37:41 GMT, David Holmes wrote:
>> This update is primarily about changes to the JNI Invocation API
>> specification, mainly in relation to `DestroyJavaVM`. The motivation for the
>> changes is to align with changes being made to the JLS, JVMS and
>> `java.lang.Runtime`,
On Wed, 14 Sep 2022 10:47:18 GMT, Jaikiran Pai wrote:
>> Hi all,
>>
>> runtime/Dictionary/ProtectionDomainCacheTest.java fails on Linux if `/tmp`
>> is a symbolic link directory.
>> The root cause is that `JarUtils.createJarFile` [1] will throw
>> `FileAlreadyExistsException` if `parent` is a
On Wed, 14 Sep 2022 09:42:37 GMT, Jie Fu wrote:
> Hi all,
>
> runtime/Dictionary/ProtectionDomainCacheTest.java fails on Linux if `/tmp` is
> a symbolic link directory.
> The root cause is that `JarUtils.createJarFile` [1] will throw
> `FileAlreadyExistsException` if `parent` is a symbolic dir
On Sat, 17 Sep 2022 08:41:19 GMT, Alan Bateman wrote:
>> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for
>> removal, and remove the remaining special handling of ThreadDeath from the
>> JDK.
>>
>> Thread.stop is inherently unsafe and has been deprecated since JDK 1.
Hi, yes, this is the right place to discuss Sequenced Collections. I'm glad you find
it promising.
Note that Sequenced Collections actually has very little implementation in it, aside
from various reversed views of things. The actual data is still stored in existing
concrete collections such a
On Wed, 21 Sep 2022 21:37:59 GMT, Roger Riggs wrote:
>> Clear the signal mask of the child when launching with posix_spawn.
>>
>> SIGQUIT signals are handled on non-Java Threads by the VM.
>> For Java threads the signal mask blocks SIGQUIT.
>> The ProcessBuilder uses posix_spawn on all platfor
On Wed, 21 Sep 2022 15:34:03 GMT, Ioi Lam wrote:
> Withdraw my approval per Alan's comment.
Okay.
Thanks @iklam and @AlanBateman .
-
PR: https://git.openjdk.org/jdk/pull/10266
On Sun, 18 Sep 2022 16:32:31 GMT, Alan Bateman wrote:
> Degrade Thread.suspend/resume to throw UOE unconditionally.
>
> Another step in the removal of this deadlock prone mis-feature from the
> user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2
> (1998) and terminally de
On Wed, 21 Sep 2022 21:37:59 GMT, Roger Riggs wrote:
>> Clear the signal mask of the child when launching with posix_spawn.
>>
>> SIGQUIT signals are handled on non-Java Threads by the VM.
>> For Java threads the signal mask blocks SIGQUIT.
>> The ProcessBuilder uses posix_spawn on all platfor
> Clear the signal mask of the child when launching with posix_spawn.
>
> SIGQUIT signals are handled on non-Java Threads by the VM.
> For Java threads the signal mask blocks SIGQUIT.
> The ProcessBuilder uses posix_spawn on all platforms to create new processes.
> Without a specific request, th
Thanks for filing this. This was (some time ago) moved into the main bug
database:
https://bugs.openjdk.org/browse/JDK-8292317
s'marks
On 8/12/22 7:05 AM, Rob Spoor wrote:
I found one similar issue, https://bugs.openjdk.org/browse/JDK-8015008, but that was
for an empty primitive iterator. I'v
On Wed, 21 Sep 2022 20:30:53 GMT, Roger Riggs wrote:
> Clear the signal mask of the child when launching with posix_spawn.
>
> SIGQUIT signals are handled on non-Java Threads by the VM.
> For Java threads the signal mask blocks SIGQUIT.
> The ProcessBuilder uses posix_spawn on all platforms to
Clear the signal mask of the child when launching with posix_spawn.
SIGQUIT signals are handled on non-Java Threads by the VM.
For Java threads the signal mask blocks SIGQUIT.
The ProcessBuilder uses posix_spawn on all platforms to create new processes.
Without a specific request, the child proc
On Wed, 21 Sep 2022 14:38:50 GMT, Matthias Baesken wrote:
>> We noticed that with certain jar file input, jdeps runs into the following
>> exception, this happens with jdk11, 17 and 20.
>>
>> jdeps.exe --multi-release 11 --module-path . --inverse --package
>> com.sap.nw.performance.supa.client
> Second attempt at resolving
> [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less
> intrusive approach this time
>
> Side note: While it might be preferred to remove this entirely, other areas
> of the JDK also use the same flawed logic, and removing this would simply
> p
On Tue, 20 Sep 2022 13:08:20 GMT, Adam Sotona wrote:
> Parsing performance of `j.l.c.MethodTypeDescriptor::ofDescriptor` can be
> significantly improved and add performance boost to intensive users.
>
> Two main reasons have been identified and fixed in this patch:
>
> First glitch is late ins
On Fri, 2 Sep 2022 00:52:49 GMT, Smita Kamath wrote:
>> 8289552: Make intrinsic conversions between bit representations of half
>> precision values and floats
>
> Smita Kamath has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed revie
On Tue, 20 Sep 2022 22:41:50 GMT, Serguei Spitsyn wrote:
>> src/hotspot/share/runtime/javaThread.cpp line 1174:
>>
>>> 1172: #if INCLUDE_JVMTI
>>> 1173: // Suspending a JavaThread in VTMS transition or disabling VTMS
>>> transitions can cause deadlocks.
>>> 1174: assert(!is_in_non_tmp_VTMS_
On Tue, 20 Sep 2022 22:15:49 GMT, Serguei Spitsyn wrote:
>> src/hotspot/share/prims/jvmtiEnvBase.cpp line 713:
>>
>>> 711: if (!jt->is_in_tmp_VTMS_transition()) {
>>> 712: jvf = check_and_skip_hidden_frames(jt, jvf);
>>> 713: }
>>
>> I think this comment needs some help. It's hard to ma
On Sun, 18 Sep 2022 16:32:31 GMT, Alan Bateman wrote:
> Degrade Thread.suspend/resume to throw UOE unconditionally.
>
> Another step in the removal of this deadlock prone mis-feature from the
> user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2
> (1998) and terminally de
On Wed, 21 Sep 2022 16:49:32 GMT, Adam Sotona wrote:
>> Parsing performance of `j.l.c.MethodTypeDescriptor::ofDescriptor` can be
>> significantly improved and add performance boost to intensive users.
>>
>> Two main reasons have been identified and fixed in this patch:
>>
>> First glitch is la
On Wed, 21 Sep 2022 11:38:36 GMT, KIRIYAMA Takuya wrote:
>> I removed a section of via JDK_JAVA_OPTIONS because including main class is
>> not allowed in the specification.
>> This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment
>> variable. At this time, this test is misma
On Wed, 21 Sep 2022 15:09:21 GMT, Paul Sandoz wrote:
>> `legal` is initially set to false, so leading `/` is also rejected
>
> Doh! Could you add a comment with the case block, something like?
> // Rejects a leading `/`, any "//", and a trailing '/' (by exit from the loop)
I've added the comment
> Parsing performance of `j.l.c.MethodTypeDescriptor::ofDescriptor` can be
> significantly improved and add performance boost to intensive users.
>
> Two main reasons have been identified and fixed in this patch:
>
> First glitch is late insertion of return type to the first position of
> `j.u.
On Fri, 2 Sep 2022 00:52:49 GMT, Smita Kamath wrote:
>> 8289552: Make intrinsic conversions between bit representations of half
>> precision values and floats
>
> Smita Kamath has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed revie
> I don't see why you think a general collection...
I thought the Subject would be sufficient to indicate that I was not
talking about collections in general. I should have been more precise
with my words; guess I was just excited by a bi-directional ordered set.
The MRU _example_ is useful;
On Wed, 14 Sep 2022 09:42:37 GMT, Jie Fu wrote:
> Hi all,
>
> runtime/Dictionary/ProtectionDomainCacheTest.java fails on Linux if `/tmp` is
> a symbolic link directory.
> The root cause is that `JarUtils.createJarFile` [1] will throw
> `FileAlreadyExistsException` if `parent` is a symbolic dir
On Wed, 14 Sep 2022 09:42:37 GMT, Jie Fu wrote:
> Hi all,
>
> runtime/Dictionary/ProtectionDomainCacheTest.java fails on Linux if `/tmp` is
> a symbolic link directory.
> The root cause is that `JarUtils.createJarFile` [1] will throw
> `FileAlreadyExistsException` if `parent` is a symbolic dir
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Correct Label annontation capitals
-
Changes:
- all: https://git.openjdk
On Wed, 14 Sep 2022 09:42:37 GMT, Jie Fu wrote:
> Hi all,
>
> runtime/Dictionary/ProtectionDomainCacheTest.java fails on Linux if `/tmp` is
> a symbolic link directory.
> The root cause is that `JarUtils.createJarFile` [1] will throw
> `FileAlreadyExistsException` if `parent` is a symbolic dir
On Wed, 21 Sep 2022 08:38:19 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/java/lang/constant/ConstantUtils.java line 217:
>>
>>> 215: }
>>> 216: case '/' -> {
>>> 217: if (!legal) return 0;
>>
>> I
On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote:
> Hi,
>
> @dumasun reported the issue:
>
> Configured with jfx-ls-modular-sdk:
>
>
> configure --with-import-modules=modular-sdk
>
>
> `make run-test CONF=fastdebug
> TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed:
>
>
> --
On Fri, 16 Sep 2022 08:26:00 GMT, Matthias Baesken wrote:
> We noticed that with certain jar file input, jdeps runs into the following
> exception, this happens with jdk11, 17 and 20.
>
> jdeps.exe --multi-release 11 --module-path . --inverse --package
> com.sap.nw.performance.supa.client test
On Sun, 18 Sep 2022 16:32:31 GMT, Alan Bateman wrote:
> Degrade Thread.suspend/resume to throw UOE unconditionally.
>
> Another step in the removal of this deadlock prone mis-feature from the
> user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2
> (1998) and terminally de
Degrade Thread.suspend/resume to throw UOE unconditionally.
Another step in the removal of this deadlock prone mis-feature from the
user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2
(1998) and terminally deprecated since Java 14. ThreadGroup.suspend/resume were
degraded
On Wed, 21 Sep 2022 08:35:30 GMT, Magnus Ihse Bursie wrote:
> While this particular issue was closed now, this is perhaps yet another
> indication that the "import modules" thing is causing problems, and should be
> removed now that it is not used anymore. I created
> [JDK-8294095](https://bug
On Wed, 21 Sep 2022 09:23:31 GMT, Alan Bateman wrote:
> > Assuming we are set with the other changes, did you want to add the
> > following paragraph (or similar) at line 58 to make it clear that if the
> > Manifest is not found, then the JarEntry attributes will not be available:
>
> This is
On Fri, 16 Sep 2022 16:19:35 GMT, Naoto Sato wrote:
>> Extract to a byte array with the appropriate charset and then HexFormat the
>> bytearray.
>>
>>
>> var SysPropHexVal =
>> HexFormat.of().formatHex(sysPropVal.getBytes(StandardCharsets.UTF_16));
>
> Thanks, Roger. You beat me to it 🙂
> I removed a section of via JDK_JAVA_OPTIONS because including main class is
> not allowed in the specification.
> This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment
> variable. At this time, this test is mismatch with the specification.
> I tried to test and get Passed on
On Thu, 15 Sep 2022 11:54:41 GMT, Matthias Baesken wrote:
> When trying to load a x64 lib on macOS aarch64 one got previously this
> detailed message before
> [JDK-8275703](https://bugs.openjdk.org/browse/JDK-8275703):
>
> java.lang.UnsatisfiedLinkError: /testing/jco3/macOsx64/libsapjco3.dylib
I don't see why you think a general collection, that is in 99.9% of the
cases not used to implement an MRU, should burden every call to #add
with a check to see if it isn't exceeding its maximum size or to see if
a maximum size has been set.
This is much better done by composition, as I don't
On Thu, 15 Sep 2022 08:55:41 GMT, Severin Gehwolf wrote:
>> Similar issue to the hotspot change discussed in
>> https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation
>> may get the resource limits wrong if there are additional cgroup fs mounts.
>> Apparently that's more
On Fri, 16 Sep 2022 07:27:44 GMT, Matthias Baesken wrote:
>> When trying to load a x64 lib on macOS aarch64 one got previously this
>> detailed message before
>> [JDK-8275703](https://bugs.openjdk.org/browse/JDK-8275703):
>>
>> java.lang.UnsatisfiedLinkError: /testing/jco3/macOsx64/libsapjco3.
On Tue, 20 Sep 2022 18:08:21 GMT, Lance Andersen wrote:
> Assuming we are set with the other changes, did you want to add the following
> paragraph (or similar) at line 58 to make it clear that if the Manifest is
> not found, then the JarEntry attributes will not be available:
This is somethin
On Wed, 21 Sep 2022 07:56:27 GMT, Alan Bateman wrote:
>> Hi @AlanBateman
>>
>> Debug patch:
>>
>>
>> diff --git a/test/jdk/tools/launcher/FXLauncherTest.java
>> b/test/jdk/tools/launcher/FXLauncherTest.java
>> index 9cc4b5aea98..33c3e2788ad 100644
>> --- a/test/jdk/tools/launcher/FXLauncherT
On Tue, 20 Sep 2022 16:54:27 GMT, Paul Sandoz wrote:
>> Parsing performance of `j.l.c.MethodTypeDescriptor::ofDescriptor` can be
>> significantly improved and add performance boost to intensive users.
>>
>> Two main reasons have been identified and fixed in this patch:
>>
>> First glitch is la
On Tue, 20 Sep 2022 12:35:58 GMT, Alan Bateman wrote:
>> I haven't built a JDK using the `--with-import-modules` to include the
>> `javafx.*` modules in quite a while, but my recollection is that yes, that
>> did cause the JavaFX modules to be loaded by the platform class loader. The
>> follow
On Tue, 20 Sep 2022 21:45:05 GMT, Magnus Ihse Bursie wrote:
> The ant detection in bin/idea.sh is very rudimentary. It fails at a modern
> aarch64 macOS installation.
This pull request has now been integrated.
Changeset: 8d1dd6a6
Author:Magnus Ihse Bursie
URL:
https://git.openjdk.o
On Fri, 16 Sep 2022 08:26:00 GMT, Matthias Baesken wrote:
> We noticed that with certain jar file input, jdeps runs into the following
> exception, this happens with jdk11, 17 and 20.
>
> jdeps.exe --multi-release 11 --module-path . --inverse --package
> com.sap.nw.performance.supa.client test
On Wed, 21 Sep 2022 07:42:29 GMT, Leslie Zhai wrote:
> Still failed:
> [debug.log](https://github.com/openjdk/jdk/files/9614161/debug.log)
You are running into module hashes now so I think you'll need some of
JDK-8294093. In make/common/Modules.gmk ReadSingleImportMetaData can you add
UPGR
On Wed, 21 Sep 2022 07:56:27 GMT, Alan Bateman wrote:
>> Hi @AlanBateman
>>
>> Debug patch:
>>
>>
>> diff --git a/test/jdk/tools/launcher/FXLauncherTest.java
>> b/test/jdk/tools/launcher/FXLauncherTest.java
>> index 9cc4b5aea98..33c3e2788ad 100644
>> --- a/test/jdk/tools/launcher/FXLauncherT
On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote:
> Hi,
>
> @dumasun reported the issue:
>
> Configured with jfx-ls-modular-sdk:
>
>
> configure --with-import-modules=modular-sdk
>
>
> `make run-test CONF=fastdebug
> TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed:
>
>
> --
On Tue, 20 Sep 2022 14:11:55 GMT, Kevin Rushforth wrote:
>> Hi,
>>
>> @dumasun reported the issue:
>>
>> Configured with jfx-ls-modular-sdk:
>>
>>
>> configure --with-import-modules=modular-sdk
>>
>>
>> `make run-test CONF=fastdebug
>> TEST="jdk/modules/etc/VerifyModuleDelegation.java"` fa
On Wed, 21 Sep 2022 06:43:50 GMT, David Holmes wrote:
> Okay I will defer to your views here. Thanks.
Thank you, I'll get the CSR moving again and we'll try to get this done.
-
PR: https://git.openjdk.org/jdk/pull/10230
On Wed, 21 Sep 2022 07:10:07 GMT, Alan Bateman wrote:
> but you've set the value to IMPORT_MODULE_DIR and it's not clear what this
> means in this test
I just want to try the imported javafx modules:
--patch-module=javafx.graphics=build/linux-loongarch64-server-fastdebug/images/jdk/jmods/java
On Sat, 17 Sep 2022 04:03:35 GMT, Leslie Zhai wrote:
>> Hi,
>>
>> @dumasun reported the issue:
>>
>> Configured with jfx-ls-modular-sdk:
>>
>>
>> configure --with-import-modules=modular-sdk
>>
>>
>> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"`
>> failed:
>>
>>
On Wed, 21 Sep 2022 07:10:07 GMT, Alan Bateman wrote:
>> Leslie Zhai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8293910: Try --upgrade-module-path and --patch-module but still failed
>
> The --patch-module option is used to override
On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote:
> Hi,
>
> @dumasun reported the issue:
>
> Configured with jfx-ls-modular-sdk:
>
>
> configure --with-import-modules=modular-sdk
>
>
> `make run-test CONF=fastdebug
> TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed:
>
>
> --
On Sat, 17 Sep 2022 04:03:35 GMT, Leslie Zhai wrote:
>> Hi,
>>
>> @dumasun reported the issue:
>>
>> Configured with jfx-ls-modular-sdk:
>>
>>
>> configure --with-import-modules=modular-sdk
>>
>>
>> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"`
>> failed:
>>
>>
59 matches
Mail list logo
