On Tue, 20 Sep 2022 22:41:50 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:

>> src/hotspot/share/runtime/javaThread.cpp line 1174:
>> 
>>> 1172: #if INCLUDE_JVMTI
>>> 1173:   // Suspending a JavaThread in VTMS transition or disabling VTMS 
>>> transitions can cause deadlocks.
>>> 1174:   assert(!is_in_non_tmp_VTMS_transition(), "no suspend allowed in 
>>> VTMS transition");
>> 
>> IMHO, a non tmp VTMS transition should be considered a type of VTMS 
>> transition, so the assert check here does not really match the assert text. 
>> Also see my related comments below on naming and use of these flags and APIs.
>
> Thanks. Accepted.

I thought I was pointing out a naming issue, but your change indicates that it 
was actually a bug, and it is ok to be in a tmp transition here. Is that 
correct?

-------------

PR: https://git.openjdk.org/jdk/pull/10321

Reply via email to