On Wed, 14 Sep 2022 09:42:37 GMT, Jie Fu <ji...@openjdk.org> wrote: > Hi all, > > runtime/Dictionary/ProtectionDomainCacheTest.java fails on Linux if `/tmp` is > a symbolic link directory. > The root cause is that `JarUtils.createJarFile` [1] will throw > `FileAlreadyExistsException` if `parent` is a symbolic directory. > So it seems better to test the existance of `parent` before creation. > > Testing: > - tier1~3 on Linux/x64 in progress, seems fine until now > > Thanks. > Best regards, > Jie > > > [1] > https://github.com/openjdk/jdk/blob/master/test/lib/jdk/test/lib/util/JarUtils.java#L72
The fix looks reasonable to me. There's a potential error case, if `parent` is not a directory. However, this should lead to an exception later inside `Files.newOutputStream(jarfile)`, so I think it's OK to not check for this. ------------- Marked as reviewed by iklam (Reviewer). PR: https://git.openjdk.org/jdk/pull/10266
