On Thu, 18 Aug 2022 18:59:30 GMT, Alan Bateman wrote:
> If you compare the javadoc for the modifiers vs. accessFlags in each of
> ModuleDescriptor, Requires, Exports, and Opens then you'll see what I mean. I
> was hoping they could be consistent.
Ah, okay. Pushed docs updated as suggested for
> Spec refinement, including acting on some feedback received for JDK-8266670:
>
> https://github.com/openjdk/jdk/pull/7445#discussion_r906846794
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brough
On Thu, 30 Jun 2022 15:14:40 GMT, Hannes Wallnöfer wrote:
> Please review an enhancement to the preview page to add a list of preview
> features and allow users to explore the preview APIs by feature.
>
> While the changes for the enhancement itself are not overly complex, the work
> entailed
> Revised test to check and close all of the streams used in the pipeline.
>
> The test now checks the content length and closes each stdout and stderr
> stream.
>
> The previous technique to redirect stderr to stdout was ineffective because
> the fd/stream was still created in the parent proce
On Thu, 18 Aug 2022 18:16:21 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 217:
>>
>>> 215: /**
>>> 216: * {@return an unmodifiable set of the module {@linkplain
>>> AccessFlag
>>> 217: * requires flags}, possibly empt
On Thu, 18 Aug 2022 06:56:53 GMT, Alan Bateman wrote:
>> Spec refinement, including acting on some feedback received for JDK-8266670:
>>
>> https://github.com/openjdk/jdk/pull/7445#discussion_r906846794
>
> src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 217:
>
>> 215:
On Wed, 17 Aug 2022 22:33:03 GMT, Joe Darcy wrote:
> The use of lambda's in the initialization of AccessFlag runs afoul of CDS in
> some cases due to occurring early in the platform's initialization. Instead
> of lambdas, using anonymous classes gets around the issue.
>
> Clean tier1 and tier
On Thu, 18 Aug 2022 14:55:49 GMT, Daniel Fuchs wrote:
> Stupid question: it seems none of these lambdas/anonymous classes capture any
> parameters, all are stateless, and several seems to be identical. Would it
> make the code cleaner to use static inner classes?
Keeping the source for the fun
On Wed, 17 Aug 2022 23:11:23 GMT, Joe Darcy wrote:
>> The use of lambda's in the initialization of AccessFlag runs afoul of CDS in
>> some cases due to occurring early in the platform's initialization. Instead
>> of lambdas, using anonymous classes gets around the issue.
>>
>> Clean tier1 and
> Revised test to check and close all of the streams used in the pipeline.
>
> The test now checks the content length and closes each stdout and stderr
> stream.
>
> The previous technique to redirect stderr to stdout was ineffective because
> the fd/stream was still created in the parent proce
On Wed, 17 Aug 2022 23:11:23 GMT, Joe Darcy wrote:
>> The use of lambda's in the initialization of AccessFlag runs afoul of CDS in
>> some cases due to occurring early in the platform's initialization. Instead
>> of lambdas, using anonymous classes gets around the issue.
>>
>> Clean tier1 and
On Thu, 18 Aug 2022 11:23:00 GMT, Julian Waters wrote:
> I don't quite get what you mean?
The only thing JLI_ReportErrorMessageSys has above JLI_ReportErrorMessage is
that it prints the error code for you, and that is a very slim win. It turns
into a loss quickly if it does that one thing wron
On Thu, 18 Aug 2022 09:55:59 GMT, Thomas Stuefe wrote:
>> 8291917 was simply about making error messages more informative on Windows
>> when loading the C Runtime or Java Virtual Machine dlls failed (Right now it
>> just prints an unhelpful "Error: loading: ...") - It consequently depended
>>
On Thu, 18 Aug 2022 09:46:56 GMT, Julian Waters wrote:
>> Let's back up a bit.
>>
>> I looked again, and think @dholmes-ora was originally right when he wrote
>> that this coding does not get called on Windows. Not sure why I thought
>> differently, but I cannot find a single callsite on windo
On Thu, 18 Aug 2022 08:52:36 GMT, Thomas Stuefe wrote:
>> I was mainly concerned with Thomas's objection that having both would simply
>> be misleading, though now that you say that, maybe this warning combined
>> with both could be a good compromise.
>>
>> @tstuefe thoughts?
>
> Let's back up
> Second attempt at resolving
> [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less
> intrusive approach this time
>
> Side note: While it might be preferred to remove this entirely, other areas
> of the JDK also use the same flawed logic, and removing this would simply
> p
On Thu, 18 Aug 2022 08:10:34 GMT, Julian Waters wrote:
>> src/java.base/windows/native/libjli/java_md.c line 621:
>>
>>> 619: char *errtext = NULL;
>>> 620:
>>> 621: char* const conflict = "Java detected conflicting Windows and C
>>> Runtime errors and is unable to provide an accurate
On Thu, 18 Aug 2022 08:23:22 GMT, Julian Waters wrote:
>> Second attempt at resolving
>> [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less
>> intrusive approach this time
>>
>> Side note: While it might be preferred to remove this entirely, other areas
>> of the JDK also
On Thu, 18 Aug 2022 02:36:37 GMT, David Holmes wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup
>
> src/java.base/unix/native/libjli/java_md_common.c line 213:
>
>> 211: */
>> 212: char er
> Second attempt at resolving
> [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less
> intrusive approach this time
>
> Side note: While it might be preferred to remove this entirely, other areas
> of the JDK also use the same flawed logic, and removing this would simply
> p
On Thu, 18 Aug 2022 02:39:55 GMT, David Holmes wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup
>
> src/java.base/windows/native/libjli/java_md.c line 621:
>
>> 619: char *errtext = NULL;
>> 620:
>>
On Thu, 18 Aug 2022 05:05:33 GMT, Joe Darcy wrote:
> Spec refinement, including acting on some feedback received for JDK-8266670:
>
> https://github.com/openjdk/jdk/pull/7445#discussion_r906846794
src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 217:
> 215: /**
>
22 matches
Mail list logo
