On Thu, 18 Aug 2022 05:05:33 GMT, Joe Darcy <da...@openjdk.org> wrote:
> Spec refinement, including acting on some feedback received for JDK-8266670: > > https://github.com/openjdk/jdk/pull/7445#discussion_r906846794 src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 217: > 215: /** > 216: * {@return an unmodifiable set of the module {@linkplain > AccessFlag > 217: * requires flags}, possibly empty} The link fix looks okay but the wording in the new accessFlags() method is different to the wording in the other methods. The other methods use "possibly-empty unmodifiable" in the return description. Either is fine but I think we should try to keep the wording consistent where possible. ------------- PR: https://git.openjdk.org/jdk/pull/9912