On Thu, 18 Aug 2022 08:10:34 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> src/java.base/windows/native/libjli/java_md.c line 621: >> >>> 619: char *errtext = NULL; >>> 620: >>> 621: char* const conflict = "Java detected conflicting Windows and C >>> Runtime errors and is unable to provide an accurate report"; >> >> So why not report both of them as part of the message? > > I was mainly concerned with Thomas's objection that having both would simply > be misleading, though now that you say that, maybe this warning combined with > both could be a good compromise. > > @tstuefe thoughts? Let's back up a bit. I looked again, and think @dholmes-ora was originally right when he wrote that this coding does not get called on Windows. Not sure why I thought differently, but I cannot find a single callsite on windows. But that is weird, since originally there was an error reported on Windows: https://bugs.openjdk.org/browse/JDK-8291917 reported a real problem about windows printing useless error messages. What was the original problem again? If we are right and this code is not needed, I'd just scrap this function on Windows altogether. ------------- PR: https://git.openjdk.org/jdk/pull/9870
