Re: [I] Broker show `alive=false` in controller `getSyncStateSet` command [rocketmq-operator]

2024-02-29 Thread via GitHub
drivebyer commented on issue #213: URL: https://github.com/apache/rocketmq-operator/issues/213#issuecomment-1970619362 @caigy PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2024-02-29 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 4e11795366d1ae3467068f565cda9a081df5d606 / zhouxiang [ISSUE #7875] Add constructor for ProxyTopicRouteData Report URL: https://gi

Re: [PR] [ISSUE #6654] Changed the return type of List to Array of method need… [rocketmq]

2024-02-29 Thread via GitHub
yp969803 closed pull request #7589: [ISSUE #6654] Changed the return type of List to Array of method need… URL: https://github.com/apache/rocketmq/pull/7589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [ISSUE #7590] computeIfAbsent unit test modified [rocketmq]

2024-02-29 Thread via GitHub
yp969803 closed pull request #7591: [ISSUE #7590] computeIfAbsent unit test modified URL: https://github.com/apache/rocketmq/pull/7591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] [Enhancement] Add constructor for ProxyTopicRouteData [rocketmq]

2024-02-29 Thread via GitHub
drpmma closed issue #7875: [Enhancement] Add constructor for ProxyTopicRouteData URL: https://github.com/apache/rocketmq/issues/7875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [ISSUE #7875] Add constructor for ProxyTopicRouteData [rocketmq]

2024-02-29 Thread via GitHub
drpmma merged PR #7876: URL: https://github.com/apache/rocketmq/pull/7876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.a

(rocketmq) branch develop updated: [ISSUE #7875] Add constructor for ProxyTopicRouteData (#7876)

2024-02-29 Thread zhouxzhan
This is an automated email from the ASF dual-hosted git repository. zhouxzhan pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new a33f1d1c72 [ISSUE #7875] Add constructor

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: a33f1d1c72a785744f586ce2e92a45f25dd5ebd5 / Zhouxiang Zhan [ISSUE #7875] Add constructor for ProxyTopicRouteData (#7876) Report URL:

[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: a33f1d1c72a785744f586ce2e92a45f25dd5ebd5 / Zhouxiang Zhan [ISSUE #7875] Add constructor for ProxyTopicRouteData (#7876) Report URL: https://github.com/apa

Re: [PR] [ISSUE #7861] Allow user can change the tls mode to avoid init ssl context [rocketmq]

2024-02-29 Thread via GitHub
cserwen commented on code in PR #7862: URL: https://github.com/apache/rocketmq/pull/7862#discussion_r1507466329 ## proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java: ## @@ -220,10 +227,14 @@ private class TlsModeHandler extends ByteToMessageDe

Re: [PR] [ISSUE #7481] Remove invalid key/value in logPolling map (#7481) [rocketmq]

2024-02-29 Thread via GitHub
cserwen commented on code in PR #7670: URL: https://github.com/apache/rocketmq/pull/7670#discussion_r1507475276 ## broker/src/main/java/org/apache/rocketmq/broker/longpolling/PullRequestHoldService.java: ## @@ -174,7 +174,15 @@ public void notifyMessageArriving(final String topi

Re: [PR] [ISSUE #7481] Remove invalid key/value in logPolling map (#7481) [rocketmq]

2024-02-29 Thread via GitHub
cserwen commented on code in PR #7670: URL: https://github.com/apache/rocketmq/pull/7670#discussion_r1507475276 ## broker/src/main/java/org/apache/rocketmq/broker/longpolling/PullRequestHoldService.java: ## @@ -174,7 +174,15 @@ public void notifyMessageArriving(final String topi

Re: [PR] [ISSUE #7481] Remove invalid key/value in logPolling map (#7481) [rocketmq]

2024-02-29 Thread via GitHub
cserwen commented on code in PR #7670: URL: https://github.com/apache/rocketmq/pull/7670#discussion_r1507478259 ## broker/src/main/java/org/apache/rocketmq/broker/longpolling/PullRequestHoldService.java: ## @@ -174,7 +174,15 @@ public void notifyMessageArriving(final String topi

Re: [PR] [ISSUE #7872] Fix Tiered Store Query Message Async return different v… [rocketmq]

2024-02-29 Thread via GitHub
lizhimins commented on PR #7874: URL: https://github.com/apache/rocketmq/pull/7874#issuecomment-1971075879 我明天看下。。这里有些大的改动 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [I] [Bug] Tiered Store Query Message Async return different view each time [rocketmq]

2024-02-29 Thread via GitHub
lizhimins commented on issue #7872: URL: https://github.com/apache/rocketmq/issues/7872#issuecomment-1971077463 Good catch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: 5cc5a542a25ef02a5df2e293b3425dbee7ee2c54 / yash [ISSUE #7481] Remove invalid key/value in logPolling map (#7481) Report URL: http

Re: [PR] [ISSUE #7481] Remove invalid key/value in logPolling map (#7481) [rocketmq]

2024-02-29 Thread via GitHub
yp969803 commented on PR #7670: URL: https://github.com/apache/rocketmq/pull/7670#issuecomment-1971320376 @cserwen done the changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: a33f1d1c72a785744f586ce2e92a45f25dd5ebd5 / Zhouxiang Zhan [ISSUE #7875] Add constructor for ProxyTopicRouteData (#7876) Report URL:

Re: [PR] [ISSUE #7481] Remove invalid key/value in logPolling map (#7481) [rocketmq]

2024-02-29 Thread via GitHub
yp969803 commented on PR #7670: URL: https://github.com/apache/rocketmq/pull/7670#issuecomment-1971357241 @cserwen done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: 3c3612904c3724080af1a3e625889adfb3b98e8c / yash [ISSUE #7481] Remove invalid key/value in logPolling map (#7481) Report URL: http

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: a33f1d1c72a785744f586ce2e92a45f25dd5ebd5 / Zhouxiang Zhan [ISSUE #7875] Add constructor for ProxyTopicRouteData (#7876) Report URL:

Re: [PR] [ISSUE 4890] WIP Fix binary search consume offset by time [rocketmq]

2024-02-29 Thread via GitHub
github-actions[bot] commented on PR #4891: URL: https://github.com/apache/rocketmq/pull/4891#issuecomment-1972184781 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [ISSUE 4890] WIP Fix binary search consume offset by time [rocketmq]

2024-02-29 Thread via GitHub
github-actions[bot] closed pull request #4891: [ISSUE 4890] WIP Fix binary search consume offset by time URL: https://github.com/apache/rocketmq/pull/4891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [ISSUE #7861] Allow user can change the tls mode to avoid init ssl context [rocketmq]

2024-02-29 Thread via GitHub
leizhiyuan commented on code in PR #7862: URL: https://github.com/apache/rocketmq/pull/7862#discussion_r1508403360 ## proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java: ## @@ -220,10 +227,14 @@ private class TlsModeHandler extends ByteToMessag

[I] [Enhancement] Performance Improvement and Bug Fixes for the Tiered Storage Module [rocketmq]

2024-02-29 Thread via GitHub
lizhimins opened a new issue, #7878: URL: https://github.com/apache/rocketmq/issues/7878 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary Performance Improvement

Re: [PR] [ISSUE #7861] Allow user can change the tls mode to avoid init ssl context [rocketmq]

2024-02-29 Thread via GitHub
cserwen commented on code in PR #7862: URL: https://github.com/apache/rocketmq/pull/7862#discussion_r1508425223 ## proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java: ## @@ -220,10 +227,14 @@ private class TlsModeHandler extends ByteToMessageDe

Re: [I] [Bug] Unboxing NPE in SendMessageRequestHeader [rocketmq]

2024-02-29 Thread via GitHub
drpmma closed issue #7871: [Bug] Unboxing NPE in SendMessageRequestHeader URL: https://github.com/apache/rocketmq/issues/7871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(rocketmq) branch develop updated: Fix unboxing npe in SendMessageRequestHeader (#7873)

2024-02-29 Thread zhouxzhan
This is an automated email from the ASF dual-hosted git repository. zhouxzhan pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new cb9ea9efb3 Fix unboxing npe in SendMessag

Re: [PR] [ISSUE #7871] Fix unboxing npe in SendMessageRequestHeader [rocketmq]

2024-02-29 Thread via GitHub
drpmma merged PR #7873: URL: https://github.com/apache/rocketmq/pull/7873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.a

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: cb9ea9efb379c7658f83078e6f7f6be580455ce8 / Zhouxiang Zhan Fix unboxing npe in SendMessageRequestHeader (#7873) Report URL: https://g

Re: [I] [Bug] Master broker in Dledger mode didn't sync consume offset in time after reboot, which caused consume repeatedly [rocketmq]

2024-02-29 Thread via GitHub
cserwen commented on issue #7790: URL: https://github.com/apache/rocketmq/issues/7790#issuecomment-1972403289 Can you submit a pr to fix it @bxfjb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GH] (rocketmq): Workflow run "PUSH-CI" is working again!

2024-02-29 Thread GitBox
The GitHub Actions job "PUSH-CI" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: cb9ea9efb379c7658f83078e6f7f6be580455ce8 / Zhouxiang Zhan Fix unboxing npe in SendMessageRequestHeader (#7873) Report URL: https://github.com/apache/ro

Re: [I] Broker show `alive=false` in controller `getSyncStateSet` command [rocketmq-operator]

2024-02-29 Thread via GitHub
drivebyer commented on issue #213: URL: https://github.com/apache/rocketmq-operator/issues/213#issuecomment-1972413874 在主库的讨论见:https://github.com/apache/rocketmq/discussions/7877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GH] (rocketmq): Workflow run "Coverage" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: cb9ea9efb379c7658f83078e6f7f6be580455ce8 / Zhouxiang Zhan Fix unboxing npe in SendMessageRequestHeader (#7873) Report URL: https://github.com/apache/rock

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: cb9ea9efb379c7658f83078e6f7f6be580455ce8 / Zhouxiang Zhan Fix unboxing npe in SendMessageRequestHeader (#7873) Report URL: https://g

[PR] prevent english commas from being cut [rocketmq-eventbridge]

2024-02-29 Thread via GitHub
zhaohai666 opened a new pull request, #163: URL: https://github.com/apache/rocketmq-eventbridge/pull/163 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [ISSUE #7861] Allow user can change the tls mode to avoid init ssl context [rocketmq]

2024-02-29 Thread via GitHub
leizhiyuan commented on code in PR #7862: URL: https://github.com/apache/rocketmq/pull/7862#discussion_r1508520419 ## proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java: ## @@ -220,10 +227,14 @@ private class TlsModeHandler extends ByteToMessag

[GH] (rocketmq): Workflow run "PR-CI" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user leizhiyuan (triggered by leizhiyuan). Head commit for run: 27f5ed7a05a7c8cd17cfcc905ff80836d241f92d / leizhiyuan chore: use tls.server.mode Report URL: https://github.com/apache/rocketmq/actions/runs/81073135

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user leizhiyuan (triggered by leizhiyuan). Head commit for run: cb9ea9efb379c7658f83078e6f7f6be580455ce8 / Zhouxiang Zhan Fix unboxing npe in SendMessageRequestHeader (#7873) Report URL: https

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user leizhiyuan (triggered by leizhiyuan). Head commit for run: 27f5ed7a05a7c8cd17cfcc905ff80836d241f92d / leizhiyuan chore: use tls.server.mode Report URL: https://github.com/apache/rocket

[GH] (rocketmq): Workflow run "Coverage" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user leizhiyuan (triggered by leizhiyuan). Head commit for run: 27f5ed7a05a7c8cd17cfcc905ff80836d241f92d / leizhiyuan chore: use tls.server.mode Report URL: https://github.com/apache/rocketmq/actions/runs/81073

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-02-29 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user leizhiyuan (triggered by leizhiyuan). Head commit for run: 27f5ed7a05a7c8cd17cfcc905ff80836d241f92d / leizhiyuan chore: use tls.server.mode Report URL: https://github.com/apache/rocket