cserwen commented on code in PR #7670:
URL: https://github.com/apache/rocketmq/pull/7670#discussion_r1507475276
##########
broker/src/main/java/org/apache/rocketmq/broker/longpolling/PullRequestHoldService.java:
##########
@@ -174,7 +174,15 @@ public void notifyMessageArriving(final String topic,
final int queueId, final l
mpr.addPullRequest(replayList);
}
}
+ else if (null == requestList) {
+ this.pullRequestTable.remove(key);
+ }
+
+ }
+ else if (null == mpr) {
Review Comment:
pullRequestTable is ConcurrentHashMap, so null means this key is not
existed, so this branch is redundant
##########
broker/src/main/java/org/apache/rocketmq/broker/longpolling/PullRequestHoldService.java:
##########
@@ -174,7 +174,15 @@ public void notifyMessageArriving(final String topic,
final int queueId, final l
mpr.addPullRequest(replayList);
}
}
+ else if (null == requestList) {
Review Comment:
`else` no need to newLine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
