cserwen commented on code in PR #7862:
URL: https://github.com/apache/rocketmq/pull/7862#discussion_r1507466329
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java:
##########
@@ -220,10 +227,14 @@ private class TlsModeHandler extends ByteToMessageDecoder
{
private final ChannelHandler plaintext;
public TlsModeHandler(GrpcHttp2ConnectionHandler grpcHandler) {
- this.ssl = InternalProtocolNegotiators.serverTls(sslContext)
+ if (sslContext == null) {
+ this.ssl = null;
Review Comment:
If ssl is null, will it cause other npe problems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
