Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]

2023-10-23 Thread via GitHub
tensory2022 commented on issue #7489: URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1774618414 @joeCarf Thanks for your PR. Hope it will be merged soon. The code you require is at: org.apache.rocketmq.client.impl.factory.MQClientInstance. ![image](https://github

Re: [PR] [ISSUE #7489] Code comment enhancement in example [rocketmq]

2023-10-23 Thread via GitHub
joeCarf commented on PR #7490: URL: https://github.com/apache/rocketmq/pull/7490#issuecomment-1774624815 @RongtongJin hi~ PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [ISSUE #7489] Code comment enhancement in example [rocketmq]

2023-10-23 Thread via GitHub
RongtongJin merged PR #7490: URL: https://github.com/apache/rocketmq/pull/7490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocke

[rocketmq] branch develop updated: [ISSUE #7489] Code comment enhancement in example (#7490)

2023-10-23 Thread jinrongtong
This is an automated email from the ASF dual-hosted git repository. jinrongtong pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new 8f020b397a [ISSUE #7489] Code comment e

Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]

2023-10-23 Thread via GitHub
RongtongJin closed issue #7489: Code comments of updateConsumeOffset() should be corrected URL: https://github.com/apache/rocketmq/issues/7489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to

Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]

2023-10-23 Thread via GitHub
RongtongJin commented on PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#issuecomment-1774711634 > Why delete this method? How to obtain ACL configuration through the interface after deletion Suggested to check on the corresponding broker machine -- This is an automated

[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to debug in Idea * en *

[I] [Bug] controller metricsExporterType config not working [rocketmq]

2023-10-23 Thread via GitHub
iamgd67 opened a new issue, #7491: URL: https://github.com/apache/rocketmq/issues/7491 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I ha

[PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]

2023-10-23 Thread via GitHub
iamgd67 opened a new pull request, #7492: URL: https://github.com/apache/rocketmq/pull/7492 ### Which Issue(s) This PR Fixes Fixes #7491 ### Brief Description config file using `MixAll.properties2Object` to load not support enum type. so add a `String` arg on

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 5d0e456b472b57bfc8a5eee05924a57cb621f7a6 / 67 <6...@gd67.com> [ISSUE #7491] metricsExporterType enum config support Report URL: http

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to

Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]

2023-10-23 Thread via GitHub
onejimmyboy commented on PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#issuecomment-1774781573 > > Why delete this method? How to obtain ACL configuration through the interface after deletion > > Suggested to check on the corresponding broker machine Yes, this is inde

Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]

2023-10-23 Thread via GitHub
onejimmyboy commented on PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#issuecomment-1774787858 > > Why delete this method? How to obtain ACL configuration through the interface after deletion > > Suggested to check on the corresponding broker machine > >> Yes, thi

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to debug in Ide

[GH] (rocketmq): Workflow run "Coverage" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 5d0e456b472b57bfc8a5eee05924a57cb621f7a6 / 67 <6...@gd67.com> [ISSUE #7491] metricsExporterType enum config support Report URL: https://github.com/apache

Re: [I] 当生产者和消费者的Qos等级不同时,当前似乎没有实现降级 [rocketmq-mqtt]

2023-10-23 Thread via GitHub
DongyuanPan commented on issue #214: URL: https://github.com/apache/rocketmq-mqtt/issues/214#issuecomment-1774804913 MQTT协议里面client和server角色是不严格区分的,是可以交换的。所以这个QOS我们理解是一个双方交互的一个协议规范,例如需不需要恢复ACK等。所以发送的时候由发送者在message里面设置qos,表示要和服务端以相应的qos进行交互。作为接收者的时候,通过subscribe 告诉服务器,接收者想要以何种qos进行交互,随后服务端给接收

Re: [I] 当生产者和消费者的Qos等级不同时,当前似乎没有实现降级 [rocketmq-mqtt]

2023-10-23 Thread via GitHub
DongyuanPan commented on issue #214: URL: https://github.com/apache/rocketmq-mqtt/issues/214#issuecomment-1774805595 也就是说,是独立的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [I] 当生产者和消费者的Qos等级不同时,当前似乎没有实现降级 [rocketmq-mqtt]

2023-10-23 Thread via GitHub
leizhiyuan commented on issue #214: URL: https://github.com/apache/rocketmq-mqtt/issues/214#issuecomment-1774825413 emqx的实现 https://github.com/apache/rocketmq-mqtt/assets/2684384/784702dd-b89b-4354-9317-fd28d9a1d5a3";> 是取了消息和订阅者的min,实测也是这样的。 这块mqtt文档中,没有说的很明显。 -- This is a

Re: [I] 当生产者和消费者的Qos等级不同时,当前似乎没有实现降级 [rocketmq-mqtt]

2023-10-23 Thread via GitHub
leizhiyuan commented on issue #214: URL: https://github.com/apache/rocketmq-mqtt/issues/214#issuecomment-1774827367 mqtt的文档这里确实没有看到有这个说法,可以先保持这样倒也可以。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 5d0e456b472b57bfc8a5eee05924a57cb621f7a6 / 67 <6...@gd67.com> [ISSUE #7491] metricsExporterType enum config support Report URL: http

Re: [I] 当生产者和消费者的Qos等级不同时,当前似乎没有实现降级 [rocketmq-mqtt]

2023-10-23 Thread via GitHub
leizhiyuan commented on issue #214: URL: https://github.com/apache/rocketmq-mqtt/issues/214#issuecomment-1774908311 ![Uploading mmexport1698057384240.jpg…]() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] error Caused by: java.util.concurrent.CancellationException: Task was cancelled. [rocketmq]

2023-10-23 Thread via GitHub
x43125 commented on issue #7239: URL: https://github.com/apache/rocketmq/issues/7239#issuecomment-1774916919 I meet the same question When I followed the official quickstart steps, there was an error sending a message (https://rocketmq.apache.org/zh/docs/quickStart/01quickstart) ser

Re: [I] 当生产者和消费者的Qos等级不同时,当前似乎没有实现降级 [rocketmq-mqtt]

2023-10-23 Thread via GitHub
leizhiyuan commented on issue #214: URL: https://github.com/apache/rocketmq-mqtt/issues/214#issuecomment-1774952495 https://docs.oasis-open.org/mqtt/mqtt/v3.1.1/csd02/mqtt-v3.1.1-csd02.html https://github.com/apache/rocketmq-mqtt/assets/2684384/bb6c0dc4-a75a-4e0a-9152-69ec44c58b64";>

Re: [I] 能否release一个 支持mac m2 的 构建后的包 非常感谢 [rocketmq-client-cpp]

2023-10-23 Thread via GitHub
lpflpf commented on issue #459: URL: https://github.com/apache/rocketmq-client-cpp/issues/459#issuecomment-1774961526 应该是ARM 版本的, darwin 是intel 芯片的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [ISSUE #539] Feat: support SpringBoot 3.x [rocketmq-spring]

2023-10-23 Thread via GitHub
xuxiaocong commented on PR #541: URL: https://github.com/apache/rocketmq-spring/pull/541#issuecomment-1775030643 入口类增加 @Import(RocketMQAutoConfiguration.class) 配置需要下面三个 rocketmq.name-server=xxx rocketmq.producer.group=xxx rocketmq.pull-consumer.group=xxx # 无法监听的增加这个配置就行了

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/ro

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to debug in Idea

[GH] (rocketmq): Workflow run "Coverage" is working again!

2023-10-23 Thread GitBox
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/run

Re: [PR] [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE [rocketmq]

2023-10-23 Thread via GitHub
codecov-commenter commented on PR #7494: URL: https://github.com/apache/rocketmq/pull/7494#issuecomment-1775075331 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/ro

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/ro

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/ro

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/ro

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/ro

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache

[PR] Java 4.x-fix [rocketmq-e2e]

2023-10-23 Thread via GitHub
Zintoki opened a new pull request, #54: URL: https://github.com/apache/rocketmq-e2e/pull/54 ## Brief changelog Reduce the number of topic creation times and increase the wait time appropriately to ensure that all tests pass under concurrent testing ## Checklist - [x] Re

Re: [PR] [ISSUE#5359] Optimize the heartbeat check pre-collection address [rocketmq]

2023-10-23 Thread via GitHub
github-actions[bot] commented on PR #5360: URL: https://github.com/apache/rocketmq/pull/5360#issuecomment-1776247804 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [I] Optimize the heartbeat check pre-collection address [rocketmq]

2023-10-23 Thread via GitHub
github-actions[bot] closed issue #5359: Optimize the heartbeat check pre-collection address URL: https://github.com/apache/rocketmq/issues/5359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] Error core-concept url in comment. [rocketmq]

2023-10-23 Thread via GitHub
github-actions[bot] commented on issue #5358: URL: https://github.com/apache/rocketmq/issues/5358#issuecomment-1776247867 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to t

Re: [I] Resolve the unstable unit tests [rocketmq]

2023-10-23 Thread via GitHub
github-actions[bot] commented on issue #5331: URL: https://github.com/apache/rocketmq/issues/5331#issuecomment-1776247902 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] [ISSUE#5359] Optimize the heartbeat check pre-collection address [rocketmq]

2023-10-23 Thread via GitHub
github-actions[bot] closed pull request #5360: [ISSUE#5359] Optimize the heartbeat check pre-collection address URL: https://github.com/apache/rocketmq/pull/5360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] Optimize the heartbeat check pre-collection address [rocketmq]

2023-10-23 Thread via GitHub
github-actions[bot] commented on issue #5359: URL: https://github.com/apache/rocketmq/issues/5359#issuecomment-1776247832 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to t

Re: [I] Error core-concept url in comment. [rocketmq]

2023-10-23 Thread via GitHub
github-actions[bot] closed issue #5358: Error core-concept url in comment. URL: https://github.com/apache/rocketmq/issues/5358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [I] Resolve the unstable unit tests [rocketmq]

2023-10-23 Thread via GitHub
github-actions[bot] closed issue #5331: Resolve the unstable unit tests URL: https://github.com/apache/rocketmq/issues/5331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [I] How to use Rocketmq Ledger cluster mode for spring boot? [rocketmq]

2023-10-23 Thread via GitHub
github-actions[bot] commented on issue #5330: URL: https://github.com/apache/rocketmq/issues/5330#issuecomment-1776247923 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to t

Re: [I] How to use Rocketmq Ledger cluster mode for spring boot? [rocketmq]

2023-10-23 Thread via GitHub
github-actions[bot] closed issue #5330: How to use Rocketmq Ledger cluster mode for spring boot? URL: https://github.com/apache/rocketmq/issues/5330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[I] [NameServer启动失败] JDK17启动NameServer时失败 [rocketmq]

2023-10-23 Thread via GitHub
PottermoreIron opened a new issue, #7495: URL: https://github.com/apache/rocketmq/issues/7495 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [

[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: dbc641130b8e4c1d428b3216572d250f61f6578b / RongtongJin Add log Report URL: https://github.com/apache/rocketmq/actions/runs

[GH] (rocketmq): Workflow run "Coverage" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: dbc641130b8e4c1d428b3216572d250f61f6578b / RongtongJin Add log Report URL: https://github.com/apache/rocketmq/actions/runs/6621473725 With reg

Re: [I] [Enhancement] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener [rocketmq]

2023-10-23 Thread via GitHub
drpmma closed issue #7493: [Enhancement] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener URL: https://github.com/apache/rocketmq/issues/7493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[rocketmq] branch develop updated: [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494)

2023-10-23 Thread zhouxzhan
This is an automated email from the ASF dual-hosted git repository. zhouxzhan pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new 2043dd5034 [ISSUE #7493] Introduce a new

Re: [PR] [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE [rocketmq]

2023-10-23 Thread via GitHub
drpmma merged PR #7494: URL: https://github.com/apache/rocketmq/pull/7494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.a

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to debu

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: dbc641130b8e4c1d428b3216572d250f61f6578b / RongtongJin Add log Report URL: https://github.com/apache/rocketmq/actions/runs

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494) * [ISSUE

[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494) * [ISSUE #7493] Introduce a new

[GH] (rocketmq): Workflow run "Coverage" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494) * [ISSUE #7493] Introduce a ne

Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]

2023-10-23 Thread via GitHub
joeCarf commented on code in PR #7492: URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369491571 ## common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java: ## @@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType metricsExport

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: ae2c2b1ee719d32355c87e0ee77f138051de699c / RongtongJin Fix UTs Report URL: https://github.com/apache/rocketmq/actions/runs

Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]

2023-10-23 Thread via GitHub
iamgd67 commented on code in PR #7492: URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369494853 ## common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java: ## @@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType metricsExport

Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]

2023-10-23 Thread via GitHub
iamgd67 commented on code in PR #7492: URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369494853 ## common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java: ## @@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType metricsExport

Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]

2023-10-23 Thread via GitHub
joeCarf commented on code in PR #7492: URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369497349 ## common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java: ## @@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType metricsExport

Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]

2023-10-23 Thread via GitHub
iamgd67 commented on code in PR #7492: URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369494853 ## common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java: ## @@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType metricsExport

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494) * [

Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]

2023-10-23 Thread via GitHub
joeCarf commented on code in PR #7492: URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369510016 ## common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java: ## @@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType metricsExport

Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]

2023-10-23 Thread via GitHub
joeCarf commented on code in PR #7492: URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369513486 ## common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java: ## @@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType metricsExport

[GH] (rocketmq): Workflow run "Coverage" is working again!

2023-10-23 Thread GitBox
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: ae2c2b1ee719d32355c87e0ee77f138051de699c / RongtongJin Fix UTs Report URL: https://github.com/apache/rocketmq/actions/runs/6621743244 With

Re: [PR] [ISSUE #7480] Fix the offset in the timerCheckPoint will not be corrected when the commitlog and consumeQueue are truncated [rocketmq]

2023-10-23 Thread via GitHub
codecov-commenter commented on PR #7488: URL: https://github.com/apache/rocketmq/pull/7488#issuecomment-1776447461 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7488?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494) * [ISS

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: ae2c2b1ee719d32355c87e0ee77f138051de699c / RongtongJin Fix UTs Report URL: https://github.com/apache/rocketmq/actions/runs

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: ae2c2b1ee719d32355c87e0ee77f138051de699c / RongtongJin Fix UTs Report URL: https://github.com/apache/rocketmq/actions/r

Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]

2023-10-23 Thread via GitHub
caigy commented on code in PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#discussion_r1369630044 ## remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RequestCode.java: ## @@ -80,8 +80,6 @@ public class RequestCode { public static final int UPDATE_G

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: f77e4b64d546674c7f0a80013db332daf462 / RongtongJin Add @Deprecated annotation to GET_BROKER_CLUSTER_ACL_CONFIG request

[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!

2023-10-23 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494)

Re: [I] [RIP-46] Observability improvement for RocketMQ [rocketmq]

2023-10-23 Thread via GitHub
GenerousMan commented on issue #5350: URL: https://github.com/apache/rocketmq/issues/5350#issuecomment-1776603191 Hello, I have completed some broker metrics related to timing and transaction messages. I will initiate a PR and link to this issue's task 3. I hope you can help review it if yo

Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]

2023-10-23 Thread via GitHub
iamgd67 commented on code in PR #7492: URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369689385 ## common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java: ## @@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType metricsExport

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 1d8c87453ccc79108a0f49c1089d8ca054d46cdb / 67 <6...@gd67.com> re-trigger tests Report URL: https://github.com/apache/rocketmq/action

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-10-23 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494) * [ISSUE #7