joeCarf commented on code in PR #7492:
URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369497349
##########
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##########
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+ // support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+ public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
配置时是使用的int类型吗
<img width="498" alt="截屏2023-10-24 11 07 50"
src="https://github.com/apache/rocketmq/assets/52153761/d5143092-6b2f-49ae-af64-8069b0c29ecb";>
##########
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##########
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+ // support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+ public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
配置时是使用的int类型吗
<img width="498" alt="截屏2023-10-24 11 07 50"
src="https://github.com/apache/rocketmq/assets/52153761/d5143092-6b2f-49ae-af64-8069b0c29ecb";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
