Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]

[via GitHub]

iamgd67 commented on code in PR #7492:
URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369494853


##########
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##########
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType 
metricsExporterType) {
         this.metricsExporterType = metricsExporterType;
     }
 
+    // support read from config file using 
org.apache.rocketmq.common.MixAll.properties2Object
+    public void setMetricsExporterType(String metricsExporterType) {

Review Comment:
   > 当前代码中已经有类似的方法，你这里新写的方法是否会被调用到呢 <img alt="截屏2023-10-24 10 56 56" 
width="718" 
src="https://user-images.githubusercontent.com/52153761/277535786-cd865865-03ad-4b27-b754-5d3cd54b7f9f.png";>
   
   是设置配置时，通过MixAll.properties2Object 反射调用的
   查看下issue，目前配置打开metric，因为类型不是string，设置不进来，配置不生效，，brokerConfig里是这样的处理方式



##########
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##########
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType 
metricsExporterType) {
         this.metricsExporterType = metricsExporterType;
     }
 
+    // support read from config file using 
org.apache.rocketmq.common.MixAll.properties2Object
+    public void setMetricsExporterType(String metricsExporterType) {

Review Comment:
   > 当前代码中已经有类似的方法，你这里新写的方法是否会被调用到呢 <img alt="截屏2023-10-24 10 56 56" 
width="718" 
src="https://user-images.githubusercontent.com/52153761/277535786-cd865865-03ad-4b27-b754-5d3cd54b7f9f.png";>
   
   是设置配置时，通过MixAll.properties2Object 反射调用的
   查看下issue，目前配置打开metric，因为类型不是string，设置不进来，配置不生效，，brokerConfig里是这样的处理方式



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org