[GitHub] [nuttx] raiden00pl opened a new pull request, #8923: nrf52: initial support for USBDEV

2023-03-29 Thread via GitHub
raiden00pl opened a new pull request, #8923: URL: https://github.com/apache/nuttx/pull/8923 ## Summary - nrf52: add usb support - nrf52840-dk: add usbdev examples ## Impact none ## Testing nrf52840-dk -- This is an automated message from the Apache Git Service

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8862: syscall/libc: add more syscall/libc symbols into csv file

2023-03-29 Thread via GitHub
pkarashchenko commented on code in PR #8862: URL: https://github.com/apache/nuttx/pull/8862#discussion_r1151506748 ## include/stdlib.h: ## @@ -286,6 +286,11 @@ FAR void *bsearch(FAR const void *key, FAR const void *base, size_t nel, FAR const char *getprogname(void); +/*

[GitHub] [nuttx] wengzhe commented on pull request #8915: net/tcp: Reply RST when we cannot receive data

2023-03-29 Thread via GitHub
wengzhe commented on PR #8915: URL: https://github.com/apache/nuttx/pull/8915#issuecomment-1488110762 > @wengzhe please include this Summary message in the commit log message. Including the message initially in the commit log message you don't need to duplicate your effort because it appear

[GitHub] [nuttx-apps] masayuki2009 opened a new pull request, #1690: nshlib: Fix the ps command format

2023-03-29 Thread via GitHub
masayuki2009 opened a new pull request, #1690: URL: https://github.com/apache/nuttx-apps/pull/1690 ## Summary - I noticed that the ps command shows the wrong format due to recent changes on sigmask length from 32bits to 64bits - This commit fixes this issue ``` Before:

[GitHub] [nuttx-apps] pkarashchenko commented on pull request #1687: system/cu: Move fd_std_tty, g_tio_std and g_tio_dev to cu_globals_s

2023-03-29 Thread via GitHub
pkarashchenko commented on PR #1687: URL: https://github.com/apache/nuttx-apps/pull/1687#issuecomment-1488212163 @xiaoxiang781216 will you apply suggestion or should we move to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1687: system/cu: Move fd_std_tty, g_tio_std and g_tio_dev to cu_globals_s

2023-03-29 Thread via GitHub
xiaoxiang781216 commented on PR #1687: URL: https://github.com/apache/nuttx-apps/pull/1687#issuecomment-1488270641 > @xiaoxiang781216 will you apply suggestion or should we move to merge? Yes, I will apply your suggestion. Please wait a moment. -- This is an automated message from t

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1687: system/cu: Move fd_std_tty, g_tio_std and g_tio_dev to cu_globals_s

2023-03-29 Thread via GitHub
xiaoxiang781216 commented on code in PR #1687: URL: https://github.com/apache/nuttx-apps/pull/1687#discussion_r1151669606 ## system/cu/cu_main.c: ## @@ -291,15 +288,15 @@ int main(int argc, FAR char *argv[]) /* Initialize global data */ - memset(&g_cu, 0, sizeof(struct c

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1683: Minor signal fix found from https://github.com/apache/nuttx/pull/8900

2023-03-29 Thread via GitHub
xiaoxiang781216 commented on code in PR #1683: URL: https://github.com/apache/nuttx-apps/pull/1683#discussion_r1151438835 ## include/graphics/twm4nx/twm4nx_config.hxx: ## @@ -448,7 +448,7 @@ */ #ifndef CONFIG_TWM4NX_INPUT_SIGNO -# define CONFIG_TWM4NX_INPUT_SIGNO 6 +# def

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1687: system/cu: Move fd_std_tty, g_tio_std and g_tio_dev to cu_globals_s

2023-03-29 Thread via GitHub
pkarashchenko merged PR #1687: URL: https://github.com/apache/nuttx-apps/pull/1687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@n

[nuttx-apps] branch master updated: system/cu: Move fd_std_tty, g_tio_std and g_tio_dev to cu_globals_s

2023-03-29 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new fd9c92e2e system/cu: Move fd_std_tty,

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1690: nshlib: Fix the ps command format

2023-03-29 Thread via GitHub
pkarashchenko merged PR #1690: URL: https://github.com/apache/nuttx-apps/pull/1690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@n

[nuttx-apps] branch master updated: nshlib: Fix the ps command format

2023-03-29 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 125cf7abe nshlib: Fix the ps command

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1689: examples/ftpd: Add support for choosing address family

2023-03-29 Thread via GitHub
pkarashchenko commented on code in PR #1689: URL: https://github.com/apache/nuttx-apps/pull/1689#discussion_r1151818003 ## examples/ftpd/ftpd_main.c: ## @@ -154,35 +154,75 @@ static void ftpd_accounts(FTPD_SESSION handle) } } +static void hint(void) +{ + fprintf(stderr,

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1689: examples/ftpd: Add support for choosing address family

2023-03-29 Thread via GitHub
pkarashchenko commented on code in PR #1689: URL: https://github.com/apache/nuttx-apps/pull/1689#discussion_r1151825372 ## examples/ftpd/ftpd_main.c: ## @@ -154,35 +154,75 @@ static void ftpd_accounts(FTPD_SESSION handle) } } +static void hint(void) +{ + fprintf(stderr,

[GitHub] [nuttx] acassis commented on pull request #8907: video/fb: add vsync offset support

2023-03-29 Thread via GitHub
acassis commented on PR #8907: URL: https://github.com/apache/nuttx/pull/8907#issuecomment-1488495671 @FASTSHIFT please include the summary in the commit log message. Do you have plans for this driver? Please consider submitting some usage application and also include a Documentation/ --

[GitHub] [nuttx] acassis merged pull request #8910: usrsock_server: Do not poll SOCK_CTRL

2023-03-29 Thread via GitHub
acassis merged PR #8910: URL: https://github.com/apache/nuttx/pull/8910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[nuttx] branch master updated (bed53538e8 -> 9fd4d6b767)

2023-03-29 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from bed53538e8 rndis: EP0 belongs to composite class if composite enabled add 0550082966 usrsock_server: add debug in

[GitHub] [nuttx] acassis merged pull request #8915: net/tcp: Reply RST when we cannot receive data

2023-03-29 Thread via GitHub
acassis merged PR #8915: URL: https://github.com/apache/nuttx/pull/8915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[nuttx] branch master updated: net/tcp: Reply RST when we cannot receive data

2023-03-29 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new b058f37353 net/tcp: Reply RST when we cannot rec

[GitHub] [nuttx] acassis merged pull request #8921: usbhost_hidkbd: Add the option to use interrupt transfers.

2023-03-29 Thread via GitHub
acassis merged PR #8921: URL: https://github.com/apache/nuttx/pull/8921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[nuttx] branch master updated: usbhost_hidkbd: Add the option to use interrupt transfers.

2023-03-29 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 18d196e968 usbhost_hidkbd: Add the option to use

[nuttx] branch master updated (18d196e968 -> 536739d2da)

2023-03-29 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 18d196e968 usbhost_hidkbd: Add the option to use interrupt transfers. add 536739d2da tools: Export LLVM style arc

[GitHub] [nuttx] acassis merged pull request #8916: tools: Export LLVM style arch info for non-c language

2023-03-29 Thread via GitHub
acassis merged PR #8916: URL: https://github.com/apache/nuttx/pull/8916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[GitHub] [nuttx] anchao commented on a diff in pull request #8862: syscall/libc: add more syscall/libc symbols into csv file

2023-03-29 Thread via GitHub
anchao commented on code in PR #8862: URL: https://github.com/apache/nuttx/pull/8862#discussion_r1151888586 ## include/stdlib.h: ## @@ -286,6 +286,11 @@ FAR void *bsearch(FAR const void *key, FAR const void *base, size_t nel, FAR const char *getprogname(void); +/* Registe

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8862: syscall/libc: add more syscall/libc symbols into csv file

2023-03-29 Thread via GitHub
pkarashchenko commented on code in PR #8862: URL: https://github.com/apache/nuttx/pull/8862#discussion_r1151891967 ## include/stdlib.h: ## @@ -286,6 +286,11 @@ FAR void *bsearch(FAR const void *key, FAR const void *base, size_t nel, FAR const char *getprogname(void); +/*

[GitHub] [nuttx] pkarashchenko commented on pull request #8862: syscall/libc: add more syscall/libc symbols into csv file

2023-03-29 Thread via GitHub
pkarashchenko commented on PR #8862: URL: https://github.com/apache/nuttx/pull/8862#issuecomment-1488542314 @acassis please review and merge if no more comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[nuttx] branch master updated (536739d2da -> 01b0305ab5)

2023-03-29 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 536739d2da tools: Export LLVM style arch info for non-c language add 01b0305ab5 risc-v: SV32 MMU support for qem

[GitHub] [nuttx] masayuki2009 merged pull request #8643: risc-v: SV32 MMU support for qemu-rv

2023-03-29 Thread via GitHub
masayuki2009 merged PR #8643: URL: https://github.com/apache/nuttx/pull/8643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

[GitHub] [nuttx] acassis merged pull request #8918: sched/sem_waitirq: Fix semaphore wait interruption when MMU is in use

2023-03-29 Thread via GitHub
acassis merged PR #8918: URL: https://github.com/apache/nuttx/pull/8918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[nuttx] 01/02: arch/risc-v: Set Supervisor User Memory (access) for idle process too

2023-03-29 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit fc44cbdbdbdf76fb75e7ad39d20e8b86e1f3c691 Author: Ville Juven AuthorDate: Tue Mar 28 13:57:08 2023 +0300 arch/risc-v

[nuttx] branch master updated (01b0305ab5 -> f468371332)

2023-03-29 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 01b0305ab5 risc-v: SV32 MMU support for qemu-rv. new fc44cbdbdb arch/risc-v: Set Supervisor User Memory (access)

[nuttx] 02/02: sched/sem_waitirq: Swap user mappings to MMU when releasing semaphore

2023-03-29 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit f4683713327aaeab0656e3ea83814b44267bdc4a Author: Ville Juven AuthorDate: Tue Mar 28 13:58:31 2023 +0300 sched/sem_w

[GitHub] [nuttx] fxysunshine opened a new pull request, #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
fxysunshine opened a new pull request, #8924: URL: https://github.com/apache/nuttx/pull/8924 ## Summary builtin apps so as to isolate or share something for each other, for example permisson or user data. ## Impact none if no any setting for builtin apps ## Testing

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152018690 ## include/nuttx/binfmt/binfmt.h: ## @@ -97,6 +97,7 @@ struct binary_s uint8_t priority;/* Task execution priority */ size_t stacksize;

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152032179 ## binfmt/binfmt_execmodule.c: ## @@ -266,6 +266,10 @@ int exec_module(FAR struct binary_s *binp, pid = tcb->cmn.pid; +#ifdef CONFIG_SCHED_USER_IDENTITY + tcb->

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152033729 ## binfmt/builtin.c: ## @@ -106,6 +106,8 @@ static int builtin_loadbinary(FAR struct binary_s *binp, binp->entrypt = builtin->main; binp->stacksize = builtin->s

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152035309 ## sched/Kconfig: ## @@ -622,6 +622,12 @@ config SCHED_THREAD_LOCAL This option enables architecture-specific TLS support (__thread/thread_local keywor

[GitHub] [nuttx-apps] fxysunshine opened a new pull request, #1691: apps: add default uid for builtin app

2023-03-29 Thread via GitHub
fxysunshine opened a new pull request, #1691: URL: https://github.com/apache/nuttx-apps/pull/1691 ## Summary builtin apps so as to isolate or share something for each other, for example permisson or user data. ## Impact That pull is followed by https://github.com/apache/

[GitHub] [nuttx] patacongo commented on issue #8917: nxsem_wait_irq with MMU

2023-03-29 Thread via GitHub
patacongo commented on issue #8917: URL: https://github.com/apache/nuttx/issues/8917#issuecomment-1488747711 Another option would be logic that finds the kernel space virtual address associated with the user space virtual address. That would assume that the entire address space is addressa

[GitHub] [nuttx] fxysunshine commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
fxysunshine commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152051414 ## include/nuttx/binfmt/binfmt.h: ## @@ -97,6 +97,7 @@ struct binary_s uint8_t priority;/* Task execution priority */ size_t stacksize;

[GitHub] [nuttx] fxysunshine commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
fxysunshine commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152063032 ## binfmt/binfmt_execmodule.c: ## @@ -266,6 +266,10 @@ int exec_module(FAR struct binary_s *binp, pid = tcb->cmn.pid; +#ifdef CONFIG_SCHED_USER_IDENTITY + tcb

[GitHub] [nuttx] fxysunshine commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
fxysunshine commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152068437 ## sched/Kconfig: ## @@ -622,6 +622,12 @@ config SCHED_THREAD_LOCAL This option enables architecture-specific TLS support (__thread/thread_local keyw

[GitHub] [nuttx] pussuw commented on issue #8917: nxsem_wait_irq with MMU

2023-03-29 Thread via GitHub
pussuw commented on issue #8917: URL: https://github.com/apache/nuttx/issues/8917#issuecomment-1488805778 Thanks for the response! Those APIs are known to me but as far as I can tell they either rely on the correct mappings already being active or on mm_struct and vm_area_struct (whic

[GitHub] [nuttx] pussuw commented on issue #8917: nxsem_wait_irq with MMU

2023-03-29 Thread via GitHub
pussuw commented on issue #8917: URL: https://github.com/apache/nuttx/issues/8917#issuecomment-1488812379 The inner workings of those copy_from/to_user are basically handling the access rights from/to user space. Normally the kernel cannot access the user's memory and those functions are us

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152168433 ## sched/Kconfig: ## @@ -622,6 +622,12 @@ config SCHED_THREAD_LOCAL This option enables architecture-specific TLS support (__thread/thread_local keywor

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152177168 ## binfmt/binfmt_execmodule.c: ## @@ -266,6 +266,10 @@ int exec_module(FAR struct binary_s *binp, pid = tcb->cmn.pid; +#ifdef CONFIG_SCHED_USER_IDENTITY + tcb->

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152032179 ## binfmt/binfmt_execmodule.c: ## @@ -266,6 +266,10 @@ int exec_module(FAR struct binary_s *binp, pid = tcb->cmn.pid; +#ifdef CONFIG_SCHED_USER_IDENTITY + tcb->

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152177168 ## binfmt/binfmt_execmodule.c: ## @@ -266,6 +266,10 @@ int exec_module(FAR struct binary_s *binp, pid = tcb->cmn.pid; +#ifdef CONFIG_SCHED_USER_IDENTITY + tcb->

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152195979 ## binfmt/builtin.c: ## @@ -106,6 +106,8 @@ static int builtin_loadbinary(FAR struct binary_s *binp, binp->entrypt = builtin->main; binp->stacksize = builtin->s

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8916: tools: Export LLVM style arch info for non-c language

2023-03-29 Thread via GitHub
xiaoxiang781216 commented on code in PR #8916: URL: https://github.com/apache/nuttx/pull/8916#discussion_r1152233441 ## tools/Zig.defs: ## @@ -0,0 +1,69 @@ + +# tools/Zig.defs +# +# Licensed to the Apach

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8921: usbhost_hidkbd: Add the option to use interrupt transfers.

2023-03-29 Thread via GitHub
xiaoxiang781216 commented on code in PR #8921: URL: https://github.com/apache/nuttx/pull/8921#discussion_r1152244784 ## drivers/usbhost/usbhost_hidkbd.c: ## @@ -353,10 +387,13 @@ static uint32_t g_devinuse; /* The following are used to managed the class creation operation */

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152177168 ## binfmt/binfmt_execmodule.c: ## @@ -266,6 +266,10 @@ int exec_module(FAR struct binary_s *binp, pid = tcb->cmn.pid; +#ifdef CONFIG_SCHED_USER_IDENTITY + tcb->

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8922: eMMC driver support

2023-03-29 Thread via GitHub
xiaoxiang781216 commented on code in PR #8922: URL: https://github.com/apache/nuttx/pull/8922#discussion_r1152243523 ## drivers/mmcsd/mmcsd_sdio.h: ## @@ -41,11 +68,11 @@ #define MMCSD_CMD8VOLTAGE_SHIFT (8)/* Bits 8-11: Supply voltage */ #define MMCS

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152177168 ## binfmt/binfmt_execmodule.c: ## @@ -266,6 +266,10 @@ int exec_module(FAR struct binary_s *binp, pid = tcb->cmn.pid; +#ifdef CONFIG_SCHED_USER_IDENTITY + tcb->

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152177168 ## binfmt/binfmt_execmodule.c: ## @@ -266,6 +266,10 @@ int exec_module(FAR struct binary_s *binp, pid = tcb->cmn.pid; +#ifdef CONFIG_SCHED_USER_IDENTITY + tcb->

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8922: eMMC driver support

2023-03-29 Thread via GitHub
xiaoxiang781216 commented on PR #8922: URL: https://github.com/apache/nuttx/pull/8922#issuecomment-1488999387 @radek-pesina please squash your change into one patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152195979 ## binfmt/builtin.c: ## @@ -106,6 +106,8 @@ static int builtin_loadbinary(FAR struct binary_s *binp, binp->entrypt = builtin->main; binp->stacksize = builtin->s

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152195979 ## binfmt/builtin.c: ## @@ -106,6 +106,8 @@ static int builtin_loadbinary(FAR struct binary_s *binp, binp->entrypt = builtin->main; binp->stacksize = builtin->s

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152195979 ## binfmt/builtin.c: ## @@ -106,6 +106,8 @@ static int builtin_loadbinary(FAR struct binary_s *binp, binp->entrypt = builtin->main; binp->stacksize = builtin->s

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04

2023-03-29 Thread via GitHub
xiaoxiang781216 commented on PR #8247: URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1489030302 > > but not good to simulator. > > @xiaoxiang781216 what do you mean? I mean it isn't good to limit Ubuntu to 20.04(can't upgrade to 22.04) just because Renesas gcc too

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04

2023-03-29 Thread via GitHub
xiaoxiang781216 commented on PR #8247: URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1489031748 Anyway, I try to upgrade the final image to Ubuntu 22.04, but build all toolchain with 20.04. Let's see what's happen. -- This is an automated message from the Apache Git Service.

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152177168 ## binfmt/binfmt_execmodule.c: ## @@ -266,6 +266,10 @@ int exec_module(FAR struct binary_s *binp, pid = tcb->cmn.pid; +#ifdef CONFIG_SCHED_USER_IDENTITY + tcb->

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152177168 ## binfmt/binfmt_execmodule.c: ## @@ -266,6 +266,10 @@ int exec_module(FAR struct binary_s *binp, pid = tcb->cmn.pid; +#ifdef CONFIG_SCHED_USER_IDENTITY + tcb->

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152195979 ## binfmt/builtin.c: ## @@ -106,6 +106,8 @@ static int builtin_loadbinary(FAR struct binary_s *binp, binp->entrypt = builtin->main; binp->stacksize = builtin->s

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152177168 ## binfmt/binfmt_execmodule.c: ## @@ -266,6 +266,10 @@ int exec_module(FAR struct binary_s *binp, pid = tcb->cmn.pid; +#ifdef CONFIG_SCHED_USER_IDENTITY + tcb->

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152177168 ## binfmt/binfmt_execmodule.c: ## @@ -266,6 +266,10 @@ int exec_module(FAR struct binary_s *binp, pid = tcb->cmn.pid; +#ifdef CONFIG_SCHED_USER_IDENTITY + tcb->

[GitHub] [nuttx] ldube commented on a diff in pull request #8921: usbhost_hidkbd: Add the option to use interrupt transfers.

2023-03-29 Thread via GitHub
ldube commented on code in PR #8921: URL: https://github.com/apache/nuttx/pull/8921#discussion_r1152377489 ## drivers/usbhost/usbhost_hidkbd.c: ## @@ -353,10 +387,13 @@ static uint32_t g_devinuse; /* The following are used to managed the class creation operation */ static mu

[GitHub] [nuttx] acassis opened a new pull request, #8925: esp32s3: Add esp32s3-meadow board

2023-03-29 Thread via GitHub
acassis opened a new pull request, #8925: URL: https://github.com/apache/nuttx/pull/8925 ## Summary Add esp32s3-meadow board ## Impact Users will be able to NuttX on this board ## Testing ESP32S3-Meadow -- This is an automated message from the Apache Git Service. To resp

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152177168 ## binfmt/binfmt_execmodule.c: ## @@ -266,6 +266,10 @@ int exec_module(FAR struct binary_s *binp, pid = tcb->cmn.pid; +#ifdef CONFIG_SCHED_USER_IDENTITY + tcb->

[GitHub] [nuttx] patacongo commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152168433 ## sched/Kconfig: ## @@ -622,6 +622,12 @@ config SCHED_THREAD_LOCAL This option enables architecture-specific TLS support (__thread/thread_local keywor

[GitHub] [nuttx] cederom commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
cederom commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152413114 ## sched/Kconfig: ## @@ -622,6 +622,12 @@ config SCHED_THREAD_LOCAL This option enables architecture-specific TLS support (__thread/thread_local keyword)

[GitHub] [nuttx] cederom commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
cederom commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152413114 ## sched/Kconfig: ## @@ -622,6 +622,12 @@ config SCHED_THREAD_LOCAL This option enables architecture-specific TLS support (__thread/thread_local keyword)

[GitHub] [nuttx] patacongo commented on pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on PR #8924: URL: https://github.com/apache/nuttx/pull/8924#issuecomment-1489218982 It would help to understand exactly what you are trying to accomplish to forcing some UID defined in a configuration. NuttX supports standard /etc/passwd and /etc/group files for as

[GitHub] [nuttx] tmedicci opened a new pull request, #8926: xtensa/sigdeliver: fix signal deliver when task is running on ther CPU

2023-03-29 Thread via GitHub
tmedicci opened a new pull request, #8926: URL: https://github.com/apache/nuttx/pull/8926 ## Summary While delivering a signal to a task that is currently running on the other core (SMP-enabled), the xtensa_sig_deliver needs to leave the critical section first. This should use the in

[GitHub] [nuttx] tmedicci opened a new issue, #8927: Potential problem regarding `sigdeliver` when SMP is enabled

2023-03-29 Thread via GitHub
tmedicci opened a new issue, #8927: URL: https://github.com/apache/nuttx/issues/8927 ## Summary While delivering a signal to a task that is currently running on the other core (SMP-enabled), the `_sig_deliver` needs to leave the critical section first (previously forced). This should

[GitHub] [nuttx] tmedicci commented on pull request #8926: xtensa/sigdeliver: fix signal deliver when task is running on ther CPU

2023-03-29 Thread via GitHub
tmedicci commented on PR #8926: URL: https://github.com/apache/nuttx/pull/8926#issuecomment-1489249038 Please check the related issue: https://github.com/apache/nuttx/issues/8927 It probably requires fixing for other architectures. -- This is an automated message from the Apache Git

[GitHub] [nuttx] cederom commented on a diff in pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
cederom commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1152413114 ## sched/Kconfig: ## @@ -622,6 +622,12 @@ config SCHED_THREAD_LOCAL This option enables architecture-specific TLS support (__thread/thread_local keyword)

[GitHub] [nuttx] tmedicci commented on issue #8927: Potential problem regarding `sigdeliver` when SMP is enabled

2023-03-29 Thread via GitHub
tmedicci commented on issue #8927: URL: https://github.com/apache/nuttx/issues/8927#issuecomment-1489259655 Some more thoughts about it: The `EXAMPLES_ALARM` app requires RTC driver to create a daemon and set an alarm that will deliver a signal to the application. This issue, however,

[GitHub] [nuttx] cederom commented on pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
cederom commented on PR #8924: URL: https://github.com/apache/nuttx/pull/8924#issuecomment-1489312285 Good question @patacongo I don't get it too :-) Could you please elaborate more on your goal @fxysunshine ? In Unix if you want to provide different applications with a separat

[GitHub] [nuttx] patacongo commented on pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
patacongo commented on PR #8924: URL: https://github.com/apache/nuttx/pull/8924#issuecomment-1489480226 > The problem you are facing right now is that UID/GID is not set even if you run the application by a given user? Currently, each task group does inherit the IDs of its parent. Bu

[GitHub] [nuttx] cederom commented on pull request #8924: binfmt: set default uid for builtin app

2023-03-29 Thread via GitHub
cederom commented on PR #8924: URL: https://github.com/apache/nuttx/pull/8924#issuecomment-1489508949 > @patacongo: We really need a published roadmap if where we are and where we want to go. I worry about _ad hoc_ solutions that are not based on a long term, POSIX compliant roadmap.

[nuttx-website] branch asf-site updated: Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs: f4683713327aaeab0656e3ea83814b44267bdc4a

2023-03-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new c50efb7d Publishing web: b50f5ca4

[GitHub] [nuttx-apps] wangchen61698 commented on a diff in pull request #1689: examples/ftpd: Add support for choosing address family

2023-03-29 Thread via GitHub
wangchen61698 commented on code in PR #1689: URL: https://github.com/apache/nuttx-apps/pull/1689#discussion_r1152667073 ## examples/ftpd/ftpd_main.c: ## @@ -154,35 +154,75 @@ static void ftpd_accounts(FTPD_SESSION handle) } } +static void hint(void) +{ + fprintf(stderr,

[GitHub] [nuttx-apps] wangchen61698 commented on a diff in pull request #1689: examples/ftpd: Add support for choosing address family

2023-03-29 Thread via GitHub
wangchen61698 commented on code in PR #1689: URL: https://github.com/apache/nuttx-apps/pull/1689#discussion_r1152667073 ## examples/ftpd/ftpd_main.c: ## @@ -154,35 +154,75 @@ static void ftpd_accounts(FTPD_SESSION handle) } } +static void hint(void) +{ + fprintf(stderr,

[GitHub] [nuttx] masayuki2009 commented on pull request #8926: xtensa/sigdeliver: fix signal deliver when task is running on ther CPU

2023-03-29 Thread via GitHub
masayuki2009 commented on PR #8926: URL: https://github.com/apache/nuttx/pull/8926#issuecomment-1489622816 >It probably requires fixing for other architectures. @tmedicci I applied the same changes to arch/arm/src/armv7-a/arm_sigdeliver.c locally and tested with sabre-6quad:smp on

[GitHub] [nuttx] no1wudi opened a new pull request, #8928: tools/riscv: Map extensions to certain cpu model for LLVM based toolc…

2023-03-29 Thread via GitHub
no1wudi opened a new pull request, #8928: URL: https://github.com/apache/nuttx/pull/8928 ## Summary RISCV has a modular instruction set. It's hard to define cpu-model to support all toolchain. For Zig, cpu model is this formal: generic_rv[32|64][i][m][a][f][d][c]

[GitHub] [nuttx] zhhyu7 commented on pull request #8864: netlink: add RTM_NEWADDR, RTM_DELADDR and RTM_GETADDR

2023-03-29 Thread via GitHub
zhhyu7 commented on PR #8864: URL: https://github.com/apache/nuttx/pull/8864#issuecomment-1489776950 > @zhhyu7 could you please include a sample example to use this new functionality? Maybe an IP change detection like this: https://stackoverflow.com/questions/579783/how-to-detect-ip-address

[GitHub] [nuttx-apps] no1wudi opened a new pull request, #1692: wamr: Simplify target handling by LLVM style arch info

2023-03-29 Thread via GitHub
no1wudi opened a new pull request, #1692: URL: https://github.com/apache/nuttx-apps/pull/1692 ## Summary Refactor only Depends on: https://github.com/apache/nuttx/pull/8928 ## Impact WAMR only ## Testing CI and local machine -- This is an automated message