fjpanag opened a new pull request, #1305:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1305
## Summary
Just a few minor changes in FTP daemon:
* Added one missing include.
* Fixed a conditional include.
* Silenced a couple of compiler warnings about unused vari
xiaoxiang781216 commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962142987
##
mm/mm_heap/mm_extend.c:
##
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem,
size_t size,
/* Take the memory manager s
xiaoxiang781216 merged PR #6994:
URL: https://github.com/apache/incubator-nuttx/pull/6994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 4cd4303c32 binfmt: Check return poin
xiaoxiang781216 commented on code in PR #6976:
URL: https://github.com/apache/incubator-nuttx/pull/6976#discussion_r962144412
##
fs/vfs/fs_ioctl.c:
##
@@ -67,53 +67,52 @@ int file_vioctl(FAR struct file *filep, int req, va_list ap)
ret = inode->u.i_ops->ioctl(filep, req,
xiaoxiang781216 commented on code in PR #6976:
URL: https://github.com/apache/incubator-nuttx/pull/6976#discussion_r962144677
##
fs/vfs/fs_ioctl.c:
##
@@ -67,53 +67,52 @@ int file_vioctl(FAR struct file *filep, int req, va_list ap)
ret = inode->u.i_ops->ioctl(filep, req,
xiaoxiang781216 commented on PR #6983:
URL: https://github.com/apache/incubator-nuttx/pull/6983#issuecomment-1236106960
That could be, but not relate to this change. inline_function map to
always_inline is very strange which should be fixed anyway.
--
This is an automated message from the
anchao opened a new pull request, #6996:
URL: https://github.com/apache/incubator-nuttx/pull/6996
## Summary
sched/wqueue: fix visual studio Compiler Error C2059
Designated initializers are a C99 (or newer) feature, and Visual Studio
doesn't (part) support C99 (or newer).
xiaoxiang781216 closed issue #6941: Wrong calculations by pow()
URL: https://github.com/apache/incubator-nuttx/issues/6941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
xiaoxiang781216 merged PR #6991:
URL: https://github.com/apache/incubator-nuttx/pull/6991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 985710665a Fixed pow() for negative
easonxiang commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962153628
##
mm/mm_heap/mm_extend.c:
##
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem,
size_t size,
/* Take the memory manager semaph
xiaoxiang781216 commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962153956
##
mm/mm_heap/mm_extend.c:
##
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem,
size_t size,
/* Take the memory manager s
xiaoxiang781216 commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962153956
##
mm/mm_heap/mm_extend.c:
##
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem,
size_t size,
/* Take the memory manager s
pkarashchenko commented on code in PR #6996:
URL: https://github.com/apache/incubator-nuttx/pull/6996#discussion_r962154008
##
sched/wqueue/kwork_thread.c:
##
@@ -79,7 +79,7 @@
struct hp_wqueue_s g_hpwork =
{
- {},
+ {0},
Review Comment:
```suggestion
{NULL, NULL}
xiaoxiang781216 commented on PR #6993:
URL: https://github.com/apache/incubator-nuttx/pull/6993#issuecomment-1236120452
@vbenso please fix the style issue report here:
https://github.com/apache/incubator-nuttx/runs/8166984531?check_suite_focus=true
--
This is an automated message from
pkarashchenko commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962154462
##
mm/mm_heap/mm_extend.c:
##
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem,
size_t size,
/* Take the memory manager sem
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r962154666
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r962154702
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,322 @@
+/
+ * arch/xtensa/sr
anchao commented on code in PR #6996:
URL: https://github.com/apache/incubator-nuttx/pull/6996#discussion_r962155345
##
sched/wqueue/kwork_thread.c:
##
@@ -90,7 +90,7 @@ struct hp_wqueue_s g_hpwork =
struct lp_wqueue_s g_lpwork =
{
- {},
+ {0},
Review Comment:
Done
anchao closed pull request #6766: libs/libc/queue: inline queue list to improve
performance
URL: https://github.com/apache/incubator-nuttx/pull/6766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
xiaoxiang781216 commented on PR #6978:
URL: https://github.com/apache/incubator-nuttx/pull/6978#issuecomment-1236123597
> Please rebase and fix build issues
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
xiaoxiang781216 merged PR #1305:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new e3a9be0d0 Minor changes in ftpd
anchao commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1236124183
> During the failed assertion, two threads operate on the same `conn`
structure.
>
> One is receiving data while the other tries to free the connection. Hence
the failed ass
xiaoxiang781216 commented on PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1236124580
@anjiahao1 please fix the warning:
https://github.com/apache/incubator-nuttx/runs/8127486548?check_suite_focus=true
and fix the conflict.
--
This is an automated m
xiaoxiang781216 commented on code in PR #6920:
URL: https://github.com/apache/incubator-nuttx/pull/6920#discussion_r962156685
##
include/string.h:
##
@@ -93,6 +93,7 @@ FAR void *memmem(FAR const void *haystack, size_t
haystacklen,
FAR const void *needle, siz
easonxiang commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962159273
##
mm/mm_heap/mm_extend.c:
##
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem,
size_t size,
/* Take the memory manager semaph
xiaoxiang781216 commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962161077
##
mm/mm_heap/mm_extend.c:
##
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem,
size_t size,
/* Take the memory manager s
xiaoxiang781216 commented on PR #6983:
URL: https://github.com/apache/incubator-nuttx/pull/6983#issuecomment-1236131695
> This change looks much better for understanding, but it increase the
length of the line. How about use always_inline instead, since it must be a
function if it was defin
fjpanag opened a new pull request, #1306:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1306
## Summary
The ftpd was previously only working on the hard-coded port 21.
This commit allows the user to specify the desired port when the server is
created.
## Impac
pkarashchenko commented on PR #6983:
URL: https://github.com/apache/incubator-nuttx/pull/6983#issuecomment-1236136888
always_inline should be fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
easonxiang commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962167636
##
mm/mm_heap/mm_extend.c:
##
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem,
size_t size,
/* Take the memory manager semaph
xiaoxiang781216 commented on PR #6983:
URL: https://github.com/apache/incubator-nuttx/pull/6983#issuecomment-1236143928
After more thought, it's wrong to change the macro to always_inline since if
user use this in source code directly:
```
__attribute__ ((always_inline))
```
the
xiaoxiang781216 merged PR #6996:
URL: https://github.com/apache/incubator-nuttx/pull/6996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 985710665a Fixed pow() for negative bases.
add 1b9c013dad sched/wqueue: fix visual studio Compiler Er
xiaoxiang781216 commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962170776
##
mm/mm_heap/mm_extend.c:
##
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem,
size_t size,
/* Take the memory manager s
xiaoxiang781216 commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962171656
##
mm/mm_heap/mm_extend.c:
##
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem,
size_t size,
/* Take the memory manager s
easonxiang commented on PR #6983:
URL: https://github.com/apache/incubator-nuttx/pull/6983#issuecomment-1236149634
> After more thought, it's wrong to change the macro to always_inline since
if user use this in source code directly:
>
> ```
> __attribute__ ((always_inline))
> ``
xiaoxiang781216 commented on PR #6983:
URL: https://github.com/apache/incubator-nuttx/pull/6983#issuecomment-1236150435
If so, I prefer add _function suffix like other similar macros
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
gustavonihei commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962203720
##
mm/mm_heap/mm_extend.c:
##
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem,
size_t size,
/* Take the memory manager sema
gustavonihei commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962203720
##
mm/mm_heap/mm_extend.c:
##
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem,
size_t size,
/* Take the memory manager sema
gustavonihei commented on PR #6993:
URL: https://github.com/apache/incubator-nuttx/pull/6993#issuecomment-1236201476
Could you please also refactor the critical sections to use the private spin
lock?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
gustavonihei commented on code in PR #6993:
URL: https://github.com/apache/incubator-nuttx/pull/6993#discussion_r962204382
##
arch/xtensa/src/esp32/esp32_twai.c:
##
@@ -495,7 +497,7 @@ static int esp32twai_setup(struct can_dev_s *dev)
/* Enable the CPU interrupt that is lin
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 574a838 Publishing web
easonxiang commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962230397
##
mm/mm_heap/mm_extend.c:
##
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem,
size_t size,
/* Take the memory manager semaph
easonxiang commented on PR #6983:
URL: https://github.com/apache/incubator-nuttx/pull/6983#issuecomment-1236237876
It seems there is no standard or rules to redefine the gcc features.
If possible to add some unify prefix to these macros, it may be more clear
to the users.
--
This is an
xiaoxiang781216 commented on PR #6983:
URL: https://github.com/apache/incubator-nuttx/pull/6983#issuecomment-1236240169
> It seems there is no standard or rules to redefine the gcc features. If
possible to add some unify prefix to these macros, it may be more clear to the
users.
it i
xiaoxiang781216 merged PR #6966:
URL: https://github.com/apache/incubator-nuttx/pull/6966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 1a9252aec9 nuttx/queue: change some
xiaoxiang781216 merged PR #6989:
URL: https://github.com/apache/incubator-nuttx/pull/6989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 1a9252aec9 nuttx/queue: change some queue function to macro
add 8e2b4576bf sensors/qencoder: add QEIO
52 matches
Mail list logo
