[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6976: fs: Run the default action of FIONBIO/FIOCLEX/FIONCLEX in success path

[GitBox]

xiaoxiang781216 commented on code in PR #6976:
URL: https://github.com/apache/incubator-nuttx/pull/6976#discussion_r962144677


##########
fs/vfs/fs_ioctl.c:
##########
@@ -67,53 +67,52 @@ int file_vioctl(FAR struct file *filep, int req, va_list ap)
       ret = inode->u.i_ops->ioctl(filep, req, arg);
     }
 
-  /* Check for File system IOCTL commands that can be implemented via
-   * fcntl()
-   */
-
-  if (ret != -ENOTTY)
-    {
-      return ret;
-    }
-
   switch (req)
     {
       case FIONBIO:
-        {
-          FAR int *nonblock = (FAR int *)(uintptr_t)arg;
-          if (nonblock && *nonblock)
-            {
-              filep->f_oflags |= O_NONBLOCK;
-            }
-          else
-            {
-              filep->f_oflags &= ~O_NONBLOCK;
-            }
-
-          ret = OK;
-        }
+        if (ret == OK || ret == -ENOTTY)

Review Comment:
   Can't since this will bypass FIOC_FILEPATH and BIOC_BLKSSZGET



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org