[GitHub] [incubator-nuttx] easonxiang commented on a diff in pull request #6995: mm: Check the function result with suitable macro.

[GitBox]

easonxiang commented on code in PR #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995#discussion_r962230397


##########
mm/mm_heap/mm_extend.c:
##########
@@ -77,7 +77,7 @@ void mm_extend(FAR struct mm_heap_s *heap, FAR void *mem, 
size_t size,
 
   /* Take the memory manager semaphore */
 
-  DEBUGVERIFY(mm_takesemaphore(heap));
+  DEBUGASSERT(mm_takesemaphore(heap));

Review Comment:
   The `ret` is referenced wether CONFIG_DEBUG_ASSERTIONS defined or not, so, 
unused_data is not required. I have build with enable and disable 
CONFIG_DEBUG_ASSERTIONS, there is no addition warnings.
   ```
   #define ASSERT(f)        do { if (!(f)) PANIC(); } while (0)
   # define DEBUGASSERT(f) ((void)(1 || (f)))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org