[GitHub] [incubator-nuttx] Donny9 commented on pull request #6783: libc/localtime: fix ats over time_t range

2022-08-11 Thread GitBox
Donny9 commented on PR #6783: URL: https://github.com/apache/incubator-nuttx/pull/6783#issuecomment-1211627055 > I hope to find some time end of week to get more precise look into this. > Maybe you can describe some sample values that are failing currently, so I can focus on that.

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

2022-08-11 Thread GitBox
pkarashchenko commented on PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#issuecomment-1211630200 > > In general I'm a bit lost in architecture here. The MTD layer is designed to provide unified "continuous" access across the underlying physical layer, so I expect that a

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6783: libc/localtime: fix ats over time_t range

2022-08-11 Thread GitBox
pkarashchenko commented on PR #6783: URL: https://github.com/apache/incubator-nuttx/pull/6783#issuecomment-1211635834 @Donny9 can this is somehow related to an issue that I asked in https://lists.apache.org/thread/h4pnnv1b9hfoglwg6hp6jz12xpytff7r ? -- This is an automated message from the

[GitHub] [incubator-nuttx] davids5 commented on pull request #6815: pic32mx: add option to disable JTAG at runtime

2022-08-11 Thread GitBox
davids5 commented on PR #6815: URL: https://github.com/apache/incubator-nuttx/pull/6815#issuecomment-1211639776 @rm5248 Please have a look at https://github.com/apache/incubator-nuttx/blob/2335b69120a3e36f1aa0cecc19c95208806cae54/arch/mips/src/pic32mx/pic32mx_head.S#L638 and https:

[GitHub] [incubator-nuttx] pkarashchenko opened a new issue, #6832: mktime() does not "normalize" struct tm argument

2022-08-11 Thread GitBox
pkarashchenko opened a new issue, #6832: URL: https://github.com/apache/incubator-nuttx/issues/6832 [Linux mktime|https://linux.die.net/man/3/mktime]: ``` The mktime() function modifies the fields of the tm structure as follows: tm_wday and tm_yday are set to values determined from the

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6816: arch/arm: Remove the critical section protection in up_invalidate_dcache_all

2022-08-11 Thread GitBox
pkarashchenko commented on PR #6816: URL: https://github.com/apache/incubator-nuttx/pull/6816#issuecomment-1211649428 But there is a note in function description: ``` * NOTE: This function forces L1 and L2 cache operations to be atomic * by disabling interrupts. ``` -- Th

[GitHub] [incubator-nuttx] davids5 merged pull request #6831: arch/arm/stm32f7: fix cache invalidation issue in Ethernet RX

2022-08-11 Thread GitBox
davids5 merged PR #6831: URL: https://github.com/apache/incubator-nuttx/pull/6831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[incubator-nuttx] branch master updated: arch/arm/stm32f7: fix cache invalidation issue in Ethernet RX

2022-08-11 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 27fe5a50c6 arch/arm/stm32f7: fix cache

[GitHub] [incubator-nuttx] Donny9 commented on pull request #6783: libc/localtime: fix ats over time_t range

2022-08-11 Thread GitBox
Donny9 commented on PR #6783: URL: https://github.com/apache/incubator-nuttx/pull/6783#issuecomment-1211654499 > @Donny9 can this is somehow related to an issue that I asked in https://lists.apache.org/thread/h4pnnv1b9hfoglwg6hp6jz12xpytff7r ? I‘m not sure if busyloop is related to "s

[GitHub] [incubator-nuttx] lukegluke commented on pull request #6831: arch/arm/stm32f7: fix cache invalidation issue in Ethernet RX

2022-08-11 Thread GitBox
lukegluke commented on PR #6831: URL: https://github.com/apache/incubator-nuttx/pull/6831#issuecomment-1211744660 @pkarashchenko Nice, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

2022-08-11 Thread GitBox
xiaoxiang781216 commented on PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#issuecomment-1211747978 The major difference is power failure safe, it's very hard to support this feature on mtdconfig without breaking the binary combability. -- This is an automated message

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6816: arch/arm: Remove the critical section protection in up_invalidate_dcache_all

2022-08-11 Thread GitBox
xiaoxiang781216 commented on PR #6816: URL: https://github.com/apache/incubator-nuttx/pull/6816#issuecomment-1211752994 If this is a requirement, all other cache function should be protected too, I think. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-nuttx] anjiahao1 commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

2022-08-11 Thread GitBox
anjiahao1 commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r943305478 ## include/nuttx/mtd/nvs_priv.h: ## @@ -0,0 +1,103 @@ +/ + * include/nuttx/mtd/nvs_

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request, #6833: SMP: fix crash when switch to new task which is still running

2022-08-11 Thread GitBox
GUIDINGLI opened a new pull request, #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833 ## Summary SMP: fix crash when switch to new task which is still running Situation: Assume we have 2 cpus, and busy run task0. CPU0

[GitHub] [incubator-nuttx] GUIDINGLI commented on pull request #6833: SMP: fix crash when switch to new task which is still running

2022-08-11 Thread GitBox
GUIDINGLI commented on PR #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833#issuecomment-1211783481 @masayuki2009 Could you help to review & test this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6833: SMP: fix crash when switch to new task which is still running

2022-08-11 Thread GitBox
masayuki2009 commented on PR #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833#issuecomment-1211793479 @GUIDINGLI Let me try this PR later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx] luojun1234 opened a new pull request, #6834: modify iob to support header padding and alignment features

2022-08-11 Thread GitBox
luojun1234 opened a new pull request, #6834: URL: https://github.com/apache/incubator-nuttx/pull/6834 Signed-off-by: luojun1 ## Summary modify iob to support buffer aligment and head padding features ## Impact 1.if config CONFIG_IOB_ALIGNMENT to 1 and CONFIG_IOB_HEADSIZE

[GitHub] [incubator-nuttx] rm5248 commented on pull request #6815: pic32mx: add option to disable JTAG at runtime

2022-08-11 Thread GitBox
rm5248 commented on PR #6815: URL: https://github.com/apache/incubator-nuttx/pull/6815#issuecomment-1211802399 @davids5 Using DEVCFG0 to disable JTAG is only available on the 1XX and 2XX series of PIC32MX, hence why I'm trying to disable JTAG on the 3XX/4XX/5XX/6XX/7XX series of chips. The

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6833: SMP: fix crash when switch to new task which is still running

2022-08-11 Thread GitBox
masayuki2009 commented on PR #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833#issuecomment-1211812059 @GUIDINGLI It seems that this PR affects all CPU architectures which support SMP. However, you modified ARM only. Please test this PR with all CPU architectures inclu

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6833: SMP: fix crash when switch to new task which is still running

2022-08-11 Thread GitBox
masayuki2009 commented on PR #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833#issuecomment-1211826856 @GUIDINGLI Also, can you provide the test code so that we can reproduce the bug? -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-nuttx] luojun1234 commented on a diff in pull request #6780: iob_s add io_private filed, user can use it to keep context

2022-08-11 Thread GitBox
luojun1234 commented on code in PR #6780: URL: https://github.com/apache/incubator-nuttx/pull/6780#discussion_r943351964 ## include/nuttx/mm/iob.h: ## @@ -108,7 +120,7 @@ struct iob_s #endif unsigned int io_pktlen; /* Total length of the packet */ - uint8_t io_data[CONFI

[GitHub] [incubator-nuttx] davids5 commented on pull request #6815: pic32mx: add option to disable JTAG at runtime

2022-08-11 Thread GitBox
davids5 commented on PR #6815: URL: https://github.com/apache/incubator-nuttx/pull/6815#issuecomment-1211838516 @rm5248 - Do you have a link to the version of the reference manual you are using? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-nuttx] PetervdPerk-NXP commented on pull request #6834: modify iob to support header padding and alignment features

2022-08-11 Thread GitBox
PetervdPerk-NXP commented on PR #6834: URL: https://github.com/apache/incubator-nuttx/pull/6834#issuecomment-1211874042 IOB is shared mechanism used for different stacks. So on a multi-stack system where `CONFIG_IOB_HEADSIZE>0` all stacks are affected, maybe this is even a design limitati

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6834: modify iob to support header padding and alignment features

2022-08-11 Thread GitBox
xiaoxiang781216 commented on PR #6834: URL: https://github.com/apache/incubator-nuttx/pull/6834#issuecomment-1211877080 @pkarashchenko @PetervdPerk @davids5 please review this new patch instead. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #6780: iob_s add io_private filed, user can use it to keep context

2022-08-11 Thread GitBox
xiaoxiang781216 closed pull request #6780: iob_s add io_private filed, user can use it to keep context URL: https://github.com/apache/incubator-nuttx/pull/6780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6780: iob_s add io_private filed, user can use it to keep context

2022-08-11 Thread GitBox
xiaoxiang781216 commented on PR #6780: URL: https://github.com/apache/incubator-nuttx/pull/6780#issuecomment-1211877214 let's close this now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [incubator-nuttx] davids5 commented on pull request #6815: pic32mx: add option to disable JTAG at runtime

2022-08-11 Thread GitBox
davids5 commented on PR #6815: URL: https://github.com/apache/incubator-nuttx/pull/6815#issuecomment-1211879044 @rm5248 I guess the issue is an unfortunate consequence of pin choices and reuse on the board you have. >I'm therefore extremely confused as to what exactly you thi

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6823: xtensa/esp32s2: Add basic support to SPI

2022-08-11 Thread GitBox
pkarashchenko merged PR #6823: URL: https://github.com/apache/incubator-nuttx/pull/6823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[incubator-nuttx] branch master updated: xtensa/esp32s2: Add basic support to SPI

2022-08-11 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 0b4ef1406d xtensa/esp32s2: Add b

[GitHub] [incubator-nuttx] GUIDINGLI commented on pull request #6833: SMP: fix crash when switch to new task which is still running

2022-08-11 Thread GitBox
GUIDINGLI commented on PR #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833#issuecomment-1211973093 > @GUIDINGLI It seems that this PR affects all CPU architectures which support SMP. However, you modified ARM only. Please test this PR with all CPU architectures including sim.

[GitHub] [incubator-nuttx] GUIDINGLI commented on pull request #6833: SMP: fix crash when switch to new task which is still running

2022-08-11 Thread GitBox
GUIDINGLI commented on PR #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833#issuecomment-1211974613 > @GUIDINGLI Also, can you provide the test code so that we can reproduce the bug? start a hello world main like this. while(1); just busy loop one cpu, then

[GitHub] [incubator-nuttx] luojun1234 commented on pull request #6834: modify iob to support header padding and alignment features

2022-08-11 Thread GitBox
luojun1234 commented on PR #6834: URL: https://github.com/apache/incubator-nuttx/pull/6834#issuecomment-1212007295 > IOB is shared mechanism used for different stacks. So on a multi-stack system where `CONFIG_IOB_HEADSIZE>0` all stacks are affected, maybe this is even a design limitation of

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6834: modify iob to support header padding and alignment features

2022-08-11 Thread GitBox
xiaoxiang781216 commented on PR #6834: URL: https://github.com/apache/incubator-nuttx/pull/6834#issuecomment-1212047063 > IOB is shared mechanism used for different stacks. So on a multi-stack system where `CONFIG_IOB_HEADSIZE>0` all stacks are affected, maybe this is even a design limitati

[GitHub] [incubator-nuttx] acassis merged pull request #6815: pic32mx: add option to disable JTAG at runtime

2022-08-11 Thread GitBox
acassis merged PR #6815: URL: https://github.com/apache/incubator-nuttx/pull/6815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[incubator-nuttx] branch master updated: pic32mx: add option to disable JTAG at runtime

2022-08-11 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 5d12e350da pic32mx: add option to disa

[GitHub] [incubator-nuttx] acassis commented on pull request #6815: pic32mx: add option to disable JTAG at runtime

2022-08-11 Thread GitBox
acassis commented on PR #6815: URL: https://github.com/apache/incubator-nuttx/pull/6815#issuecomment-1212061426 Since everything was clear now, I merged it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] PetervdPerk-NXP commented on pull request #6834: modify iob to support header padding and alignment features

2022-08-11 Thread GitBox
PetervdPerk-NXP commented on PR #6834: URL: https://github.com/apache/incubator-nuttx/pull/6834#issuecomment-1212105894 A Zero-copy ethernet solution would be indeed a great addition, when implementing a enet driver myself I noticed as well that packets are double stored and have a unnecess

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6834: modify iob to support header padding and alignment features

2022-08-11 Thread GitBox
xiaoxiang781216 commented on PR #6834: URL: https://github.com/apache/incubator-nuttx/pull/6834#issuecomment-1212265551 > A Zero-copy ethernet solution would be indeed a great addition, when implementing a enet driver myself I noticed as well that packets are double stored and have a unnece

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6834: modify iob to support header padding and alignment features

2022-08-11 Thread GitBox
xiaoxiang781216 commented on code in PR #6834: URL: https://github.com/apache/incubator-nuttx/pull/6834#discussion_r943739740 ## mm/iob/iob_initialize.c: ## @@ -30,14 +30,32 @@ #include "iob.h" +/ +

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6834: modify iob to support header padding and alignment features

2022-08-11 Thread GitBox
xiaoxiang781216 commented on code in PR #6834: URL: https://github.com/apache/incubator-nuttx/pull/6834#discussion_r943739740 ## mm/iob/iob_initialize.c: ## @@ -30,14 +30,32 @@ #include "iob.h" +/ +

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6834: modify iob to support header padding and alignment features

2022-08-11 Thread GitBox
xiaoxiang781216 commented on code in PR #6834: URL: https://github.com/apache/incubator-nuttx/pull/6834#discussion_r943739740 ## mm/iob/iob_initialize.c: ## @@ -30,14 +30,32 @@ #include "iob.h" +/ +

[GitHub] [incubator-nuttx] PetervdPerk-NXP opened a new issue, #6835: NuttX Net & IOB DMA incompatiblity

2022-08-11 Thread GitBox
PetervdPerk-NXP opened a new issue, #6835: URL: https://github.com/apache/incubator-nuttx/issues/6835 Currently almost all Ethernet MAC with DMA roughly work in the following manner ```mermaid sequenceDiagram participant DMA participant MAC driver MAC driver->>

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #6835: NuttX Net & IOB DMA incompatiblity

2022-08-11 Thread GitBox
xiaoxiang781216 commented on issue #6835: URL: https://github.com/apache/incubator-nuttx/issues/6835#issuecomment-1212368582 Nice diagram! > PR #6834 is trying to address this, however on system with mixed interfaces utilizing the NET stack & IOB. For example > > Interface MT

[GitHub] [incubator-nuttx] PetervdPerk-NXP commented on issue #6835: NuttX Net & IOB DMA incompatiblity

2022-08-11 Thread GitBox
PetervdPerk-NXP commented on issue #6835: URL: https://github.com/apache/incubator-nuttx/issues/6835#issuecomment-1212395720 > The special handle can be achieved before netdev pass IOB to TCP/IP stack in receiving direction. The similar thing can be done in the transmit direction too, why

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6836: iob: Remove iob_user_e enum and related code

2022-08-11 Thread GitBox
xiaoxiang781216 opened a new pull request, #6836: URL: https://github.com/apache/incubator-nuttx/pull/6836 ## Summary since it is impossible to track producer and consumer correctly if TCP/IP stack pass IOB directly to netdev See the related PR https://github.com/apache/incubator-nuttx

[GitHub] [incubator-nuttx] tmedicci opened a new pull request, #6837: Framebuffer lcddev buffer/master

2022-08-11 Thread GitBox
tmedicci opened a new pull request, #6837: URL: https://github.com/apache/incubator-nuttx/pull/6837 ## Summary PR following the discussion in https://github.com/apache/incubator-nuttx/pull/6657 In summary, LCD device driver and framebuffer are not able to use both the same `putarea` i

[incubator-nuttx-website] branch asf-site updated: Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a docs: 5d12e350da31324e632ee7da3a3062b05212b74c

2022-08-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 5b7a74f Publishing web

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6837: Framebuffer and lcddev buffer usage for LCD displays drivers

2022-08-11 Thread GitBox
xiaoxiang781216 commented on code in PR #6837: URL: https://github.com/apache/incubator-nuttx/pull/6837#discussion_r944048044 ## include/nuttx/lcd/lcd.h: ## @@ -90,7 +92,8 @@ struct lcd_planeinfo_s int (*putarea)(FAR struct lcd_dev_s *dev, fb_coord_t row_start,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6837: Framebuffer and lcddev buffer usage for LCD displays drivers

2022-08-11 Thread GitBox
xiaoxiang781216 commented on code in PR #6837: URL: https://github.com/apache/incubator-nuttx/pull/6837#discussion_r944048044 ## include/nuttx/lcd/lcd.h: ## @@ -90,7 +92,8 @@ struct lcd_planeinfo_s int (*putarea)(FAR struct lcd_dev_s *dev, fb_coord_t row_start,

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6833: SMP: fix crash when switch to new task which is still running

2022-08-11 Thread GitBox
masayuki2009 commented on PR #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833#issuecomment-1212677478 > > @GUIDINGLI Also, can you provide the test code so that we can reproduce the bug? > > start a hello world main like this. while(1); > > just busy loop one cpu

[GitHub] [incubator-nuttx] curuvar opened a new pull request, #6838: Added support for raspberrypi pico-w

2022-08-11 Thread GitBox
curuvar opened a new pull request, #6838: URL: https://github.com/apache/incubator-nuttx/pull/6838 ## Summary Added support for RaspberryPi Pico W ## Impact Adding support for the Pico W required changes to the networking software. The existing BCMF chips use SDIO to co

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #6835: NuttX Net & IOB DMA incompatiblity

2022-08-11 Thread GitBox
xiaoxiang781216 commented on issue #6835: URL: https://github.com/apache/incubator-nuttx/issues/6835#issuecomment-1212725040 > > The special handle can be achieved before netdev pass IOB to TCP/IP stack in receiving direction. The similar thing can be done in the transmit direction too, wh

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6838: Added support for raspberrypi pico-w

2022-08-11 Thread GitBox
xiaoxiang781216 commented on code in PR #6838: URL: https://github.com/apache/incubator-nuttx/pull/6838#discussion_r944143366 ## arch/arm/src/rp2040/Kconfig: ## @@ -685,6 +685,8 @@ config RP2040_BOARD_HAS_WS2812 bool "Has ws2812 pixels" default n depends

[GitHub] [incubator-nuttx] Donny9 opened a new pull request, #6839: vfs/fs_ioctl: fix minor issue

2022-08-11 Thread GitBox
Donny9 opened a new pull request, #6839: URL: https://github.com/apache/incubator-nuttx/pull/6839 ## Summary vfs/fs_ioctl: fix minor issue Signed-off-by: Jiuzhu Dong ## Impact ## Testing Local test -- This is an automated message from the Apache Git Serv

[GitHub] [incubator-nuttx] Donny9 closed pull request #6839: vfs/fs_ioctl: fix minor issue

2022-08-11 Thread GitBox
Donny9 closed pull request #6839: vfs/fs_ioctl: fix minor issue URL: https://github.com/apache/incubator-nuttx/pull/6839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu