luojun1234 commented on code in PR #6780:
URL: https://github.com/apache/incubator-nuttx/pull/6780#discussion_r943351964


##########
include/nuttx/mm/iob.h:
##########
@@ -108,7 +120,7 @@ struct iob_s
 #endif
   unsigned int io_pktlen; /* Total length of the packet */
 
-  uint8_t  io_data[CONFIG_IOB_BUFSIZE];
+  FAR uint8_t *io_data;

Review Comment:
   We have a better solution, discard this PR. Please refer to 
https://github.com/apache/incubator-nuttx/pull/6834



##########
mm/iob/Kconfig:
##########
@@ -32,6 +32,18 @@ config IOB_BUFSIZE
                chain.  This setting determines the data payload each 
preallocated
                I/O buffer.
 
+config IOB_ALIGNMENT
+       int "Alignment size of each I/O buffer"
+       default 1

Review Comment:
   We have a better solution, discard this PR. Please refer to 
https://github.com/apache/incubator-nuttx/pull/6834



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to