pkarashchenko commented on code in PR #6539:
URL: https://github.com/apache/incubator-nuttx/pull/6539#discussion_r909241025
##
arch/xtensa/src/esp32s2/esp32s2_i2c.c:
##
@@ -0,0 +1,1702 @@
+/
+ * arch/xte
pkarashchenko commented on code in PR #6540:
URL: https://github.com/apache/incubator-nuttx/pull/6540#discussion_r909293059
##
arch/xtensa/src/esp32s2/esp32s2_gpio.c:
##
@@ -61,27 +57,55 @@ static int g_gpio_cpuint;
* Private Functions
***
fjpanag opened a new pull request, #6541:
URL: https://github.com/apache/incubator-nuttx/pull/6541
## Summary
The NuttX-aware JLink plug-in cannot be built successfully in some distros.
At least in my case, the compiler was requesting for the option `-fPIC` to
be enabled.
##
pkarashchenko commented on code in PR #6541:
URL: https://github.com/apache/incubator-nuttx/pull/6541#discussion_r909387443
##
tools/Makefile.host:
##
@@ -228,7 +228,7 @@ endif
# jlink-nuttx - Create jlink GDBServer nuttx plugin
jlink-nuttx$(HOSTDYNEXT): jlink-nuttx.c
-
adamkaliszan opened a new pull request, #6542:
URL: https://github.com/apache/incubator-nuttx/pull/6542
## Summary
Stm NucleoWl55 BSP for E-ink display
BSP suooprt SPI driver.
Make menuconfig allow to chose pins that are conected to external e-ink
display with ssd1680 driver.
fjpanag commented on code in PR #6541:
URL: https://github.com/apache/incubator-nuttx/pull/6541#discussion_r909409655
##
tools/Makefile.host:
##
@@ -228,7 +228,7 @@ endif
# jlink-nuttx - Create jlink GDBServer nuttx plugin
jlink-nuttx$(HOSTDYNEXT): jlink-nuttx.c
- $(Q)
pkarashchenko commented on code in PR #6541:
URL: https://github.com/apache/incubator-nuttx/pull/6541#discussion_r909421280
##
tools/Makefile.host:
##
@@ -228,7 +228,7 @@ endif
# jlink-nuttx - Create jlink GDBServer nuttx plugin
jlink-nuttx$(HOSTDYNEXT): jlink-nuttx.c
-
pkarashchenko merged PR #6541:
URL: https://github.com/apache/incubator-nuttx/pull/6541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 47e40842a7 Added -fPIC option wh
mlyszczek commented on code in PR #6542:
URL: https://github.com/apache/incubator-nuttx/pull/6542#discussion_r909504747
##
boards/arm/stm32wl5/nucleo-wl55jc/src/stm32_ssd1680.c:
##
@@ -0,0 +1,194 @@
+/
+
mlyszczek commented on code in PR #6542:
URL: https://github.com/apache/incubator-nuttx/pull/6542#discussion_r909501788
##
boards/arm/stm32wl5/nucleo-wl55jc/src/stm32_spi.c:
##
@@ -0,0 +1,257 @@
+/
+ * b
onegray commented on code in PR #6422:
URL: https://github.com/apache/incubator-nuttx/pull/6422#discussion_r909503411
##
arch/arm/src/stm32wb/stm32wb_spi.c:
##
@@ -0,0 +1,1819 @@
+/
Review Comment:
T
mlyszczek commented on code in PR #6542:
URL: https://github.com/apache/incubator-nuttx/pull/6542#discussion_r909502611
##
boards/arm/stm32wl5/nucleo-wl55jc/src/stm32_spi.c:
##
@@ -0,0 +1,257 @@
+/
+ * b
pkarashchenko commented on code in PR #6422:
URL: https://github.com/apache/incubator-nuttx/pull/6422#discussion_r909297778
##
arch/arm/src/stm32wb/hardware/stm32wb_dmamux.h:
##
@@ -0,0 +1,284 @@
+/
+ *
pkarashchenko commented on code in PR #6422:
URL: https://github.com/apache/incubator-nuttx/pull/6422#discussion_r909297975
##
arch/arm/src/stm32wb/hardware/stm32wb_dmamux.h:
##
@@ -0,0 +1,284 @@
+/
+ *
gustavonihei commented on code in PR #6540:
URL: https://github.com/apache/incubator-nuttx/pull/6540#discussion_r909555107
##
arch/xtensa/src/esp32s2/esp32s2_gpio.c:
##
@@ -61,27 +57,55 @@ static int g_gpio_cpuint;
* Private Functions
gustavonihei commented on code in PR #6540:
URL: https://github.com/apache/incubator-nuttx/pull/6540#discussion_r909555107
##
arch/xtensa/src/esp32s2/esp32s2_gpio.c:
##
@@ -61,27 +57,55 @@ static int g_gpio_cpuint;
* Private Functions
fjpanag commented on PR #6363:
URL: https://github.com/apache/incubator-nuttx/pull/6363#issuecomment-1169925719
@xiaoxiang781216 @pkarashchenko please have a look on this proposition.
I think that this is the "best" solution, handling most of the edge cases.
So, formatting is ap
acassis commented on issue #6536:
URL:
https://github.com/apache/incubator-nuttx/issues/6536#issuecomment-1169926060
So, do you think it is better to keep these files "as it is" and just
replace individually when the issue pop-up? I was thinking more about the
integration with other system
gustavonihei commented on code in PR #6539:
URL: https://github.com/apache/incubator-nuttx/pull/6539#discussion_r909587462
##
arch/xtensa/src/esp32s2/esp32s2_i2c.c:
##
@@ -0,0 +1,1702 @@
+/
+ * arch/xten
gustavonihei commented on code in PR #6539:
URL: https://github.com/apache/incubator-nuttx/pull/6539#discussion_r909587747
##
arch/xtensa/src/esp32s2/esp32s2_i2c.c:
##
@@ -0,0 +1,1702 @@
+/
+ * arch/xten
gustavonihei commented on code in PR #6539:
URL: https://github.com/apache/incubator-nuttx/pull/6539#discussion_r909588605
##
arch/xtensa/src/esp32s2/esp32s2_i2c.c:
##
@@ -0,0 +1,1702 @@
+/
+ * arch/xten
gustavonihei commented on PR #6538:
URL: https://github.com/apache/incubator-nuttx/pull/6538#issuecomment-1169940447
@pkarashchenko I've ported the changes you had suggested on #6539, could you
please review this PR?
--
This is an automated message from the Apache Git Service.
To respond
gustavonihei commented on code in PR #6540:
URL: https://github.com/apache/incubator-nuttx/pull/6540#discussion_r909555107
##
arch/xtensa/src/esp32s2/esp32s2_gpio.c:
##
@@ -61,27 +57,55 @@ static int g_gpio_cpuint;
* Private Functions
adamkaliszan commented on code in PR #6542:
URL: https://github.com/apache/incubator-nuttx/pull/6542#discussion_r909602868
##
boards/arm/stm32wl5/nucleo-wl55jc/src/stm32_spi.c:
##
@@ -0,0 +1,257 @@
+/
+
adamkaliszan commented on code in PR #6542:
URL: https://github.com/apache/incubator-nuttx/pull/6542#discussion_r909618157
##
boards/arm/stm32wl5/nucleo-wl55jc/src/stm32_ssd1680.c:
##
@@ -0,0 +1,194 @@
+/***
btashton commented on issue #6536:
URL:
https://github.com/apache/incubator-nuttx/issues/6536#issuecomment-1170061854
Yes, also JavaScript has no issue with files with dashes.
On Wed, Jun 29, 2022, 5:35 AM Alan Carvalho de Assis <
***@***.***> wrote:
> So, do you think it is
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 47e40842a7 Added -fPIC option when building jlink-nuttx.so.
new 2d6cd7e580 xtensa/esp32s2: Fix the nu
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 31cddc922c337b8aa660ba1407db311a00a873aa
Author: Gustavo Henrique Nihei
AuthorDate: Wed Jun 15 17:42:51 2022
xiaoxiang781216 merged PR #6540:
URL: https://github.com/apache/incubator-nuttx/pull/6540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 2d6cd7e580bc3fe1b8b813b5bd5483873f93deeb
Author: Gustavo Henrique Nihei
AuthorDate: Wed Jun 15 17:34:59 2022
xiaoxiang781216 commented on code in PR #6540:
URL: https://github.com/apache/incubator-nuttx/pull/6540#discussion_r910159568
##
arch/xtensa/src/esp32s2/esp32s2_gpio.c:
##
@@ -61,27 +57,55 @@ static int g_gpio_cpuint;
* Private Functions
*
zhhyu7 opened a new pull request, #6543:
URL: https://github.com/apache/incubator-nuttx/pull/6543
VELAPLATFO-2660
Signed-off-by: zhanghongyu
Change-Id: Ieb6b1eadefa8e2a60832346f71fff23c85d2d88a
## Summary
## Impact
## Testing
--
This is an automated
AuroraRAS opened a new pull request, #6544:
URL: https://github.com/apache/incubator-nuttx/pull/6544
## Summary
add configs in menuconfig for mpu60x0 sensor
## Testing
passed with ESP32C3 and MPU6050
--
This is an automated message from the Apache Git Service.
To respond t
acassis commented on code in PR #6543:
URL: https://github.com/apache/incubator-nuttx/pull/6543#discussion_r910280562
##
include/net/if.h:
##
@@ -51,27 +51,43 @@
#define IFF_RUNNING(1 << 2) /* Carrier is available */
#define IFF_IPv6 (1 << 3) /* Configured fo
acassis commented on PR #6543:
URL: https://github.com/apache/incubator-nuttx/pull/6543#issuecomment-117033
Please include the right summary and remove these comments:
```
VELAPLATFO-2660
Signed-off-by: zhanghongyu
[zhanghon...@xiaomi.com](mailto:zhanghon...@xiaomi.com)
C
hartmannathan commented on code in PR #6543:
URL: https://github.com/apache/incubator-nuttx/pull/6543#discussion_r910286192
##
include/nuttx/net/netdev.h:
##
@@ -242,7 +242,7 @@ struct net_driver_s
/* Drivers interface flags. See IFF_* definitions in include/net/if.h */
hartmannathan commented on code in PR #6543:
URL: https://github.com/apache/incubator-nuttx/pull/6543#discussion_r910286192
##
include/nuttx/net/netdev.h:
##
@@ -242,7 +242,7 @@ struct net_driver_s
/* Drivers interface flags. See IFF_* definitions in include/net/if.h */
hartmannathan commented on PR #6543:
URL: https://github.com/apache/incubator-nuttx/pull/6543#issuecomment-1170359716
Please fix checkpatch error: "Remove Gerrit Change-ID's before submitting
upstream" Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
xiaoxiang781216 commented on PR #6363:
URL: https://github.com/apache/incubator-nuttx/pull/6363#issuecomment-1170365975
The change looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
xiaoxiang781216 commented on PR #6478:
URL: https://github.com/apache/incubator-nuttx/pull/6478#issuecomment-1170367631
@pkarashchenko @qinwei2004 I will give the feedback in the next couple days.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
xiaoxiang781216 commented on PR #6537:
URL: https://github.com/apache/incubator-nuttx/pull/6537#issuecomment-1170402526
> That OpenAMP looks promising and nice but I have some concerns. Mainly
about memory. It seems quite complex (and definately way more complex than
simple character device
pkarashchenko merged PR #6539:
URL: https://github.com/apache/incubator-nuttx/pull/6539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 31cddc922c xtensa/esp32s2: Sync GPIO driver implementation with
ESP32-S3
new 0657621848 xtensa/e
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 01b3ddd22f50ee865009d0eb0f624fb7e1b1a6d0
Author: Gustavo Henrique Nihei
AuthorDate: Wed Jun 15 15:49:35
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 43685aefc8fda38b892e5467ea8ddde295ffac44
Author: Gustavo Henrique Nihei
AuthorDate: Wed Jun 15 16:17:10
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 0657621848648f20149c550da45cc32e3321a499
Author: Gustavo Henrique Nihei
AuthorDate: Wed Jun 15 15:35:54
pkarashchenko merged PR #6538:
URL: https://github.com/apache/incubator-nuttx/pull/6538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 43685aefc8 esp32s2-saola-1: Add support for BMP180 pressure sensor
add ea829cf7d5 xtensa/esp32s3:
curuvar commented on PR #6528:
URL: https://github.com/apache/incubator-nuttx/pull/6528#issuecomment-1170579135
Can someone explain to me what the Check/check status means?
stm32_wlan_firmware.c isn't a file I did anything to.
--
This is an automated message from the Apache Git Service.
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new b1734ba Publishing web
xiaoxiang781216 merged PR #6544:
URL: https://github.com/apache/incubator-nuttx/pull/6544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new cd88ad3539 Make sensor mpu60x0 more
xiaoxiang781216 merged PR #6363:
URL: https://github.com/apache/incubator-nuttx/pull/6363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from cd88ad3539 Make sensor mpu60x0 more configurable in menuconfig
add 34e7ce5817 Reset syslog color befo
xiaoxiang781216 commented on PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#issuecomment-1170693084
why not squash the rename patch into the first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
zhhyu7 commented on code in PR #6543:
URL: https://github.com/apache/incubator-nuttx/pull/6543#discussion_r910561566
##
include/nuttx/net/netdev.h:
##
@@ -242,7 +242,7 @@ struct net_driver_s
/* Drivers interface flags. See IFF_* definitions in include/net/if.h */
- uint
zhhyu7 commented on code in PR #6543:
URL: https://github.com/apache/incubator-nuttx/pull/6543#discussion_r910572575
##
include/net/if.h:
##
@@ -51,27 +51,43 @@
#define IFF_RUNNING(1 << 2) /* Carrier is available */
#define IFF_IPv6 (1 << 3) /* Configured for
SPRESENSE opened a new pull request, #6545:
URL: https://github.com/apache/incubator-nuttx/pull/6545
## Summary
The field of first cluster under LFN directory entry must be 0x.
If it is set a value other than 0, it causes a problem where the long file
name entry cannot be found on
pkarashchenko commented on code in PR #6543:
URL: https://github.com/apache/incubator-nuttx/pull/6543#discussion_r910661429
##
include/net/if.h:
##
@@ -51,27 +51,43 @@
#define IFF_RUNNING(1 << 2) /* Carrier is available */
#define IFF_IPv6 (1 << 3) /* Configu
60 matches
Mail list logo