[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #6543: net_if: add IFF_LOOPBACK/POINTOPOINT/MULTICAST/BROADCAST

[GitBox]

hartmannathan commented on code in PR #6543:
URL: https://github.com/apache/incubator-nuttx/pull/6543#discussion_r910286192


##########
include/nuttx/net/netdev.h:
##########
@@ -242,7 +242,7 @@ struct net_driver_s
 
   /* Drivers interface flags.  See IFF_* definitions in include/net/if.h */
 
-  uint8_t d_flags;
+  uint32_t d_flags;

Review Comment:
   I just want to point out that in `struct ifreq` (declared in 
`include/net/if.h`), `ifru_flags` is defined as `uint8_t`. 
   
   In `netdev_ifr_ioctl()` (in `net/netdev/netdev_ioctl.c`), when processing 
SIOCGIFFLAGS, we have this assignment:
   
   ```
         case SIOCGIFFLAGS:  /* Gets the interface flags */
           {
             dev = netdev_ifr_dev(req);
             if (dev)
               {
                 req->ifr_flags = dev->d_flags;
               }
   
             ret = OK;
           }
           break;
   ```
   
   So flags will be truncated.
   
   Is this intentional?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org